Why is it goofy? As soon as you do ? it short circuits and returns null. It's just short hand for:
if (((string)null) != null && ...
Which short circuits and returns null immediately
A?.B.C will return null if A is null it won't throw.
ah yeah that's a good point! easier to understand the question in the :sunrise: after some :coffee: !
A?.B.C will throw if B is null but will short circuit on A being null - so yeah, that's expected behaviour :clap:
pushed azure implementations - and also sort of fixed a :bug: causing the service bus tests to fail occasionally
pull requests appear on the master branch so i've added a check to see if it's a pull request before gitlinking
looks like all the tests are passing - we just need Renew impls for InMemory and Redis now
also if someone wants to tackle auto renewing within the queue job that would be amazing
if you were wondering about microsoft's attitude to service bus it's still not in the new azure portal
even cloud services made it there ages ago!
spotted a bug with azure service bus - shall I add the fix to the same PR?
We probably should've broken this up, but that is my fault.
could be difficult to add a test for this without exposing even more things
jamie94bc/Foundatio@062d5e1
skip it
@jamie94bc really appreciate the help.
pretty excited that the service bus tests are passing now
kinda had me worried
I almost feel like we should run those tests on our ci
crapy thing is those tests create a new topic / queue in azure and never deletes it on teardown
earlier this week actually*
might want tear down code to remove all of them
could prefix them with test-guid
then remove all by prefix
also was wondering why delete queue doesn't actually delete the queue?
it just recreates it
that would be a bug
public override async Task DeleteQueueAsync() {
if (await _namespaceManager.QueueExistsAsync(_queueName).AnyContext())
await _namespaceManager.DeleteQueueAsync(_queueName).AnyContext();
_queueDescription = new QueueDescription(_queueName) {
MaxDeliveryCount = _retries + 1,
LockDuration = _workItemTimeout
};
await _namespaceManager.CreateQueueAsync(_queueDescription).AnyContext();
_enqueuedCount = 0;
_dequeuedCount = 0;
_completedCount = 0;
_abandonedCount = 0;
_workerErrorCount = 0;
}
it's not really a method that's appropriate for a queue is it?
should be named ClearQueueAsync()
if DeleteQueueAsync() actually deleted, we'd need to check for that on every method
or silently recreate
I think it’s really useful for unit tests
I’d think that _queueDescription = new QueueDescription(_queueName) {
MaxDeliveryCount = _retries + 1,
LockDuration = _workItemTimeout
};
MaxDeliveryCount = _retries + 1,
LockDuration = _workItemTimeout
};
await _namespaceManager.CreateQueueAsync(_queueDescription).AnyContext();
probably should be moved out
doesn’t belong there
I’m not sure why it was put there
I just checked all the other queues and they delete it and clear the counts
maybe the other ones are just ready to go and recreate themselfs on the fly
so maybe it needs to be lazy
or a flag to recreate it on enqueue
@ejsmith do you remember why this is. I think you wrote this implementation
I think the idea was just to be able to reset the queues and it was more for testing than anything else.
really should be part of a different contract.
not a normal queue operation
Redis resets everything and you can keep inserting.
same for inmemory
Could be Clear too though.
yeah, I was going to do that at one point, but didn’t want to take it on right then.
we had our hands full with moving everything to async
I say we need to go ahead and finish up this pull request and get it merged in and then we can look at further improvements.
Tests are passing
guess the only thing missing is updating the readme
there's something I don't like about making remote calls in constructors
IQueueManager.CreateQueueAsync(), IQueueManager.DeleteQueueAsync(), IQueueManager.GetQueuesAsync()
yeah i agree, this PR is getting way too long and out of scope
I think we need to bump the version as well
we changed the azure implementation type names
thoughts?
Yeah, I’m going to bump it to 3.1 or 4.0
what do you guys think
well if type names were changed it's a breaking change so it should be 4.0 really - unless we forward them
doesn't really feel like a 4.0 though
I think a 3.1
sigh
I need to get on the elastic search guys
I needthem to release a new 1.7 client release that targets json.net 8
If you do semantic versioning then any breaking change is a major bump.
Can be a small thing.
We haven't followed that well so far, but we should.
Yes, and they have bugs fixed that I need.
comment on that then
can’t update foundatio to 8 until elastic is updated
because of upstream dependencies
upstream is correct right?
foundatio.repos requires json.7
tests pass
wait how the heck do I merge yours into ours?
ah via the command line
@jamie94bc I think you did a really good job on this feature. Would love to have you join the team.
does that look right
Step 1: From your project repository, check out a new branch and test the changes.
git checkout -b jamie94bc-azurestoragequeues master
git pull git://github.com/jamie94bc/Foundatio.git azurestoragequeues
Step 2: Merge the changes and update on GitHub.
git checkout master
git merge --no-ff jamie94bc-azurestoragequeues
git push origin master
git checkout -b jamie94bc-azurestoragequeues master
git pull git://github.com/jamie94bc/Foundatio.git azurestoragequeues
Step 2: Merge the changes and update on GitHub.
git checkout master
git merge --no-ff jamie94bc-azurestoragequeues
git push origin master
I did that, but didn’t pull in your name into it :(
we should probably make an issue for adding redis and inmemory support
I am curious what you are using Foundatio for?
that looks really nice
i can't remember how i found foundatio - might have been the blog post about azure web jobs
I am working on an app that MIT is going to be our 1st customer.
What all Foundatio things are you using?
just the queues?
I’ll let @jamie94bc do the honors of clicking merge :) exceptionless/Foundatio#23
queues and jobs - i had partially written my own but the ones in foundatio were a bit more polished!
that’s great! My hope is that we can get more and more people using them and they will just keep getting better and better.
and metrics likely soon too, so basically everything except logging which i'm using serilog for!
so are you using just a mobile website for all your clients or do you have native apps too?
native apps written using Xamarin - iPhone, Android, Windows 8 and Windows Phone
We need to create a skeleton project for Foundatio that shows how all the things work together.
kinda have a sample project but it could be way better. was just waiting for coreclr
yeah, we need to keep working on that and updating it.
well exceptionless is a pretty good sample project - maybe not much of a skeleton though!
so great how you can use in memory implementations locally and then plug in redis or azure or whatever.
yeah, not much of a skeleton. :-)
just saw that
I wonder if we should stop pushing to nuget directly..
would be nice to send this to myget cause the 4.x release isn’t really ready until we do InMemory and redis implementations no?
I think we just need to not push to master until we are ready to release the nuget package.
but gitlink is failing so yeah
So what you would do if you wanted to not release that yet is just merge it to the branch we had.
Or create a pull request that points to a branch
I got that
But I think commit to master should pop out a nuget package.
but the code you added that’s not implemented in memory or redis
yeah I want easy too
Well really it does the same thing it already did now, but yes we need to implement those.
- IF "%APPVEYOR_REPO_BRANCH%"=="master" IF NOT "%APPVEYOR_PULL_REQUEST_NUMBER%" GitLink .\
- ps: if ((-not $env:APPVEYOR_PULL_REQUEST_NUMBER) -and ($env:APPVEYOR_REPO_BRANCH -eq 'master')) { & "GitLink .\" }
haven’t done batch nested if in a while
but I think that’s the same.. I don’t know if you have to do a condition on the IF NOT
sure
- ps: if ((-not $env:APPVEYOR_PULL_REQUEST_NUMBER) -and ($env:APPVEYOR_REPO_BRANCH -eq 'master')) { & "GitLink" .\ }
done! easier to edit directly on github than it was to mess around with my local repo
feel free to work on a branch in the main repo, we do feature/featurename for any feature work
makes life a lot easier :)
can you get appveyor to auto tag when it releases to nuget?
I’m sure you can
so a user just ran into an issue where posted form data / cookie had a null name and in our request info look up we threw an exception because dictionary.ContainsKey() threw on a null key lookup
think we should ignore any value that has a null key or replace it with <null>
wish you could see all the repo’s activity on the sidebar.
it doesn’t show activity for all of our repos only the main one
public useLocalStorage(): void {
throw 'Must be overridden.';
}
throw 'Must be overridden.';
}
wouldn’t we just see if storage is available and if it is use it?
ah I see it
doing it on the prototype
almost think it shouldn’t do anything so we never blow up
thoughts?
@ejsmith @adamzolotarev got back to us and had a question on the stacking key
did you want @stack
exceptionless/Exceptionless#187
I am thinking that seems nicer than some really long @manual_stacking_key
@stack still makes sense
@niemyjski
idk stacking_key
either is fine we can change what it looks like in the UI
is is the method name going to change
guess it would stay the same
so if you add it in CURL then you have to manually add it and know what you are adding.
and I think SetManualStackingKey is pretty self-explanatory.
@frankebersoll looks like settings are broken when using local storage.
thinking if we have the base useLocalStorage() method not throw an exception and instead calls applySavedServerSettings()
we can have the prototype call super or something
want me to start a teamviewer?
base useLocalStorage could do nothing instead of throwing. but will this ever happen?
i’m on my way to bed already :-(
that’s fine
if we exclude it and have it be a noop
thats bytes saved
or put it on the prototype from the entry js files?
what do you mean with „settings are broken“ when using local storage?
i haven’t tested settings, only events
anyone know what keys to press for that on osx
I could never figure out what dang key that is
so like we have saved configuration settings (from the server)
when we load local storage.. it should read those :)
the one before return
is it alt
I have the new apple keyboard and that symbol isn’t anywhere
and I’m like WTF key is that
Thanks! just got 5$ out of my keybaord
ahh
finally
haha
so, alternate
makes sense
but thinking about it, it seems that our storage limit (max entries) is applied to all entries, regardless of its type
any other symbols I should know after using a mac for 2 years
so, events would overwrite settings if the limit is reached
yeah
that seems bad
but I can live with that
that should apply to all implementations, including .net
so will just have to get them next runtime
kinda stinks
could save them on exit
or fix the root issue
so I think I fixed this :)
let me see
what do you think about how the KeyValueStorage is implemented
so I noticed for node you save all events to the root directory \exceptionless
does node have anything like tmp storage paths for apps? if so I wonder if we should store events in \tmp??\exceptionless
I think it’s good
i don’t think there is a platform independent way of getting temporary storage
we could add a dot prefix!
woot
idk
i rather have it in the application directory. nobody cleans up tmp
I think I’d want that too
btw, did you see my comment on get date?
if we know that we always have timestamp information in there, it would make the implementation easier
right now, i add an own timestamp (which is a zero-based integer)
I get that, just wasn’t sure if we wanted to try and parse it or if it would be more work than we wanted to do
ok
so
but I notice and issue with the node filesystem and I’m not sure if it’s an issue or not
I ran the code task to debug the express app and it creates the exceptionless folder at the root of the .exceptionless instead of \example\express.exceptionless
wonder if that’s just because of my working diretory>?
express\.exceptionless
it should be relative to the entry point, right?
yeah I’d think it’d be where my app exists and not some random folder
but I’m not 100% sure how it’s launching it
{
"name": "Express",
"request": "launch",
"type": "node",
"program": "example/express/app.js",
"runtimeArgs": [
"--nolazy"
],
"sourceMaps": true,
"outDir": "dist"
},
"name": "Express",
"request": "launch",
"type": "node",
"program": "example/express/app.js",
"runtimeArgs": [
"--nolazy"
],
"sourceMaps": true,
"outDir": "dist"
},
yeah
so I’m running from root
guess the only issue is if you do this
\blake > node \wwwroot\my-app-1\app.js
it’s going to create it in my user folder
is that to be expected as a node developer (I don’t know very much about node.. I don’t write node apps for a living).
i would expect it in the app dir
is that __3
is that just the insert number?
that is the timestamp that is used to keep the order
that’s what i mean could be made easier if we just use the timestamp that is already encoded in the keys
- [ ] Use encoding of timestamp in keys
- [ ] Default path for NodeFileStorage:
.expressrelative to the application root path - [ ] Customizable path for NodeFileStorage
- [ ] Submit existing events on startup
let me see what i can do tomorrow :-)
yeah
guess you could just call process queue after you call useIsolatedStorage.. the only problem with that is what if you are still configuring the client?
guess we should just wait until they submit an event? or what
once you feel it’s good ship it. Looks good from the one over I gave it
do you have stats on that?
we really should update the user agent for node...
right now js and node submit the same user agent
so no way to tell them apart
:(
should do that
just found a downside of my new apt
my ip keeps changing so I gotta update acl lists :(
99% are unfixed
people better get cracking
I would try changing the signature of the storage methods
what did you make me do
haha
?
... The type in there and it generates the timestamp itself
sorry
focusing on charts
lol
so you wouldnt create the key outside (ex-q-12345) but just put "ex" in there or so
so you have the object and a namespace
Then i can remove the __3 stuff
@ejsmith looks like we anaylize the user agent and don’t have a raw field so it’s impossible for us to get a report on user agents that submitted to us.. but that user agents includes request info… We should store the submission user agent some place and index it raw. so we can get reports on that
yeah
that would be good
we should never touch anything that’s not prefixed with our key
@frankebersoll I think that’s a good plan...
we could do ex-settings
or something :)
Librato is driving me nuts.
I just want a simple view of my stats.
They are charging us $280 a month.
for real
I didnt think it was that much
my other app
exceptionless is only like $20
Do I need that?
I am working on a CRM app that lets you integrate all of the various SaaS products out there and lets you get a holistic view of your contacts.
Sigh, feels like today I’ve been running around with a head cut off.. Got a ton done but not my own work item goal :\
Were really close to pushing out new js and .net clients with stacking / and local storage
@srijken is there anything we need to do for deduping or are we letting that bake even more?
@ejsmith that looks useful, but I dont think our company is in the target group for it
Need to work on getting manual stacking out server side and help with raygun support.
do you guys use any saas products like stripe, mailchimp, constantcontact, desk, zendesk, hubspot.
I worry we dont. We use Exchange and... Microsoft Dynamics? Lol
ok
nevermind then ;-)
or do you have that?
Damn English speaking people thinking that English is the only language. ;-)
we came across a localization bug with our .net client and server yesterday.. exceptionless/Exceptionless.Net@0a4e07e
Do we need to do something for js?
basically they were getting 90,234,17,00 for lat,long and it has to be 90.234,17.00
:)
https://github.com/exceptionless/Exceptionless.JavaScript/blob/master/src/EventBuilder.ts#L82 wondering if we need to do anything for js number formatting
can you try that on your system and let me know what it outputs
well we know the exact format it has to be in
See you tomorrow!
doesn’t work very good
haha wanted to see what it would output
love it when vs2015 just crashes
with 3 unsaved files
even if it is a POS and crashed
:-)
it didn't
I just added the redismetricsclient
gonna work on an API endpoint now that spits out stats… then we can use that for Exceptionless as well.
@niemyjski
:)
exceptionless/Exceptionless@af1c01a :)
def WIP, don’t know if I like the results models or how rules are being applied
I don’t think rules should even be in there at all. but we can talk about that later tonight