These are chat archives for exceptionless/Discuss

21st
Feb 2016
Jamie Clarke
@jamie94bc
Feb 21 2016 10:26
@niemyjski normal weekend stuff! - cycling, food shopping and wondering where the time went!
Logger is being replaced in Foundatio? :smile:
some of the stuff in .NET core logging looks pretty useful
Jamie Clarke
@jamie94bc
Feb 21 2016 10:33
Blake Niemyjski
@niemyjski
Feb 21 2016 12:57
:)
Eric J. Smith
@ejsmith
Feb 21 2016 13:33
Yeah, I am starting to work on it. Need to get rid of the static Logger class and inject the logger. I am undecided on whether to take on another dependency. I source imported the MS logging stuff right now, but I am currently leaning toward just taking the dependency.
What do you think @jamie94bc ?
Jamie Clarke
@jamie94bc
Feb 21 2016 13:34
if the dependency doesn't depend on anything else, take it
else you're introducing a more code to maintain
having a strange issue with automapper - it's not respecting my reverse mappings when create missing type maps is enabled
but i can't repro seperately
not a fun sunday!
Eric J. Smith
@ejsmith
Feb 21 2016 13:36
Well it doesn't for net45, but the core one has a ton of dependencies. But I guess that is how it works in core. Everything is a package.
Yeah, that sounds like a lot of fun! :-)
That is why I am changing out the logging. Because I'm trying to figure out a broken test that only fails on the build server.
But the logging doesn't work good.
Jamie Clarke
@jamie94bc
Feb 21 2016 13:38
aha
i had a brief look at that yesterday but I couldn't work out what was causing it - stepping through the code, by the time it invoked the Abandoned event, the handler had been removed (presumerably the queue had been disposed)
Eric J. Smith
@ejsmith
Feb 21 2016 13:41
Hmm weird. I guess logging will help a lot with it. If I can get logging to work reliably in unit tests.
Jamie Clarke
@jamie94bc
Feb 21 2016 13:42
yeah logging was doing nothing for me
Blake Niemyjski
@niemyjski
Feb 21 2016 13:49
exceptionless/Exceptionless#194
don’t know if I’m working too much or enjoying the work to much
had dreams about the raygun issue and charts lol
Eric J. Smith
@ejsmith
Feb 21 2016 13:52
Haha
I dream in code all the time.
Blake Niemyjski
@niemyjski
Feb 21 2016 13:53
yeah
think I’m going to build a chart control that takes a json object like this
Eric J. Smith
@ejsmith
Feb 21 2016 13:53
The really messed up dreams are when I solve really hard problems that I had been working on in my sleep. That doesn't seem right.
Blake Niemyjski
@niemyjski
Feb 21 2016 13:54
[{ ’type’: ‘avg’, ‘field }]
Eric J. Smith
@ejsmith
Feb 21 2016 13:54
Let's get the charts that we already have updated to use these and add the chart options first.
Blake Niemyjski
@niemyjski
Feb 21 2016 13:55
[{ ’type’: ‘avg’, ‘field’: ‘value’, ’timeline’, true, ’name’: 'Average Duration' }]
Eric J. Smith
@ejsmith
Feb 21 2016 13:55
Then after that we should build a hard coded report. Then we can start working on dynamic reports
Blake Niemyjski
@niemyjski
Feb 21 2016 13:55
name is shown on hovers / labels client side
well yes
but that literally is going to take me minutes now
but the problem I have is we only allow the value field and some of our charts do much more than that
Eric J. Smith
@ejsmith
Feb 21 2016 13:56
Cool get it done then. :-)
Blake Niemyjski
@niemyjski
Feb 21 2016 13:56
so we gotta figure out what to allow
maybe just allow all fields for now and limit it before we release :)
Eric J. Smith
@ejsmith
Feb 21 2016 13:56
No, just add more allowed fields.
Don't open it wide open yet.
Blake Niemyjski
@niemyjski
Feb 21 2016 13:57
ok
I’ll add the ones I use
but I’m pretty excited about this
profiled it yesterday and it’s just as fast
Eric J. Smith
@ejsmith
Feb 21 2016 13:57
Can add a bunch of known fields.
Blake Niemyjski
@niemyjski
Feb 21 2016 13:57
and it’s going to allow us to delete a CRAP ton of stats code
Eric J. Smith
@ejsmith
Feb 21 2016 13:57
Awesome! So you got it tested and working?
Blake Niemyjski
@niemyjski
Feb 21 2016 13:57
yeah
it’s all tested server side
starting on the client side now :)
Eric J. Smith
@ejsmith
Feb 21 2016 13:58
I kind of want to add it to the repo project.
Blake Niemyjski
@niemyjski
Feb 21 2016 13:58
yeah
kinda specific to elastic tho
I could add it tehre
Eric J. Smith
@ejsmith
Feb 21 2016 13:58
Like have Irepository and then have something advanced for stats
Blake Niemyjski
@niemyjski
Feb 21 2016 13:58
abstract the rules stuff
yeah
Eric J. Smith
@ejsmith
Feb 21 2016 13:58
Facets, search, stats
Yeah because my project will need this too.
So the more we work together the better the code will get
Blake Niemyjski
@niemyjski
Feb 21 2016 14:00
yeah
yeah I can move it over
Eric J. Smith
@ejsmith
Feb 21 2016 14:00
I want to remove any of the filter by query stuff out of irepo
Blake Niemyjski
@niemyjski
Feb 21 2016 14:00
you still need to update to the repos..
Eric J. Smith
@ejsmith
Feb 21 2016 14:00
Then add some advanced interfaces.
That ES repos would support.
And potentially other full text solutions.
Blake Niemyjski
@niemyjski
Feb 21 2016 14:01
yeah
I think we definitely need to improve our query stuff
Eric J. Smith
@ejsmith
Feb 21 2016 14:02
And need to finish the session changes too.
Blake Niemyjski
@niemyjski
Feb 21 2016 14:02
some of it should be moved from the elastic repo to the base one
yep
Eric J. Smith
@ejsmith
Feb 21 2016 14:02
Too much damn work to do.
Blake Niemyjski
@niemyjski
Feb 21 2016 14:02
get on that :)
Eric J. Smith
@ejsmith
Feb 21 2016 14:02
Gotta work on the logging
I need to fix that bug so I can move forward with metrics
@jamie94bc was it you that was interested in metrics
Eric J. Smith
@ejsmith
Feb 21 2016 14:06
Redis metrics
comments are golden
lol
Jamie Clarke
@jamie94bc
Feb 21 2016 14:07
@ejsmith potentially, yeah!
Eric J. Smith
@ejsmith
Feb 21 2016 14:08
I have it working and the cool thing is that you can retrieve the metrics in your app. So we can do a dashboard to display what's going on in the system.
And the in memory client works the exact same way as redis.
Jamie Clarke
@jamie94bc
Feb 21 2016 14:12
cool! :smile_cat:
hey did you know we can add appveyor build failures to gitter?
Eric J. Smith
@ejsmith
Feb 21 2016 14:13
we actually send them to slack now, but yeah, it would be better if they went to a public channel.
not sure I want that noise in here, but we could create a notifications channel.
Eric J. Smith
@ejsmith
Feb 21 2016 14:50
doing one of those cool big refactors where there are like 200 errors and you are making progress and it gets down to like 50 and then another 200 more pop up.
Blake Niemyjski
@niemyjski
Feb 21 2016 14:51
Yup
Eric J. Smith
@ejsmith
Feb 21 2016 14:51
this will be really good though.
now when you create your services, you can opt into logging… which most people don’t want logging for the external things.
plus this logger is going to be WAY faster
and no more statics
Jamie Clarke
@jamie94bc
Feb 21 2016 15:07
so we can remove EnableLogging flags? :clap:
Eric J. Smith
@ejsmith
Feb 21 2016 15:07
yes :-)
Blake Niemyjski
@niemyjski
Feb 21 2016 15:14
:)
Eric J. Smith
@ejsmith
Feb 21 2016 15:22
So I tried just adding the logging package, but it doesn’t support .net 4.5
so I guess I am stuck source importing until RC2 comes out and we do some more refactoring to change our target to netstandard
seems like nuget is a mess right now.
and I am worried it will get worse because everything will be a package in .net core.
already run into issues with package version requirements
Jamie Clarke
@jamie94bc
Feb 21 2016 16:06
as long as they version the packages individually
which it looks like they are doing
Eric J. Smith
@ejsmith
Feb 21 2016 16:07
yeah, and they put version constraints on them and then people get stuck because they cant find a version graph that solves all dependencies.
Blake Niemyjski
@niemyjski
Feb 21 2016 16:22
We should take the time and do coreclr
/net standard
Eric J. Smith
@ejsmith
Feb 21 2016 16:22
yeah, we will when they stop breaking shit.
Jamie Clarke
@jamie94bc
Feb 21 2016 16:25
they've pushed the v1 release back to later this year
Eric J. Smith
@ejsmith
Feb 21 2016 16:26
yeah
Jamie Clarke
@jamie94bc
Feb 21 2016 16:26
i can't reproduce the test failure on my work pc - yet i could on my laptop!
very strange
Eric J. Smith
@ejsmith
Feb 21 2016 16:26
if they were wise, they would release when it’s ready. When it’s been out in the wild and people are having success with it.
hmm… I couldn’t reproduce it at all.
wonder if it’s a computer speed issue.
Jamie Clarke
@jamie94bc
Feb 21 2016 16:27
well, there's still things like EF that haven't got all the features ready
yeah i was thinking that
Eric J. Smith
@ejsmith
Feb 21 2016 17:15
this logging change is epic
will be good when it’s done… but kicking my butt now. :-)
Frank Ebersoll
@frankebersoll
Feb 21 2016 18:05
how would you expect Exceptionless.Relay to be deployed?
it’s gonna be a Node app, for platform independence
Eric J. Smith
@ejsmith
Feb 21 2016 18:08
I think we would just want to do a npm install for the package, no?
hopefully as simple as npm install exceptionless-relay … then you just set the target URL in the config?
Frank Ebersoll
@frankebersoll
Feb 21 2016 18:09
don’t users want it to be running as a windows service or daemon?
Eric J. Smith
@ejsmith
Feb 21 2016 18:10
well its a node app… there are things to run node apps as services.
Frank Ebersoll
@frankebersoll
Feb 21 2016 18:10
i would like to provide a script for that
Eric J. Smith
@ejsmith
Feb 21 2016 18:11
what are you thinking?
Frank Ebersoll
@frankebersoll
Feb 21 2016 18:11
i don’t know. i’m figuring it out myself
there is pm2, docker, node-windows, forever-service….
Eric J. Smith
@ejsmith
Feb 21 2016 18:13
yeah, I like the idea of keeping the relay itself a simple package and then give instruction for options to run it as a service.
Frank Ebersoll
@frankebersoll
Feb 21 2016 18:13
i wouldn’t expect Exceptionless.Relay admins to have experience with any of that. i don’t know if i would expect even Node experience
Eric J. Smith
@ejsmith
Feb 21 2016 18:14
I have seen other npm packages do that.
Frank Ebersoll
@frankebersoll
Feb 21 2016 18:14
so i would go for npm package + install script that does all the heavy lifting
Eric J. Smith
@ejsmith
Feb 21 2016 18:14
think if they are setting up a relay, its a bit of an advanced thing.
guess we just gotta try some things out and see how it feels.
Frank Ebersoll
@frankebersoll
Feb 21 2016 18:15
okay. what requirements would you have for the relay / did you hear of?
Eric J. Smith
@ejsmith
Feb 21 2016 18:21
What do you mean?
Frank Ebersoll
@frankebersoll
Feb 21 2016 18:33
what should it do :-)
minimal features i think should be 1.) POSTing events, 2.) mapping of apikey to actual server in json config, 3.) simple queue management (delete queue when apikey disappears from config)
Eric J. Smith
@ejsmith
Feb 21 2016 19:05
Should it just forward whatever key is sent with each request?
Frank Ebersoll
@frankebersoll
Feb 21 2016 19:05
i think so?
Eric J. Smith
@ejsmith
Feb 21 2016 19:05
Me too.
Frank Ebersoll
@frankebersoll
Feb 21 2016 19:05
i would create one ExceptionlessClient for each configured api key
and just dispatch the events to them
Eric J. Smith
@ejsmith
Feb 21 2016 19:06
Sounds awesome.
Frank Ebersoll
@frankebersoll
Feb 21 2016 19:06
then, queue management would be out-of-the-box using the new local storage.
Eric J. Smith
@ejsmith
Feb 21 2016 19:06
Yeah!
I like it.