These are chat archives for exceptionless/Discuss

24th
Feb 2016
Eric J. Smith
@ejsmith
Feb 24 2016 00:22 UTC
Dojo?
I like it.
Just removed the MS logging dependency and it actually works out really well.
Frank Ebersoll
@frankebersoll
Feb 24 2016 00:25 UTC
How did you refactor the logging now? I haven’t read the chat about it in detail
Eric J. Smith
@ejsmith
Feb 24 2016 00:25 UTC
exceptionless/Foundatio#28
oops
Frank Ebersoll
@frankebersoll
Feb 24 2016 00:27 UTC
that looks fairly generic.
Eric J. Smith
@ejsmith
Feb 24 2016 00:27 UTC
yeah, I think that is a good thing, right?
lol
it’s stronly modeled after the MS logging.
which they did some good stuff with the ability to make it fast.
eventually we can switch it out to theirs with hopefully no pain.
Frank Ebersoll
@frankebersoll
Feb 24 2016 00:29 UTC
okay
so, now it should be possible to log to TestOutputHelper during tests?
Eric J. Smith
@ejsmith
Feb 24 2016 00:30 UTC
yep, that’s done...
Frank Ebersoll
@frankebersoll
Feb 24 2016 00:30 UTC
nice
need to clean it up a little more
Blake Niemyjski
@niemyjski
Feb 24 2016 00:31 UTC
great job
Eric J. Smith
@ejsmith
Feb 24 2016 00:31 UTC
but it works pretty darn good.
Blake Niemyjski
@niemyjski
Feb 24 2016 00:31 UTC
let me know what I need to do once you get that merged in
for the foundatio repositories
Eric J. Smith
@ejsmith
Feb 24 2016 00:31 UTC
and the logging is already helped
Blake Niemyjski
@niemyjski
Feb 24 2016 00:32 UTC
btw, just spent the past hour upgrading our ui dependencies
Eric J. Smith
@ejsmith
Feb 24 2016 00:32 UTC
and definitely faster… and also lets people opt into getting logging for Foundatio stuff
Blake Niemyjski
@niemyjski
Feb 24 2016 00:32 UTC
hadn’t done it in forever and there were major new versions of about every grunt package
Eric J. Smith
@ejsmith
Feb 24 2016 00:32 UTC
would imagine that most people don’t want logging of our things.
Blake Niemyjski
@niemyjski
Feb 24 2016 00:32 UTC
and updated test runners using new major version of phantomjs
Eric J. Smith
@ejsmith
Feb 24 2016 00:33 UTC
cool
wow
that is so nice
Jamie Clarke
@jamie94bc
Feb 24 2016 08:41 UTC
wow logging output in AppVeyor!
that's aweosme @ejsmith
so looks like the azure storage queue test failing is actually the fault of the inmemorymetricsclient
nevermind, yes I am! Need :coffee:
blob
Jamie Clarke
@jamie94bc
Feb 24 2016 08:46 UTC
brilliant :laughing:
Jamie Clarke
@jamie94bc
Feb 24 2016 09:21 UTC
i wonder if msft will ever give up on logging libs and just adopt an OSS one like they did for json.net
Blake Niemyjski
@niemyjski
Feb 24 2016 11:08 UTC
Probably not
Jamie Clarke
@jamie94bc
Feb 24 2016 11:22 UTC
morning! :smiley:
Eric J. Smith
@ejsmith
Feb 24 2016 12:54 UTC
Morning
Yes, logging is MUCH better now.
Now time to figure out our flakey tests
The waitforcounter stuff was completely changed recently. So there is probably some bug there.
Blake Niemyjski
@niemyjski
Feb 24 2016 12:58 UTC
Morning
Eric J. Smith
@ejsmith
Feb 24 2016 15:26 UTC
alright, done with logging… time to try and figure this counter crap out. :-)
Blake Niemyjski
@niemyjski
Feb 24 2016 15:29 UTC
:)
Eric J. Smith
@ejsmith
Feb 24 2016 15:30 UTC
some sort of deadlock going on… I really need to grow some async / concurrency skills.
Blake Niemyjski
@niemyjski
Feb 24 2016 15:32 UTC
yeah
Eric J. Smith
@ejsmith
Feb 24 2016 15:59 UTC
I’m ready for M#
Jamie Clarke
@jamie94bc
Feb 24 2016 16:13 UTC
M# :laughing:
Eric J. Smith
@ejsmith
Feb 24 2016 16:13 UTC
Have you read the Midori blogs?
M# is a dirivative of C# that they used to build an OS designed from the ground for concurrency and safety
Jamie Clarke
@jamie94bc
Feb 24 2016 16:14 UTC
oh right, i googled it and got this
Eric J. Smith
@ejsmith
Feb 24 2016 16:14 UTC
makes entire classes of concurrency and safery bugs impossible.
They cancelled the project.
Jamie Clarke
@jamie94bc
Feb 24 2016 16:20 UTC
wow those blog posts
so lengthy
i wonder why the .NET team made the decision to use Task<T> instead of Promise<T>
Blake Niemyjski
@niemyjski
Feb 24 2016 16:24 UTC
yeah
Eric J. Smith
@ejsmith
Feb 24 2016 16:25 UTC
yeah those blog posts are epic
very interesting though
Jamie Clarke
@jamie94bc
Feb 24 2016 16:31 UTC
yeah i'll have to find time to read them properly
i fear they are a little bit beyond me though ;)
Blake Niemyjski
@niemyjski
Feb 24 2016 16:46 UTC
@renekarberg I’m free to take a look into that issue with you
@renekarberg just let me know when you are free.
Eric J. Smith
@ejsmith
Feb 24 2016 16:46 UTC
they are beyond me too.
Blake Niemyjski
@niemyjski
Feb 24 2016 18:30 UTC
The following is going on the organization general tab
What do you guys think of the colors / text etc..
Screen Shot 2016-02-24 at 12.29.53 PM.png
Screen Shot 2016-02-24 at 12.29.43 PM.png
feedback is greatly appreciated
Eric J. Smith
@ejsmith
Feb 24 2016 18:30 UTC
I love the info and HATE the colors.
Blake Niemyjski
@niemyjski
Feb 24 2016 18:36 UTC
find me better colors please :)
the red is from our alert boxes green is what was there before
Eric J. Smith
@ejsmith
Feb 24 2016 18:36 UTC
Christmas has arrived!
Blake Niemyjski
@niemyjski
Feb 24 2016 18:36 UTC
yeah
but green == accepted
red == rejected
Eric J. Smith
@ejsmith
Feb 24 2016 18:39 UTC
dude, gonna have to trust me on this one… it looks horrible.
the data is awesome
we will make it look better.
Blake Niemyjski
@niemyjski
Feb 24 2016 18:45 UTC
yeah I know it looks horrible
why I asked for feedback
haha
Welcome @BillHenning
Eric J. Smith
@ejsmith
Feb 24 2016 18:47 UTC
good, because I’m giving it to you.
:-)
Blake Niemyjski
@niemyjski
Feb 24 2016 18:47 UTC
do we like the red line
Eric J. Smith
@ejsmith
Feb 24 2016 18:47 UTC
whether you want it or not.
Blake Niemyjski
@niemyjski
Feb 24 2016 18:47 UTC
for limit
Eric J. Smith
@ejsmith
Feb 24 2016 18:48 UTC
I think we should do a white dashed line
for the limit
Blake Niemyjski
@niemyjski
Feb 24 2016 18:48 UTC
can’t do white dashed
Eric J. Smith
@ejsmith
Feb 24 2016 18:48 UTC
and maybe a gray color for the blocked ones
why not?
Blake Niemyjski
@niemyjski
Feb 24 2016 18:48 UTC
or dashed anything shutterstock/rickshaw#532
also when you don’t have any events or your event limit is small.. the white line would be rendered against a white background
so gotta be something other than white and can’t be currently dashed :(
Bill Henning
@BillHenning
Feb 24 2016 18:49 UTC
yeah white wouldn't work
Eric J. Smith
@ejsmith
Feb 24 2016 18:49 UTC
ahh yeah
Blake Niemyjski
@niemyjski
Feb 24 2016 18:50 UTC
so maybe a dark gray for the blocked line
and a light gray for blocked (dark for limit*)
Bill Henning
@BillHenning
Feb 24 2016 18:51 UTC
try it out
either the limit or blocked should be red to indicate a danger area :)
Blake Niemyjski
@niemyjski
Feb 24 2016 18:53 UTC
yeah
I agree
Eric J. Smith
@ejsmith
Feb 24 2016 18:53 UTC
could do a red dashed line for limit, but not a huge section.
Blake Niemyjski
@niemyjski
Feb 24 2016 18:53 UTC
@ejsmith that’s d3 not rickshaw
Eric J. Smith
@ejsmith
Feb 24 2016 18:53 UTC
it looks horrible.
rickshaw is just helpers on top of D3.
Blake Niemyjski
@niemyjski
Feb 24 2016 18:53 UTC
and we go through rickshaw for everything
yeah
if you want me to spend a day on making it a dashed line
it’s fine by me
we aren’t manually adding anything to an svg element
rickshaw is using a renderer under the hood to do it
Eric J. Smith
@ejsmith
Feb 24 2016 18:55 UTC
shutterstock/rickshaw@90d0cfd
Blake Niemyjski
@niemyjski
Feb 24 2016 18:55 UTC
ah
missed dotsize
tried line plot
and didn’t see examples anywhere
ok
give me a few
Blake Niemyjski
@niemyjski
Feb 24 2016 19:08 UTC
nope
would have to create my own renderer
that doesn’t work
dotted line != dashed
Screen Shot 2016-02-24 at 1.09.14 PM.png
Bill Henning
@BillHenning
Feb 24 2016 19:12 UTC
getting better but the colors are making my eyes bleed :)
Blake Niemyjski
@niemyjski
Feb 24 2016 19:15 UTC
Screen Shot 2016-02-24 at 1.14.25 PM.png
Bill Henning
@BillHenning
Feb 24 2016 19:15 UTC
better
Blake Niemyjski
@niemyjski
Feb 24 2016 19:19 UTC
what should I change
Bill Henning
@BillHenning
Feb 24 2016 19:20 UTC
the green and red clash... but in general the green will always be less than red unless you are maxing out your usage, so it's maybe not a prob
Blake Niemyjski
@niemyjski
Feb 24 2016 19:20 UTC
yeah
kinda agree on that
are you all fine with it shipping like that
now is the time to speak
I’m not in love with the colors but I’m not a designer
if you guys don’t like it let me know
@BillHenning should the reset text go here or on the billing tab
Bill Henning
@BillHenning
Feb 24 2016 19:22 UTC
can you show what the page looks like now?
Eric J. Smith
@ejsmith
Feb 24 2016 19:22 UTC
please help him @BillHenning I have a meeting.
Blake Niemyjski
@niemyjski
Feb 24 2016 19:22 UTC
I can show you what I sent, I’m on a customers page...
this section goes right below the organization name
here
:)
Bill Henning
@BillHenning
Feb 24 2016 19:23 UTC
for colors, what if for the green you used a muted green instead of the very intense dark green? something more like the saturation or opacity you use for red
then the limit line would render better
i'd show the Plan details right under org name and then the reset date and days until under that, and graph under that and see how it looks
Blake Niemyjski
@niemyjski
Feb 24 2016 19:26 UTC
ok
too light of color
Screen Shot 2016-02-24 at 1.26.21 PM.png
Screen Shot 2016-02-24 at 1.28.42 PM.png
Screen Shot 2016-02-24 at 1.28.42 PM.png
Bill Henning
@BillHenning
Feb 24 2016 19:30 UTC
try someting between lightest and medium one for green and then do lighter gray for blocked
Blake Niemyjski
@niemyjski
Feb 24 2016 19:32 UTC
Screen Shot 2016-02-24 at 1.31.56 PM.png
Bill Henning
@BillHenning
Feb 24 2016 19:34 UTC
slightly lighter green
Blake Niemyjski
@niemyjski
Feb 24 2016 19:42 UTC

6EBC1A

is there a color thing I can do to get a lighter from hex
ah cool
found it
looks off from the rest of the site too much
the previous color at least matched the filter text
Screen Shot 2016-02-24 at 1.44.24 PM.png
Bill Henning
@BillHenning
Feb 24 2016 19:46 UTC

a4d56f

Blake Niemyjski
@niemyjski
Feb 24 2016 19:47 UTC
Screen Shot 2016-02-24 at 1.47.11 PM.png
Blake Niemyjski
@niemyjski
Feb 24 2016 19:57 UTC
@BillHenning
how does htat look to you
Bill Henning
@BillHenning
Feb 24 2016 19:58 UTC
contrast is better between green/red
Blake Niemyjski
@niemyjski
Feb 24 2016 19:59 UTC
Screen Shot 2016-02-24 at 1.57.23 PM.png
I gotta come up with better text because it reads like you can delete events to free up the event limit
which is not true
maybe company has 73,000 events remaining until March 1st 2016
Bill Henning
@BillHenning
Feb 24 2016 20:00 UTC
x-axis labels need trimmed
Blake Niemyjski
@niemyjski
Feb 24 2016 20:00 UTC
can’t do that with rickshaw
:(
doesn’t know about fluid laylouts
Bill Henning
@BillHenning
Feb 24 2016 20:00 UTC
can you do Jun '16?
Blake Niemyjski
@niemyjski
Feb 24 2016 20:00 UTC
yes
Bill Henning
@BillHenning
Feb 24 2016 20:00 UTC
or might not even need year here
theyd see it on mouseover, no?
Blake Niemyjski
@niemyjski
Feb 24 2016 20:01 UTC
yeah
Bill Henning
@BillHenning
Feb 24 2016 20:01 UTC
do month abbrev only
Blake Niemyjski
@niemyjski
Feb 24 2016 20:01 UTC
Screen Shot 2016-02-24 at 1.57.23 PM.png
Bill Henning
@BillHenning
Feb 24 2016 20:02 UTC
doesn't look any diff
"This organization has the Large plan. 24,000 events remaining until this billing period's limit is reached on March 1, 2016 (7 days)."
and maybe stick that under the graph and see how it looks
Blake Niemyjski
@niemyjski
Feb 24 2016 20:05 UTC
Screen Shot 2016-02-24 at 2.04.15 PM.png
Screen Shot 2016-02-24 at 2.03.54 PM.png
look at my text
I just got your text. I can use your text if you don’t like what I put
what axis text do you like better
Bill Henning
@BillHenning
Feb 24 2016 20:06 UTC
if you are always showing a year back from now, the month name only is prob fine.... as for text, i like mine a little better
Blake Niemyjski
@niemyjski
Feb 24 2016 20:06 UTC
ok
Bill Henning
@BillHenning
Feb 24 2016 20:06 UTC
could add your click here link to the end of mine
Blake Niemyjski
@niemyjski
Feb 24 2016 20:07 UTC
"This organization has the Large plan. 24,000 events remaining until this billing period's limit is reached on March 1, 2016 (7 days)."
the billing periods limit is reset on march
Blake Niemyjski
@niemyjski
Feb 24 2016 20:14 UTC
You are currently on the Large plan with ~24,000 events remaining until this billing period's limit is reset on March 1, 2016 (7 days). Click here to change your plan or billing information.
Bill Henning
@BillHenning
Feb 24 2016 20:14 UTC
ya
Eric J. Smith
@ejsmith
Feb 24 2016 20:20 UTC
I think we should limit the number of points on the chart. Maybe do 6 or 12
Also say move the warning sentence to below the graph in smaller text.
Bill Henning
@BillHenning
Feb 24 2016 20:21 UTC
yeah
Eric J. Smith
@ejsmith
Feb 24 2016 20:24 UTC
how about making the red limit line thinner.
Blake Niemyjski
@niemyjski
Feb 24 2016 20:28 UTC
give me a few
renekarberg
@renekarberg
Feb 24 2016 20:32 UTC
Hi Niemyski,
I have time now
Found out in the meantime it's related to "Enable Code Analysis on Build"
(Project properties)
Blake Niemyjski
@niemyjski
Feb 24 2016 20:36 UTC
hmm
does it work without enabling it
?
@renekarberg
renekarberg
@renekarberg
Feb 24 2016 20:37 UTC
yes
Blake Niemyjski
@niemyjski
Feb 24 2016 20:38 UTC
If you want to start a team viewer I could jump on and see if we can figure it out
I wonder if it’s worth putting together a sample app and logging a bug with microsoft
kinda of a weird cryptic issue
renekarberg
@renekarberg
Feb 24 2016 20:38 UTC
it's really easy to reproduce
i tried a couple of the win phone templates in the visual studio project gallery
Blake Niemyjski
@niemyjski
Feb 24 2016 20:39 UTC
have you seen this with any other library?
renekarberg
@renekarberg
Feb 24 2016 20:40 UTC
no, but i started working with windows phone two months ago
Blake Niemyjski
@niemyjski
Feb 24 2016 20:40 UTC
how do you think we should proceed?
not sure what we can do? guess I could install windows phone sdk and try to reproduce or you think we file a bug with microsoft?
renekarberg
@renekarberg
Feb 24 2016 20:41 UTC
it's up to you, i think it's related to some of the warnings when you run code analysis on the Exceptionless.Portable project
for instance the IDisposable warnings
some combination of the warnings in Exceptionless.Portable and "windows phone"
Blake Niemyjski
@niemyjski
Feb 24 2016 20:43 UTC
@ejsmith can’t make the line thinner
yeah
Is there any chance you could dig deeper into this with us?
maybe figure out what exactly is causing it with that setting?
I have no experience with windows mobile :(
if you want I can jump on a team viewer with you and try to dig into it
renekarberg
@renekarberg
Feb 24 2016 20:44 UTC
it's really simple to reproduce, but sure, i can give it a shot
Blake Niemyjski
@niemyjski
Feb 24 2016 20:44 UTC
thanks, that would be a huge help
if you need any assistance or have any questions just send me a pm
renekarberg
@renekarberg
Feb 24 2016 20:45 UTC
already got it :-)
thanks
and thank you for a great product
Blake Niemyjski
@niemyjski
Feb 24 2016 20:46 UTC
no problem
were here for you guys :)
we are*
renekarberg
@renekarberg
Feb 24 2016 20:48 UTC
btw do you have a sample visual studio solution using the exceptionless events/features/geo location stuff etc.?
some sort of recommended/best practice implementation
Blake Niemyjski
@niemyjski
Feb 24 2016 20:48 UTC
yeah
ah
that .net solution has some samples
but mostly for testing out things.
If you want I could meet up with you and take a look at your solution and give you pointers / tips
renekarberg
@renekarberg
Feb 24 2016 20:49 UTC
yeah, it's more like "one liners". i was looking for a more complete sample project
if you know what i mean :-)
Blake Niemyjski
@niemyjski
Feb 24 2016 20:50 UTC
yeah, currently we don’t really have a real world sample app that’s all populated with exceptionless stuff
renekarberg
@renekarberg
Feb 24 2016 20:50 UTC
ok, would be nice. someone should write a book
:-)
it's late here! have a nice day and thanks again
Blake Niemyjski
@niemyjski
Feb 24 2016 21:03 UTC
want to volunteer :)?
have a good night
Eric J. Smith
@ejsmith
Feb 24 2016 21:15 UTC
man, this logging stuff is getting real good.
in my unit test I have this:
        LoggerFactory.SetLogLevel<SampleQueueJob>(LogLevel.Error);
        LoggerFactory.SetLogLevel<InMemoryMetricsClient>(LogLevel.Trace);
love it
Blake Niemyjski
@niemyjski
Feb 24 2016 21:20 UTC
nice
so
feedback on this page
@BillHenning wanted the warning text below right
Eric J. Smith
@ejsmith
Feb 24 2016 21:21 UTC
show the latest version
Blake Niemyjski
@niemyjski
Feb 24 2016 21:21 UTC
it’s uploading very slowly
Eric J. Smith
@ejsmith
Feb 24 2016 21:21 UTC
I wanted that too.
Blake Niemyjski
@niemyjski
Feb 24 2016 21:21 UTC
Screen Shot 2016-02-24 at 3.20.34 PM.png
I can make it smaller below the chart..
the thing about data points.. shouldn’t that be controlled server side??
Bill Henning
@BillHenning
Feb 24 2016 21:22 UTC
yes and more whitespace betweeen the chart and the text under it
Blake Niemyjski
@niemyjski
Feb 24 2016 21:22 UTC
like these should be cleaned up
probably should show usage for your retention period but I do think we should be cleaning up these usages
probably should happen server side
Screen Shot 2016-02-24 at 3.23.34 PM.png
Eric J. Smith
@ejsmith
Feb 24 2016 21:26 UTC
dude, the warning goes on the bottom
not the useful info
Bill Henning
@BillHenning
Feb 24 2016 21:26 UTC
The following usage data should say the "usage data above"
and i agree with eric
Eric J. Smith
@ejsmith
Feb 24 2016 21:26 UTC
more the useful stuff back on top
just the notice part goes on the bottom
can you make the red line thinner?
Bill Henning
@BillHenning
Feb 24 2016 21:27 UTC
well the current plan para might look fine if swapped with the italics part
Blake Niemyjski
@niemyjski
Feb 24 2016 21:29 UTC
slaps bill who told me to put it on the bottom
Eric J. Smith
@ejsmith
Feb 24 2016 21:29 UTC
no, you didn’t read right
Bill Henning
@BillHenning
Feb 24 2016 21:29 UTC
i think i like it better below the chart but hard to tell without seeing both options
Blake Niemyjski
@niemyjski
Feb 24 2016 21:30 UTC
@ejsmith NO I CANNOT MAKE IT THINNER
Eric J. Smith
@ejsmith
Feb 24 2016 21:30 UTC
why?
Blake Niemyjski
@niemyjski
Feb 24 2016 21:30 UTC
Screen Shot 2016-02-24 at 3.28.43 PM.png
Screen Shot 2016-02-24 at 3.28.52 PM.png
because the render has three options total and none of them is thickness
Eric J. Smith
@ejsmith
Feb 24 2016 21:30 UTC
what the heck kind of crap is that?
3 options??
here is with the text above
Eric J. Smith
@ejsmith
Feb 24 2016 21:32 UTC
Ugh, we are not on the same page here… I wanted the text that says “You are currently on the…” on top f the chart.
the warning text on the bottom of the chart
Bill Henning
@BillHenning
Feb 24 2016 21:32 UTC
my thoughts were graph, then you are currently, then warning
Blake Niemyjski
@niemyjski
Feb 24 2016 21:32 UTC
you realize it takes like 5 minutes for my images to post
my image is still uploading
Screen Shot 2016-02-24 at 3.31.46 PM.png
Eric J. Smith
@ejsmith
Feb 24 2016 21:33 UTC
yes
I like that.
Blake Niemyjski
@niemyjski
Feb 24 2016 21:33 UTC
well the current plan para might look fine if swapped with the italics part
what do you mean by that
Eric J. Smith
@ejsmith
Feb 24 2016 21:33 UTC
the last image
it looks good like that.
Blake Niemyjski
@niemyjski
Feb 24 2016 21:34 UTC
I fixed the text to say usage data above
Bill Henning
@BillHenning
Feb 24 2016 21:34 UTC
i still sort of like graph, then current plan, then warning best it hink
because it uses the graph to break things up visually a bit better
but as you have it now is fine
Eric J. Smith
@ejsmith
Feb 24 2016 21:34 UTC
I don’t I think there needs to be something up there to break it up.
Blake Niemyjski
@niemyjski
Feb 24 2016 21:34 UTC
committing it
lol
Eric J. Smith
@ejsmith
Feb 24 2016 21:34 UTC
I wish there was a little more spacing between the org textbox and monthly usage heading.
but its fine
Bill Henning
@BillHenning
Feb 24 2016 21:35 UTC
yeah that would help too
Blake Niemyjski
@niemyjski
Feb 24 2016 21:35 UTC
I could add some
Eric J. Smith
@ejsmith
Feb 24 2016 21:35 UTC
go for it. :-)
maybe 10-20px
this is a HUGE help to people
Blake Niemyjski
@niemyjski
Feb 24 2016 21:39 UTC
looks good with 20 px
pushing
Eric J. Smith
@ejsmith
Feb 24 2016 21:40 UTC
ok
good work
Blake Niemyjski
@niemyjski
Feb 24 2016 21:40 UTC
probably need to create a work item for cleaning up old usages
currently none of those are being cleared out
so we have years of usage data
Eric J. Smith
@ejsmith
Feb 24 2016 21:40 UTC
did you limit the number of data points we are using?
Blake Niemyjski
@niemyjski
Feb 24 2016 21:40 UTC
no
Eric J. Smith
@ejsmith
Feb 24 2016 21:40 UTC
ugh
Blake Niemyjski
@niemyjski
Feb 24 2016 21:40 UTC
as I feel that should be a server side setting
Eric J. Smith
@ejsmith
Feb 24 2016 21:40 UTC
why not just limit it to the last 12 months?
.Take(12)
Blake Niemyjski
@niemyjski
Feb 24 2016 21:41 UTC
can we do that server side when usages are updated?
Eric J. Smith
@ejsmith
Feb 24 2016 21:41 UTC
done
Blake Niemyjski
@niemyjski
Feb 24 2016 21:41 UTC
not so easy in js
Eric J. Smith
@ejsmith
Feb 24 2016 21:41 UTC
doesn’t need to be in JS
change the model that is returned.
Blake Niemyjski
@niemyjski
Feb 24 2016 21:41 UTC
want me to clean up old ones or leave all of them and do a take 12 on the controller
Eric J. Smith
@ejsmith
Feb 24 2016 21:42 UTC
I see no problem leaving all of them in there.
they are small enough that I don’t care.
I just think we don’t need to go back far in time for the users view.
the more data points, the harder to see the current one.
Blake Niemyjski
@niemyjski
Feb 24 2016 21:43 UTC
ok
Eric J. Smith
@ejsmith
Feb 24 2016 21:43 UTC
which is probably the only one I care about
Blake Niemyjski
@niemyjski
Feb 24 2016 21:43 UTC
I’ll update the server
:)
Eric J. Smith
@ejsmith
Feb 24 2016 21:43 UTC
ok, thank you.
Blake Niemyjski
@niemyjski
Feb 24 2016 21:44 UTC
I think the last 6 months is fine
Eric J. Smith
@ejsmith
Feb 24 2016 21:44 UTC
probably is
Blake Niemyjski
@niemyjski
Feb 24 2016 21:44 UTC
but in this case a year is much better
hmm
Bill Henning
@BillHenning
Feb 24 2016 21:44 UTC
i'd keep a year
then you can see a trend
for certain months
Blake Niemyjski
@niemyjski
Feb 24 2016 21:46 UTC
Screen Shot 2016-02-24 at 3.44.22 PM.png
Bill Henning
@BillHenning
Feb 24 2016 21:46 UTC
still says "following usage data" which is wrong
Eric J. Smith
@ejsmith
Feb 24 2016 21:47 UTC
Should say “The usage data above is refreshed…"
Blake Niemyjski
@niemyjski
Feb 24 2016 21:50 UTC
building
Eric J. Smith
@ejsmith
Feb 24 2016 21:51 UTC
yep, long time coming.
Bill Henning
@BillHenning
Feb 24 2016 21:52 UTC
think this means that UWP will become UP (Universal Platform) and somehow start working on iOS/Android?
(eventually)
Jamie Clarke
@jamie94bc
Feb 24 2016 21:52 UTC
i wouldn't expect any instantaneous changes
or even within a year
Bill Henning
@BillHenning
Feb 24 2016 21:53 UTC
agree, but i wonder if that's where it's headed long term
Jamie Clarke
@jamie94bc
Feb 24 2016 21:54 UTC
i wouldn't be surprised, but even without that the fit makes sense
Blake Niemyjski
@niemyjski
Feb 24 2016 21:57 UTC
            DateTime usageRetention = DateTime.UtcNow.SubtractYears(1).StartOfMonth();
            viewOrganization.Usage = viewOrganization.Usage.Where(u => u.Date > usageRetention).ToList();
            viewOrganization.OverageHours = viewOrganization.OverageHours.Where(u => u.Date > usageRetention).ToList();
i wish .net was verbose on date comparison
because you have to always really think about < > when it comes to dates
should build IsBefore and IsAfter into our date time extensions
by the way those changes are live
eek, those changes look like poop if your on an unlimited plan
Eric J. Smith
@ejsmith
Feb 24 2016 22:01 UTC
well, I think we are the only ones on an unlimited plan. :-)
Blake Niemyjski
@niemyjski
Feb 24 2016 22:02 UTC
yeah
Jamie Clarke
@jamie94bc
Feb 24 2016 22:05 UTC
ever tried nodatime?
Eric J. Smith
@ejsmith
Feb 24 2016 22:07 UTC
no, but have looked at it briefly
looked pretty interesting
Jamie Clarke
@jamie94bc
Feb 24 2016 22:08 UTC
yeah i keep looking at it but haven't ended up using it yet
my biggest gripe with datetime is that timespan is used to represent a time
Eric J. Smith
@ejsmith
Feb 24 2016 22:10 UTC
I’m about to punch these tests in the face.
:-(
build passed like 4 times in the branch
Blake Niemyjski
@niemyjski
Feb 24 2016 22:19 UTC
:(
our charts need to get better with date ranges
we like cut off and show only the first result
but we should be padding the start or end so you don’t see the result on the far side
kinda drives me nuts
Blake Niemyjski
@niemyjski
Feb 24 2016 22:29 UTC
okay
on to testing stuff and deploying releases