These are chat archives for exceptionless/Discuss

26th
Feb 2016
Blake Niemyjski
@niemyjski
Feb 26 2016 13:23
@frankebersoll could we check the argument length on the ordering for title
and signature data
guess this is easier
Blake Niemyjski
@niemyjski
Feb 26 2016 13:30
@frankebersoll just upgraded us to typescript 1.8
TsProject] Building Project with: src/tsconfig.json
[TsProject] TypeScript compiler version: 1.8.2
[TsProject] Compiling project files...
[TsProject] Building bundle: src/exceptionless
[07:30:24] 'typescript' errored after 1.71 s
[07:30:24] TypeError: Cannot read property 'kind' of undefined
at Object.g (/Users/blake/Code/Exceptionless.JavaScript/node_modules/tsproject/tsproject.min.js:1:1989)
at /Users/blake/Code/Exceptionless.JavaScript/node_modules/tsproject/tsproject.min.js:1:10437
looks like I need to file a bug
Blake Niemyjski
@niemyjski
Feb 26 2016 13:52
thanks :)
@frankebersoll: does this look right to you
exceptionless/Exceptionless.JavaScript@0dc52f7 ran build and look at submit sync
it’s changed quite a bit
bit scared about that unless that’s to be expected
not sure what node changes you’ve made recently
Blake Niemyjski
@niemyjski
Feb 26 2016 13:58
ran it 3 more times and it fixed it
some kind of race condition
I’m going to do a round of testing and release it
Strip-Log-nonstandard-650-fianlenglish-1.jpg
Blake Niemyjski
@niemyjski
Feb 26 2016 14:30
haha
@ejsmith seems like azure had issues this morning
2 nodes went down and came back
over a period of 5 minutes
must of had updates and rebooted the avalibility set?
Eric J. Smith
@ejsmith
Feb 26 2016 14:35
Hahaha
I like that comic
Blake Niemyjski
@niemyjski
Feb 26 2016 15:46
haha
that song you are the only exception just came on the radio anymore
again*
pretty funny I seem to be debugging something every time that plays once a week
ole pandora might be watching me
shout :D
good work guys
Blake Niemyjski
@niemyjski
Feb 26 2016 17:17
@frankebersoll I was thinking would we ever want a flag on config (get only) that sees if offline storage is enabled?
I mean you might want to do things differently in offline or should we never special case any behavior
nice little change
much cleaner
so simple
Blake Niemyjski
@niemyjski
Feb 26 2016 19:23
yeah
good job
Frank Ebersoll
@frankebersoll
Feb 26 2016 19:47
Hey :-)
Eric J. Smith
@ejsmith
Feb 26 2016 19:47
hey
Frank Ebersoll
@frankebersoll
Feb 26 2016 19:47
It’s release day!
Eric J. Smith
@ejsmith
Feb 26 2016 19:47
yay!
Frank Ebersoll
@frankebersoll
Feb 26 2016 19:47
there were some questions today, let me check
Blake Niemyjski
@niemyjski
Feb 26 2016 19:48
ok
Frank Ebersoll
@frankebersoll
Feb 26 2016 19:53
@niemyjski about method overloading: I don’t know what is best practice in javascript, but i would be confused if the optional parameter was the first
and the implementation is much easier like that
Blake Niemyjski
@niemyjski
Feb 26 2016 19:55
yeah
I agree
Frank Ebersoll
@frankebersoll
Feb 26 2016 19:56
actually, i would expect it to be that way around in .net, too
Blake Niemyjski
@niemyjski
Feb 26 2016 19:56
typescript 1.x made a bit easier
you can do union types
and then just check the argument length
Frank Ebersoll
@frankebersoll
Feb 26 2016 19:56
ah? okay
Blake Niemyjski
@niemyjski
Feb 26 2016 19:56
numberOrString:number|string, secondparam
then if you check the type it infers it
btw more work than needed
Frank Ebersoll
@frankebersoll
Feb 26 2016 19:57
yes, but what would the actual names be?
Blake Niemyjski
@niemyjski
Feb 26 2016 19:57
crappy
Frank Ebersoll
@frankebersoll
Feb 26 2016 19:57
titleOrSignature, title
Blake Niemyjski
@niemyjski
Feb 26 2016 19:57
yep
Frank Ebersoll
@frankebersoll
Feb 26 2016 19:57
i don’t know what that would mean at all
Blake Niemyjski
@niemyjski
Feb 26 2016 19:59
yeah
what you have is less confusing that is for sure
I’m fine with it
Frank Ebersoll
@frankebersoll
Feb 26 2016 19:59
okay. about TS 1.8, you mean that was a bug in tsproject?
uh. that submitSync problem frightens me. i hoped we could just hit „build“ and trust that it works
Frank Ebersoll
@frankebersoll
Feb 26 2016 20:09
and that local storage question: i think we might need that some time, but we could just make it then. do we need it in .net?
Blake Niemyjski
@niemyjski
Feb 26 2016 20:10
yeah
I logged a bug and he said he was going to fix it asap
yeah
can you reproduce what I was seeing
nope, nothing’s special cased
kiss and write it if we ever need it
I had a good example of when I might need it but then I forgot lol
Frank Ebersoll
@frankebersoll
Feb 26 2016 20:11
i haven’t seen any problems with the build. but i wanted to try out its new minfication features anyway
i still think we have lots of potential regarding build.
Blake Niemyjski
@niemyjski
Feb 26 2016 20:28
yeah
it could be faster and better (incremental)
I need to go to the store and get some coffee creamer
about to fall asleep
Frank Ebersoll
@frankebersoll
Feb 26 2016 20:29
i already was. i will go to bed now.
Blake Niemyjski
@niemyjski
Feb 26 2016 20:30
haha
have a good night :)
Frank Ebersoll
@frankebersoll
Feb 26 2016 20:30
good night
Eric J. Smith
@ejsmith
Feb 26 2016 20:56
this .net benchmarks lib is driving me nuts.
Blake Niemyjski
@niemyjski
Feb 26 2016 21:27
why
lol
Blake Niemyjski
@niemyjski
Feb 26 2016 21:50
@ejsmith just a little clean up :) exceptionless/Exceptionless@89ec8d8
all tests passed on first try.. we were doing extra work in existing calls for terms that were never being used as well and we had timelines being returned for stacks which we were doing nothing with so I removed it for now so all our payloads will be much smaller.
:)
heres all the changes required to update all existing ui elements to use the new end points:
exceptionless/Exceptionless.UI@37f0cb5
oh and I compared old calls with new calls side by side in dashboards
all had the exact same data and charts :)
Blake Niemyjski
@niemyjski
Feb 26 2016 21:56
did break the stats api controller
but I highly doubt anyone would be calling it
besides our dashboards and the new way is way more flexible and allows us to generic stats on any field (if allowed) and we are one massive step closer to generic dashboards :D
dev-app is pointing to my chart branches if you want to take a look