These are chat archives for exceptionless/Discuss

11th
Mar 2016
Sharath Satish
@sharathsatish
Mar 11 2016 17:59
I have submitted a pull request and it says I havent signed the CLA
even after I did, it doesn't seem to recognize that
Blake Niemyjski
@niemyjski
Mar 11 2016 17:59
hmm,
you clicked on the cla details and went to: https://cla-assistant.io/exceptionless/Exceptionless?pullRequest=201
Sharath Satish
@sharathsatish
Mar 11 2016 18:00
yes
twice now :(
Blake Niemyjski
@niemyjski
Mar 11 2016 18:00
@sharathsatish with the new xproject system we shouldn’t need to have the csproject anymore. any reason for keeping this?
maybe there bot is backed up
Sharath Satish
@sharathsatish
Mar 11 2016 18:01
its not at xproj yet
that will be my next push
Blake Niemyjski
@niemyjski
Mar 11 2016 18:01
ok
Sharath Satish
@sharathsatish
Mar 11 2016 18:01
this is just abt moving csproj itself to project.json
i am still working on moving it xproj
Blake Niemyjski
@niemyjski
Mar 11 2016 18:02
I thought all you needed was a project.json file
ok
Sharath Satish
@sharathsatish
Mar 11 2016 18:02
no sadly not
Blake Niemyjski
@niemyjski
Mar 11 2016 18:03
I’m really wondering how the post build events we have will work in the new format
Sharath Satish
@sharathsatish
Mar 11 2016 18:04
because right now they are zipped?
vs pushed as a nuget?
Blake Niemyjski
@niemyjski
Mar 11 2016 18:04
what do you mean?
Sharath Satish
@sharathsatish
Mar 11 2016 18:04
the post build events like artifacts
is that what u mean?
Blake Niemyjski
@niemyjski
Mar 11 2016 18:04
yeah
I’m still new to the converting process as well.
I talked with an hour last night with the .net core team about converting foundatio
Sharath Satish
@sharathsatish
Mar 11 2016 18:05
will try it out and see, when we specify create build output
it should create a bin folder with everything required right?
Blake Niemyjski
@niemyjski
Mar 11 2016 18:06
took us three hours and we kind of gave up. stuffs changing too rapidly at an rc state
Sharath Satish
@sharathsatish
Mar 11 2016 18:06
the thing I am concerned abt is all the cshtmls that are there in core
oh wow ok
Eric J. Smith
@ejsmith
Mar 11 2016 18:06
Should be able to embed resources still.
Sharath Satish
@sharathsatish
Mar 11 2016 18:07
ya just need to work out how to specify that :D
Eric J. Smith
@ejsmith
Mar 11 2016 18:07
And project.json has a post build step if we need it.
Sharath Satish
@sharathsatish
Mar 11 2016 18:07
hopefully VS props still work
Eric J. Smith
@ejsmith
Mar 11 2016 18:07
My concern is that they seem to be changing a lot of stuff for RC2
Blake Niemyjski
@niemyjski
Mar 11 2016 18:07
well would be nice if we could get rid of all of that :)
Sharath Satish
@sharathsatish
Mar 11 2016 18:08
well project.json is unrelated
so we can wait till RC2 is out on the move to mvc.core
if there are a lot of changes headed into the release
project.json just gives all the nuget3.0 good stuff
Blake Niemyjski
@niemyjski
Mar 11 2016 18:09
betting rc2 will be out before or slightly after build (prays)
yeah
Sharath Satish
@sharathsatish
Mar 11 2016 18:09
haha i hope so too
well i hope the cla bot clears out soon
Blake Niemyjski
@niemyjski
Mar 11 2016 18:09
if not, I’ll file a bug with them
we’ll let this bake and get solid before merging in
Sharath Satish
@sharathsatish
Mar 11 2016 18:10
cool thanks, I am guessing u can't merge till that check clears at the very least
the issue with keeping the project.json change out too long is adding/changing nuget dependencies will mean a manual merge to project.json
and csproj files
Blake Niemyjski
@niemyjski
Mar 11 2016 18:14
Yeah I'm not sure the best way to keep those in sync
I'll try pulling down your branch today and take a look
Sharath Satish
@sharathsatish
Mar 11 2016 18:15
my fork u mean?
Blake Niemyjski
@niemyjski
Mar 11 2016 18:15
Yep
So I guess step one is doing just the nuget chabge
I thought project.json was a project system
Sharath Satish
@sharathsatish
Mar 11 2016 18:15
ya that was why i raised a pull request just for that one isolated change
no its not
thats a little diff, this just replaces packages.config and the way external references are added to projects
its quite harmless
but it is step 1 to moving
Blake Niemyjski
@niemyjski
Mar 11 2016 18:17
Do you have any docs on using it just for nuget 3.0. I think it would be pretty easy to target project.json /project only and target full framework
Sharath Satish
@sharathsatish
Mar 11 2016 18:17
helps make the move to xproj easier
Blake Niemyjski
@niemyjski
Mar 11 2016 18:18
Thanks for the link I'll take a look after lunch
Sharath Satish
@sharathsatish
Mar 11 2016 18:18
cool, i'll sign off for tonight
drop a note here if u have any questions
Blake Niemyjski
@niemyjski
Mar 11 2016 18:19
Should we be able to convert to xproj easily while targeting old full framework? I think the only problem would be when we want to specifically target new frameworks (core clr)
Sharath Satish
@sharathsatish
Mar 11 2016 18:19
yes we can do that
Blake Niemyjski
@niemyjski
Mar 11 2016 18:19
Let's do that
Sharath Satish
@sharathsatish
Mar 11 2016 18:19
i tried it locally for a project
i am going to raise a pull request for that next
in a few days
no changes at all expect moving to xproj
rather than csproj
Blake Niemyjski
@niemyjski
Mar 11 2016 18:20
can we do al of that in a single pull request? Id rather do all the testing in one hit
Sharath Satish
@sharathsatish
Mar 11 2016 18:20
yes
Blake Niemyjski
@niemyjski
Mar 11 2016 18:20
I can help as well
Sharath Satish
@sharathsatish
Mar 11 2016 18:20
will raise all the Exceptionless projects in one pull request
Blake Niemyjski
@niemyjski
Mar 11 2016 18:20
Yeah that will be nice :)
Sharath Satish
@sharathsatish
Mar 11 2016 18:21
it shouldn't take too long hopefully, will reach out if I get stuck
i have some time sketched out for this over the weekend
Blake Niemyjski
@niemyjski
Mar 11 2016 18:21
Thanks I really appreciate it and I'll be around this weekend as well
Sharath Satish
@sharathsatish
Mar 11 2016 18:21
once this is stable can tackle the .net clients repo
Blake Niemyjski
@niemyjski
Mar 11 2016 18:21
Just send a message in here :)
Sharath Satish
@sharathsatish
Mar 11 2016 18:21
for the same 2 changes
once RC2 is out can figure out the move to support core
Blake Niemyjski
@niemyjski
Mar 11 2016 18:22
Yeah that would be awesome and a huge huge help
Sharath Satish
@sharathsatish
Mar 11 2016 18:22
happy to help!
Blake Niemyjski
@niemyjski
Mar 11 2016 18:23
Once we get this converted I'll write a blog post and give you all the credit I think this is a great app to use as a how to upgrade to the new format
Sharath Satish
@sharathsatish
Mar 11 2016 18:24
Thanks!
Blake Niemyjski
@niemyjski
Mar 11 2016 18:25
I'll hold off updating any dependencies for the next few days so we shouldn't have to change any of them :)
They should really build the tooling to upgrade projects
Sharath Satish
@sharathsatish
Mar 11 2016 18:26
well i found this handy ps script that mostly gets these changes right
the link to it is at the bottom of that link i shared
just some minor changes to it
also i found why cla isnt getting checked
looks like my email address isnt set in the commit
cos of a config issue on my laptop
any idea how to edit the commit to include that now?
Blake Niemyjski
@niemyjski
Mar 11 2016 18:29
Not sure could just amend a commit and see if it gets picked up
Or create a new pull request and then sign it and then close ig
Sharath Satish
@sharathsatish
Mar 11 2016 18:30
can I amend a commit that is pushed?
Blake Niemyjski
@niemyjski
Mar 11 2016 18:30
They are all linked
Yeah anything pushed to your fork / branch will update the pull request
Sharath Satish
@sharathsatish
Mar 11 2016 18:32
it now says one out of 2 commiters has signed
is that good enough?
and I had to make a whitespace change to push a new commit :|
Blake Niemyjski
@niemyjski
Mar 11 2016 18:39
Yup :)
Sharath Satish
@sharathsatish
Mar 11 2016 18:41
cool
well from next time shouldn't have these issues :D
Eric J. Smith
@ejsmith
Mar 11 2016 18:53
@sharathsatish checking out your website and it looks great! Read a couple of your blog posts.
Sharath Satish
@sharathsatish
Mar 11 2016 18:54
Thanks!