These are chat archives for exceptionless/Discuss

17th
Mar 2016
Sharath Satish
@sharathsatish
Mar 17 2016 00:03
@niemyjski my laptop charger died :-(. New one arrives today. So will be able to do more over the next few days.
Blake Niemyjski
@niemyjski
Mar 17 2016 02:04
Sounds good, that's never any fun
Yes setting a log path should turn logging on
Bill Henning
@BillHenning
Mar 17 2016 10:56
The dev site looks good but i'd suggest dimming out the gray bg more of the new search bar... either have it be transparent or mostly black. There's no need for it to stick out so much.
Blake Niemyjski
@niemyjski
Mar 17 2016 14:09
yeah
we got lots of themeing work
I’m going to work on search validation and experience this morning
w00t
new version of webstorm!!
seems like an awesome update
lots of improvements
Blake Niemyjski
@niemyjski
Mar 17 2016 15:03
fans going crazy tho
lol
Eric J. Smith
@ejsmith
Mar 17 2016 15:04
looking at the header bar...
the html looks a big jacked up, but hopefully I will be able to fix it without breaking it.
@BillHenning I think I like it being a different color.
I think some attention does need to be drawn to it.
it’s greatly controlling what you are viewing.
Bill Henning
@BillHenning
Mar 17 2016 15:06
Personally I just think it's too much right now.
Eric J. Smith
@ejsmith
Mar 17 2016 15:07
can tweak it, but I think attention needs to be drawn to it, don’t you think?
Bill Henning
@BillHenning
Mar 17 2016 15:08
The search box itself is very bright, maybe if that alone was darkened, it would look better.
what if you even went black bg with the search textbox and some med gray "Search" text on it
Blake Niemyjski
@niemyjski
Mar 17 2016 15:09
yeah maybe
Eric J. Smith
@ejsmith
Mar 17 2016 15:10
yeah, I’m experimenting.
Blake Niemyjski
@niemyjski
Mar 17 2016 15:10
the html looks a big jacked up, but hopefully I will be able to fix it without breaking it. ??
Eric J. Smith
@ejsmith
Mar 17 2016 15:27
Screen Shot 2016-03-17 at 10.26.30 AM.png
Bill Henning
@BillHenning
Mar 17 2016 15:28
i like that better... wonder if you could even go darker than #2b2b2b on the textbox part
Eric J. Smith
@ejsmith
Mar 17 2016 15:28
darker than the header?
Bill Henning
@BillHenning
Mar 17 2016 15:28
yeah slightly
Blake Niemyjski
@niemyjski
Mar 17 2016 15:28
that might look odd
Bill Henning
@BillHenning
Mar 17 2016 15:28
that would indicate that it needs some interaction
Blake Niemyjski
@niemyjski
Mar 17 2016 15:28
you know you’ve been doing web too long when you know the hex color codes lol
Eric J. Smith
@ejsmith
Mar 17 2016 15:29
makes it look glossy or something.
Screen Shot 2016-03-17 at 10.29.19 AM.png
Blake Niemyjski
@niemyjski
Mar 17 2016 15:31
doesn’t look that bad
Eric J. Smith
@ejsmith
Mar 17 2016 15:31
I don’t like it.
Blake Niemyjski
@niemyjski
Mar 17 2016 15:31
Think I like it more
Bill Henning
@BillHenning
Mar 17 2016 15:31
you'd need to dim the "Search" text a tad too
right now it sticks out since the bg was darkened
i like it because the contrast with the main header bg tells me as a user to do something there
Blake Niemyjski
@niemyjski
Mar 17 2016 15:32
and we’d lighten it when focused?
Bill Henning
@BillHenning
Mar 17 2016 15:33
not sure you need to but you could
Blake Niemyjski
@niemyjski
Mar 17 2016 15:33
@BillHenning what do you think about turning that box red on a search validation error
Bill Henning
@BillHenning
Mar 17 2016 15:35
could you just do the border instead of the bg?
Blake Niemyjski
@niemyjski
Mar 17 2016 15:36
yeah
wanted feedback on that
since there no longer a place to show a message we need to show a toast, show some kind of feedback on the search box and focus it
Welcome @jmoeltjen to gitter. Hes our marketing consultant (blog posts, social etc) / feedback of all the things :)
Blake Niemyjski
@niemyjski
Mar 17 2016 15:42
@jmoeltjen just noticed that the github images look a bit pixelated.. must have been out of it yesterday.. are you seeing this as well?
It’s just the white backgrounds
@BillHenning do you even care if there is a search validation error
your just not going to get any search results..
might be kind of nice if we tell you tho
Bill Henning
@BillHenning
Mar 17 2016 15:48
you mean if i typed like "foo: bar" and foo isn't a recognized search thing?
Blake Niemyjski
@niemyjski
Mar 17 2016 15:48
but we’ll only tell you it’s invalid just not what part is invalid
yeah
we’ll just say it’s invalid
Bill Henning
@BillHenning
Mar 17 2016 15:48
might be helpful to know it bombed and i should click the ?
Blake Niemyjski
@niemyjski
Mar 17 2016 15:48
yeah
trying to figure this out now hehe
Blake Niemyjski
@niemyjski
Mar 17 2016 16:27
@BillHenning you like this
Screen Shot 2016-03-17 at 11.27.09 AM.png
it goes away after a period of time and if you hover or click on it
the tooltip shows back up
kind of unobtrusive
Bill Henning
@BillHenning
Mar 17 2016 16:29
hmm maybe the bg should be tinted red on the textbox
just slightly
and perhaps the tooltip should be more in your face instead of blending
Blake Niemyjski
@niemyjski
Mar 17 2016 16:29
yeah
like red
?
lol
Bill Henning
@BillHenning
Mar 17 2016 16:32
probably
Blake Niemyjski
@niemyjski
Mar 17 2016 16:40
seems like everyone is doing black
just looked at a bunch of samples
none are applying colors
doens’t mean we can’t..
time for lunch :)
Blake Niemyjski
@niemyjski
Mar 17 2016 18:58
Screen Shot 2016-03-17 at 1.57.49 PM.png
Blake Niemyjski
@niemyjski
Mar 17 2016 20:40
@ejsmith I noticed our filter validator validates dang near anything
but es might through an error with it
when that happens our controllers log it and through a 400 bad request with the message
return BadRequest("An error has occurred. Please check your search filter.");
do we want to do this still
or just return empty results
Eric J. Smith
@ejsmith
Mar 17 2016 20:41
I’m sure it would probably be damn near impossible to handle everything.
yes, we want them to know the search filter didn’t work.
Blake Niemyjski
@niemyjski
Mar 17 2016 20:41
seems like if we get an error it might be nice to just return empty array / stats result
ok
had like 1500 errors listed in my console due to badrequest
Blake Niemyjski
@niemyjski
Mar 17 2016 20:49
guess I need to update queryprocessor to have default fields
@ejsmith is there any reason for not running the generatequeryvistor overtime?
        string expandedQuery = validator.UsesDataFields ? GenerateQueryVisitor.Run(result) : query;
I know it’s less work but the queries sent to elastic would be uniformed
blah : \t \t\ t\t\t blah would become blah:blah
Eric J. Smith
@ejsmith
Mar 17 2016 21:06
yeah, worried about relying on that to be full fidelity/
I think it handles everything, but not 100% sure.
Blake Niemyjski
@niemyjski
Mar 17 2016 21:07
yeah
I’m looking into the best way to include these fields
either write a visitor to check to see if the field has been set
or just do a contains
I need to make sure that the query generator trims
hmm
doesn’t seem to be
question is should it
"data.age : [10 TO ]” isn’t translated to "idx.age-n:[10 TO ]”
Blake Niemyjski
@niemyjski
Mar 17 2016 21:13
whelp this may be a bug with our query parser
adding whitespace doesn’t translate it the same way
Eric J. Smith
@ejsmith
Mar 17 2016 21:14
that isn’t valid though
Blake Niemyjski
@niemyjski
Mar 17 2016 21:14
adding tabs and spaces?
between the :
that’s a valid query… gitter just changed it in here
added 4 spaces and 2 tabs around the :
hmm
seems that the term node isn’t created correctly then there are spaces / tabs involved
will pull down the project and take a look
Eric J. Smith
@ejsmith
Mar 17 2016 21:17
I am not sure if that is valid either.
Blake Niemyjski
@niemyjski
Mar 17 2016 21:17
well it'
it’s passing our validator
should see if there is a spec for this that I can check
makes me wonder if we should just run that
if our local query validator runs
Eric J. Smith
@ejsmith
Mar 17 2016 22:49
Maybe
Actually no. We are only allowing query string format
That parsers an entire query.
Blake Niemyjski
@niemyjski
Mar 17 2016 23:05
dam
was hoping to see if elastic didn’t take those queries but it does
so our dam grammer needs fixing