These are chat archives for exceptionless/Discuss

6th
Apr 2016
Blake Niemyjski
@niemyjski
Apr 06 2016 02:46
It. Oils be the issue
It could be* I'm all for simplifying it
I'll pull down that branch abs take a look
Blake Niemyjski
@niemyjski
Apr 06 2016 14:09
@frankebersoll so should the root folder of the project now be the repo instead of the src folder in vscode?
I’ve been thinking more about what eric had posted and what if we got rid of gulp all together and just had npm tasks
idk
seems so simple and less depedencies
Eric J. Smith
@ejsmith
Apr 06 2016 14:17
well the typescript project I was showing is using webpack to do stuff
Blake Niemyjski
@niemyjski
Apr 06 2016 14:17
oh yeah
Eric J. Smith
@ejsmith
Apr 06 2016 14:17
webpack is replacing gulp
but that doesn’t really make sense for building a library
yeah
Eric J. Smith
@ejsmith
Apr 06 2016 14:22
what the heck is all that?
why do we need to sign our commits?
I’m trying to simplify things.
not add complexity
Blake Niemyjski
@niemyjski
Apr 06 2016 14:23
new feature of github
kinda cool
:)
Frank Ebersoll
@frankebersoll
Apr 06 2016 14:24
@niemyjski about root: did you ask because of the typings folder and tsproject files?
Blake Niemyjski
@niemyjski
Apr 06 2016 14:24
yeah
Frank Ebersoll
@frankebersoll
Apr 06 2016 14:24
the new typings.json doesnt support a path property yet. there is an open issue for that
Blake Niemyjski
@niemyjski
Apr 06 2016 14:24
ok
Frank Ebersoll
@frankebersoll
Apr 06 2016 14:24
as soon as it does, we can move things into src again
Blake Niemyjski
@niemyjski
Apr 06 2016 14:24
so all I should need to do now is npm install
and it does everything
Frank Ebersoll
@frankebersoll
Apr 06 2016 14:25
it should
Blake Niemyjski
@niemyjski
Apr 06 2016 14:25
cool
trying out the branch now :)
Frank Ebersoll
@frankebersoll
Apr 06 2016 14:25
you need to npm install typings -g beforehand
Blake Niemyjski
@niemyjski
Apr 06 2016 14:25
yep
already did that
I wasn’t aware that they got rid of tsd in favor of typings
[TsProject] /Users/blake/Code/Exceptionless.JavaScript/src/services/DefaultErrorParser.ts(20,42): error TS2503: Cannot find namespace 'TraceKit'.
[TsProject] /Users/blake/Code/Exceptionless.JavaScript/src/services/DefaultErrorParser.ts(40,21): error TS2503: Cannot find namespace 'TraceKit'.
[TsProject] /Users/blake/Code/Exceptionless.JavaScript/src/services/DefaultErrorParser.ts(42,9): error TS2304: Cannot find name 'TraceKit'.
[TsProject] src/exceptionless.ts(27,48): error TS2503: Cannot find namespace 'TraceKit'.
[TsProject] src/exceptionless.ts(69,1): error TS2304: Cannot find name 'TraceKit'.
[TsProject] src/exceptionless.ts(70,1): error TS2304: Cannot find name 'TraceKit'.
Frank Ebersoll
@frankebersoll
Apr 06 2016 14:26
uh. i forgot to check that in :-(
Blake Niemyjski
@niemyjski
Apr 06 2016 14:27
ehe
Frank Ebersoll
@frankebersoll
Apr 06 2016 14:27
but that should be resolved by the new tracekit reference
Blake Niemyjski
@niemyjski
Apr 06 2016 14:27
roject] Compiling project files...
[TsProject] /Users/blake/Code/Exceptionless.JavaScript/src/services/DefaultErrorParser.ts(20,42): error TS2503: Cannot find namespace 'TraceKit'.
[TsProject] /Users/blake/Code/Exceptionless.JavaScript/src/services/DefaultErrorParser.ts(40,21): error TS2503: Cannot find namespace 'TraceKit'.
[TsProject] /Users/blake/Code/Exceptionless.JavaScript/src/services/DefaultErrorParser.ts(42,9): error TS2304: Cannot find name 'TraceKit'.
[TsProject] src/exceptionless.ts(27,48): error TS2503: Cannot find namespace 'TraceKit'.
[TsProject] src/exceptionless.ts(69,1): error TS2304: Cannot find name 'TraceKit'.
[TsProject] src/exceptionless.ts(70,1): error TS2304: Cannot find name 'TraceKit'.
[TsProject] Build completed with errors. Outputs generated.
[09:26:16] Finished 'typescript.integrations' after 1.53 s
[09:26:16] Starting 'exceptionless.umd'...
[09:26:16] Finished 'exceptionless.umd' after 41 ms
[09:26:16] Starting 'exceptionless'...
[09:26:16] Finished 'exceptionless' after 282 ms
[09:26:16] Starting 'build'...
[09:26:16] Finished 'build' after 2.53 μs
how can a failing build still finish
shouldn’t it stop everything
Frank Ebersoll
@frankebersoll
Apr 06 2016 14:27
gulp.
Blake Niemyjski
@niemyjski
Apr 06 2016 14:27
hehe
i like how you said that
Frank Ebersoll
@frankebersoll
Apr 06 2016 14:28
i guess there are concepts for that.
Blake Niemyjski
@niemyjski
Apr 06 2016 14:28
let me know when I should get latest
Matt Oswald
@moswald
Apr 06 2016 18:40
quick question - I've run the AzureServiceBusQueueTests unit tests, and a good chunk of them fail
it's talking to my personal service bus namespace, and several pass so I know it's at least partially working
should I expect them all to pass? (this is without any changes to address #25 and #36)
Eric J. Smith
@ejsmith
Apr 06 2016 18:45
What errors are you seeing?
We have had some flakey tests here and there.
Matt Oswald
@moswald
Apr 06 2016 18:47
CanAbandonQueueEntryOnce always fails on QueueTestBase.cs line 631
the second call to AbandonAsync
Eric J. Smith
@ejsmith
Apr 06 2016 18:47
Do all the other tests pass?
Matt Oswald
@moswald
Apr 06 2016 18:48
no - hang on, rerunning them
usually only 7 or so pass
Eric J. Smith
@ejsmith
Apr 06 2016 18:48
Like the non-servicebus ones?
Matt Oswald
@moswald
Apr 06 2016 18:48
I'm only running the servicebus ones for now
Matt Oswald
@moswald
Apr 06 2016 19:06
I see the appveyor build shows 14 of 15 passing, so I must have something configured incorrectly
I'll keep poking at it
Eric J. Smith
@ejsmith
Apr 06 2016 19:18
ok, if you post the error message, maybe we can help
Frank Ebersoll
@frankebersoll
Apr 06 2016 19:20
@niemyjski I made another pull request for tracekit: this time, i tested it by making the changes locally in the tracekit.d.ts and it worked
Matt Oswald
@moswald
Apr 06 2016 19:26
I told xunit to only run a single test, just to avoid any concurrency issues:
xUnit.net Console Runner (32-bit .NET 4.0.30319.42000)
  Discovering: Foundatio.Azure.Tests (app domain = on [shadow copy], method display = ClassAndMethod)
  Discovered:  Foundatio.Azure.Tests (running 1 of 46 test case)
  Starting:    Foundatio.Azure.Tests (parallel test collections = off, max threads = 24)
    Foundatio.Azure.Tests.Queue.AzureServiceBusQueueTests.CanAbandonQueueEntryOnce
    Foundatio.Azure.Tests.Queue.AzureServiceBusQueueTests.CanAbandonQueueEntryOnce [FAIL]
      Assert.Throws() Failure
      Expected: typeof(System.Exception)
      Actual:   (No exception was thrown)
      Stack Trace:
        src\Core\Tests\Queue\QueueTestBase.cs(631,0): at Foundatio.Tests.Queue.QueueTestBase.<CanAbandonQueueEntryOnce>d__18.MoveNext()
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
        --- End of stack trace from previous location where exception was thrown ---
           at System.Runtime.CompilerServices.TaskAwaiter.ThrowForNonSuccess(Task task)
           at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
  Finished:    Foundatio.Azure.Tests
=== TEST EXECUTION SUMMARY ===
   Foundatio.Azure.Tests  Total: 1, Errors: 0, Failed: 1, Skipped: 0, Time: 7.674s
Eric J. Smith
@ejsmith
Apr 06 2016 19:46
hmm… this may be something we broke a couple weeks ago.
we actually aren’t running the servicebus tests with the build. We need to setup a test account for them to run against.
since you can’t emulate servicebus
and we can’t install it on the build box
we made it so that if you try to abandon an item multiple times, it should throw an exception
and it appears that the servicebus one isn’t doing that.
Matt Oswald
@moswald
Apr 06 2016 19:48
ok
Eric J. Smith
@ejsmith
Apr 06 2016 19:49
sorry about that.
Matt Oswald
@moswald
Apr 06 2016 19:49
no worries :)
Eric J. Smith
@ejsmith
Apr 06 2016 19:49
I’m guessing all the test failures are related to that.
Matt Oswald
@moswald
Apr 06 2016 19:50
I'll see if I can get the tests to pass, or Skip the ones that I'm not sure about
Eric J. Smith
@ejsmith
Apr 06 2016 19:50
ok
thanks for the help!
Matt Oswald
@moswald
Apr 06 2016 19:50
and I'll let you guys sort that out in my PR
np
Blake Niemyjski
@niemyjski
Apr 06 2016 20:25
@frankebersoll ok will take a look
@moswald thanks :)
Eric J. Smith
@ejsmith
Apr 06 2016 20:26
really need to get those tests running during build for S3 and ServiceBus
so many damn things to work on.
Matt Oswald
@moswald
Apr 06 2016 20:27
yeah, I hear ya. our team really needs a dedicated build engineer/devops guy, but instead we just share the load
Blake Niemyjski
@niemyjski
Apr 06 2016 20:29
yeah
should hook up appveyor to a test service bus instance I guess and pay the cost
Eric J. Smith
@ejsmith
Apr 06 2016 20:29
yeah
do you like ServiceBus @moswald ?
Matt Oswald
@moswald
Apr 06 2016 20:30
yeah, no real complaints
it's fast, and definitely scales to the level we require
Eric J. Smith
@ejsmith
Apr 06 2016 20:31
my only complaint is that it feels very heavy and complex.
I like simple things :-)
Eric J. Smith
@ejsmith
Apr 06 2016 21:03
@srijken just thought of something… when we dedupe the events, are we setting the date on the event to the max of the dates?
Sander Rijken
@srijken
Apr 06 2016 21:04
no
but the delta will be <= 60 seconds
Eric J. Smith
@ejsmith
Apr 06 2016 21:04
probably should be. If it dedupes something like a heartbeat then we would want the date to be the max date.
hopefully @niemyjski can get the server side piece of that done soon. Would love to get that deployed.
Blake Niemyjski
@niemyjski
Apr 06 2016 21:05
well
server side for indexing count is out there
so we can test it and push the .net client out
just won’t have the deduped count server side as the total
that would be a stats change
Eric J. Smith
@ejsmith
Apr 06 2016 21:06
yeah
Blake Niemyjski
@niemyjski
Apr 06 2016 21:40
dang, country legend just passed away on his birthday (merle haggard)
Frank Ebersoll
@frankebersoll
Apr 06 2016 22:09
@niemyjski thanks for merging the pull request, what needs to be done to get this to npm?
Blake Niemyjski
@niemyjski
Apr 06 2016 22:17
need to push a release
I can do that
Frank Ebersoll
@frankebersoll
Apr 06 2016 22:32
ah okay
Blake Niemyjski
@niemyjski
Apr 06 2016 22:34
pushed
Frank Ebersoll
@frankebersoll
Apr 06 2016 22:42
committed
At least the typescript part of the build should work now
All this should be prerequisites for tsproject to do successful minification
Blake Niemyjski
@niemyjski
Apr 06 2016 23:17
sweet :)
i guess the rest of it has a race condition?
Frank Ebersoll
@frankebersoll
Apr 06 2016 23:17
looks like it
Blake Niemyjski
@niemyjski
Apr 06 2016 23:17
when you have gulp tasks and you specify dependencies they are supposed to wait
Frank Ebersoll
@frankebersoll
Apr 06 2016 23:18
yes, but when you start multiple things inside of one gulp task, those will run in parallel
Blake Niemyjski
@niemyjski
Apr 06 2016 23:18
could add some logging to the build using chalk.js and see what’s going on
Frank Ebersoll
@frankebersoll
Apr 06 2016 23:18
and things can only be awaited if you return them
Blake Niemyjski
@niemyjski
Apr 06 2016 23:18
hmm
Frank Ebersoll
@frankebersoll
Apr 06 2016 23:18
just like Tasks in .net
Blake Niemyjski
@niemyjski
Apr 06 2016 23:18
yeah
brb dinner
Frank Ebersoll
@frankebersoll
Apr 06 2016 23:19
brb bed
nighty.