These are chat archives for exceptionless/Discuss

8th
Apr 2016
Eric J. Smith
@ejsmith
Apr 08 2016 05:05
@niemyjski I think the user count for the project isn’t taking the date filter into account. I think it’s using the total count of users for the project. Trying to think what makes sense. I think if you are looking at the last 7 days, then you want to see what percentage of users that visited in that timeframe got an error.
right now it’s showing you the percent of total users for the project over all time.
Blake Niemyjski
@niemyjski
Apr 08 2016 12:56
Yes it's what we decided
All time users within your retention
We want to cache user accounts
Eric J. Smith
@ejsmith
Apr 08 2016 12:57
Yeah, but looking at it. I don't think it's intuitive. And don't think it's what you want to see.
Blake Niemyjski
@niemyjski
Apr 08 2016 12:57
Well
Eric J. Smith
@ejsmith
Apr 08 2016 12:57
I am probably going to keep my filter at 7 days or something.
Blake Niemyjski
@niemyjski
Apr 08 2016 12:57
Yeah
Eric J. Smith
@ejsmith
Apr 08 2016 12:58
I want to see what percent of users were affected by an issue in that timeframe
Blake Niemyjski
@niemyjski
Apr 08 2016 12:58
Yeah
Eric J. Smith
@ejsmith
Apr 08 2016 12:58
I know it's more expensive, but I think it's what people want.
I'm trying to think if you would even want to see the total user count.
I don't think you would.
Bill Henning
@BillHenning
Apr 08 2016 12:59
Go with filtered date range.
Especially now that the date range, etc. is all front and center on the header.
Eric J. Smith
@ejsmith
Apr 08 2016 12:59
Think about some free trial app. Getting tons of throw away users.
Bill can you think of any reason to want to see the percent of total users ever?
If I want percent of total users then I should select all time.
Bill Henning
@BillHenning
Apr 08 2016 13:01
Can't I just flip to All Time to see that?
Eric J. Smith
@ejsmith
Apr 08 2016 13:01
Yeah
Bill Henning
@BillHenning
Apr 08 2016 13:01
There's your answer. :)
Eric J. Smith
@ejsmith
Apr 08 2016 13:01
Sessions is interesting though.
Bill Henning
@BillHenning
Apr 08 2016 13:01
You mean how my people have like 80% sessions?
Eric J. Smith
@ejsmith
Apr 08 2016 13:02
Seeing 100% on that all the time is useless. But seeing what percent of the total users logged in in this time range is interesting.
Bill Henning
@BillHenning
Apr 08 2016 13:02
Yeah it feels wrong... should really be 100%.
Eric J. Smith
@ejsmith
Apr 08 2016 13:02
But we can't special case it
Blake Niemyjski
@niemyjski
Apr 08 2016 13:15
I guess we can ever cash that and we have to query that everything
❤️ Siri
Eric J. Smith
@ejsmith
Apr 08 2016 13:17
We can cache it by the time filter I think we would get hits on that because they are going to switch vuews
It would only be for a short time
Blake Niemyjski
@niemyjski
Apr 08 2016 13:55
ok
but not sure how that would work
because the time filter: last 7 days
gets translated into a time range that changes all the time
Sander Rijken
@srijken
Apr 08 2016 13:59

Think we can use exceptionless to collect these?
https://www.veracode.com/blog/2014/03/guidelines-for-setting-security-headers

https://bugs.webkit.org/show_bug.cgi?id=100892
The report is JSON and is generated using the same facility as for the X-WebKit-CSP-Report-Only header. A sample might be:

    { "xss-report": {
        "request-url": "http://example.com/vulnerable-page?q=<script>alert(/xss/)</script>",
        "request-body": ""
    }}
could be useful for other report endpoints that are specified in headers
Eric J. Smith
@ejsmith
Apr 08 2016 14:08
@niemyjski yeah, gotta figure out a way to keep the cache key steady, eh?
@srijken you want to add them to the events?
Blake Niemyjski
@niemyjski
Apr 08 2016 14:26
@ejsmith yeah, and I don’t think it’s possible
Matt Oswald
@moswald
Apr 08 2016 14:33
I'm going to update my PR this morning - should I just remove the old constructor that I marked as Obsolete?
Eric J. Smith
@ejsmith
Apr 08 2016 14:39
@moswald we have been bad about making breaking changes.
My justification is that I am waiting for the library to be more popular before I worry about them too much.
Matt Oswald
@moswald
Apr 08 2016 14:39
:+1:
works for me
Eric J. Smith
@ejsmith
Apr 08 2016 14:39
might be a dumb justification. :-)
Matt Oswald
@moswald
Apr 08 2016 14:40
makes your life simpler
gets things out quicker
Eric J. Smith
@ejsmith
Apr 08 2016 14:40
yeah, I’m just trying to make things better and most of the breaking changes have been small things.
I guess if we were following semver then we would still be like 0.4.1
instead of 4.0
didn’t know this until the other day, but apparently if you are under 1.0 then all breaking change rules are off.
Blake Niemyjski
@niemyjski
Apr 08 2016 14:41
can we all comment on this: elastic/elasticsearch#17511
Eric J. Smith
@ejsmith
Apr 08 2016 14:42
if you want to
it really isn’t that hard to do from our end, but does feel like they should support it
Blake Niemyjski
@niemyjski
Apr 08 2016 14:48
yeah I agree
Eric J. Smith
@ejsmith
Apr 08 2016 18:08
works pretty good
yeah, they are using that in VSCode already