Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 01:34
    dependabot-preview[bot] labeled #524
  • 01:34

    dependabot-preview[bot] on nuget

    Bump Stripe.net from 34.23.0 to… (compare)

  • 01:34
    dependabot-preview[bot] opened #524
  • Feb 20 20:50
    mazhlekov starred exceptionless/Exceptionless
  • Feb 20 17:33
    ahmedsza commented #523
  • Feb 20 16:59
    ejsmith commented #523
  • Feb 20 16:49
    niemyjski labeled #523
  • Feb 20 16:42
    ejsmith commented #523
  • Feb 20 16:23
    ejsmith commented #523
  • Feb 20 12:36

    niemyjski on v6.0.0

    (compare)

  • Feb 20 12:03
    ahmedsza opened #523
  • Feb 20 11:23
    claassistantio commented #522
  • Feb 20 11:23
    dependabot-preview[bot] labeled #522
  • Feb 20 11:23
    dependabot-preview[bot] opened #522
  • Feb 20 11:23

    dependabot-preview[bot] on nuget

    Bump Microsoft.Extensions.Diagn… (compare)

  • Feb 20 11:22
    claassistantio commented #521
  • Feb 20 11:22
    dependabot-preview[bot] labeled #521
  • Feb 20 11:22
    dependabot-preview[bot] opened #521
  • Feb 20 11:22

    dependabot-preview[bot] on nuget

    Bump Microsoft.Extensions.Loggi… (compare)

  • Feb 20 11:22
    claassistantio commented #520
Blake Niemyjski
@niemyjski
todd’s really helpful
I had so many issues and he was really great about helping
so our tests are just mocking submission now?
Blake Niemyjski
@niemyjski
I know i had it hitting a local server or returning invalid which didn’t test good when the server wasn’t running
Frank Ebersoll
@frankebersoll
yes, and we test the content now.
Blake Niemyjski
@niemyjski
wish we could fire up a server easily
wonder if we could point it at dev
Frank Ebersoll
@frankebersoll
hitting a local server would be an integration test - but I would rather set that up with a mocked server in Node.js, too.
Blake Niemyjski
@niemyjski
but better that we don't
yeah
someday I’d like to have integration tests
and auto deploy
Frank Ebersoll
@frankebersoll
:-)
Blake Niemyjski
@niemyjski
really like how you refactored this man
I like that we share this code
Frank Ebersoll
@frankebersoll
It wasn't a big thing, and it all came out of having to spawn that child process.
Seemed most logical like that.
Blake Niemyjski
@niemyjski
the only thing I see so far and we can do it later it’s 100% fine right now is using an interfaces for the callback definition
like in getSettings
var cb:interface = (interface) =>
Frank Ebersoll
@frankebersoll
like SubmissionCallback.ts?
Blake Niemyjski
@niemyjski
yeah
do you think it would be cleaner
I guess if we are only doing it in one or two spots it doesn’t make sense
Frank Ebersoll
@frankebersoll
i would do it if it turns out it's used often and has many arguments.
I'm okay with (a:int, b:int)=>int
Blake Niemyjski
@niemyjski
yeah
okay I think the only thing missing from the commit unless I missed it
is probably should update the express or node sample to throw the exception on startup
or do you think we should leave that out cause it would crash the app
hmm
yeah that would crash the app and then it wouldn’t work
so guess we don’t need it
commit looks great man!
I say commit it and we’ll do a round of testing and I’ll get my but in grear and fix a bug that I’m seeing and we’ll push it!!
Frank Ebersoll
@frankebersoll
okay! with "commit it", do you mean merge it? from then, I will work in a feature branch?
Blake Niemyjski
@niemyjski
merge it :)
Frank Ebersoll
@frankebersoll
alright. thanks for your review!
Blake Niemyjski
@niemyjski
what did you think of the code. feels so great having someone else doing major feature work on the code base
Frank Ebersoll
@frankebersoll
I'll do some final testing myself and then merge it later the day.
Blake Niemyjski
@niemyjski
if you ever see anything stupid, let me know.. I’ll never get offended just upset at myself for doing something stupid
sounds good :)
Frank Ebersoll
@frankebersoll
I haven't seen something stupid yet - have to say that I'm no JavaScript expert either.
Blake Niemyjski
@niemyjski
after it’s merged I’ll also do a round and then we’ll update it and I’ll update npm
Frank Ebersoll
@frankebersoll
great
Blake Niemyjski
@niemyjski
once I get this signalr stuff done
I’ll update the server to check ref ids
Frank Ebersoll
@frankebersoll
then, I will update the client to submit as often as needed, using ref ids
Blake Niemyjski
@niemyjski
I’m wondering if that should still be opt in on the client
but it probably would be good to have