Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 10:09
    eliudgerardo starred exceptionless/Exceptionless
  • Jan 25 00:54
    claassistantio commented #488
  • Jan 25 00:53
    dependabot-preview[bot] labeled #488
  • Jan 25 00:53
    dependabot-preview[bot] opened #488
  • Jan 25 00:53

    dependabot-preview[bot] on nuget

    Bump Stripe.net from 34.16.1 to… (compare)

  • Jan 24 18:31

    ejsmith on update-events

    PERF - 62.6433% decrease in mar… Simplified event repo scripts (compare)

  • Jan 23 12:04
    modulexcite starred exceptionless/Exceptionless
  • Jan 23 05:20

    ejsmith on master

    Fix deploy secrets (compare)

  • Jan 23 05:06

    ejsmith on v6.0.0-rc1

    Try a different condition (compare)

  • Jan 23 05:06

    ejsmith on master

    Try a different condition (compare)

  • Jan 23 04:53

    ejsmith on v6.0.0-rc1

    (compare)

  • Jan 23 04:53

    ejsmith on master

    Fix deploy condition (compare)

  • Jan 23 04:28

    ejsmith on master

    Always login to docker hub (compare)

  • Jan 23 04:15

    ejsmith on master

    Deploy to dev env (compare)

  • Jan 23 03:59

    ejsmith on master

    Login to docker consistently (compare)

  • Jan 23 03:50

    ejsmith on master

    Deploy docker images to GPR (compare)

  • Jan 23 03:32

    ejsmith on master

    Fix docker image names (compare)

  • Jan 23 03:25

    ejsmith on master

    More build updates (compare)

  • Jan 23 01:21

    ejsmith on master

    ES 7.5.2, cleanup vscode tasks (compare)

  • Jan 23 00:54

    dependabot-preview[bot] on nuget

    (compare)

Blake Niemyjski
@niemyjski
really like how you refactored this man
I like that we share this code
Frank Ebersoll
@frankebersoll
It wasn't a big thing, and it all came out of having to spawn that child process.
Seemed most logical like that.
Blake Niemyjski
@niemyjski
the only thing I see so far and we can do it later it’s 100% fine right now is using an interfaces for the callback definition
like in getSettings
var cb:interface = (interface) =>
Frank Ebersoll
@frankebersoll
like SubmissionCallback.ts?
Blake Niemyjski
@niemyjski
yeah
do you think it would be cleaner
I guess if we are only doing it in one or two spots it doesn’t make sense
Frank Ebersoll
@frankebersoll
i would do it if it turns out it's used often and has many arguments.
I'm okay with (a:int, b:int)=>int
Blake Niemyjski
@niemyjski
yeah
okay I think the only thing missing from the commit unless I missed it
is probably should update the express or node sample to throw the exception on startup
or do you think we should leave that out cause it would crash the app
hmm
yeah that would crash the app and then it wouldn’t work
so guess we don’t need it
commit looks great man!
I say commit it and we’ll do a round of testing and I’ll get my but in grear and fix a bug that I’m seeing and we’ll push it!!
Frank Ebersoll
@frankebersoll
okay! with "commit it", do you mean merge it? from then, I will work in a feature branch?
Blake Niemyjski
@niemyjski
merge it :)
Frank Ebersoll
@frankebersoll
alright. thanks for your review!
Blake Niemyjski
@niemyjski
what did you think of the code. feels so great having someone else doing major feature work on the code base
Frank Ebersoll
@frankebersoll
I'll do some final testing myself and then merge it later the day.
Blake Niemyjski
@niemyjski
if you ever see anything stupid, let me know.. I’ll never get offended just upset at myself for doing something stupid
sounds good :)
Frank Ebersoll
@frankebersoll
I haven't seen something stupid yet - have to say that I'm no JavaScript expert either.
Blake Niemyjski
@niemyjski
after it’s merged I’ll also do a round and then we’ll update it and I’ll update npm
Frank Ebersoll
@frankebersoll
great
Blake Niemyjski
@niemyjski
once I get this signalr stuff done
I’ll update the server to check ref ids
Frank Ebersoll
@frankebersoll
then, I will update the client to submit as often as needed, using ref ids
Blake Niemyjski
@niemyjski
I’m wondering if that should still be opt in on the client
but it probably would be good to have
is there a good way to broadcast a message in javascript
would be kind of cool to say hey an error occurred with a reference id so users could update their page with a banner or something
but i guess they could do a plugin for that
KISS
@frankebersoll feeling any better today
Frank Ebersoll
@frankebersoll
broadcast from where to where? you mean, a local message bus?
Blake Niemyjski
@niemyjski
yeah in the browser or node app
but would be pretty easy to do something specific in a plugin if the user wanted
Sander Rijken
@srijken
I like that idea a lot :)
Magnus Lindhe
@mgnslndh
Hi! Is there a way to see what's new in one of Exceptionless' nuget packages? Release notes or changes or something like that.
Blake Niemyjski
@niemyjski
@mgnslndh currently the only way is to look at our releases section on the repo or individual commit messages
we try to include detailed release notes