Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Blake Niemyjski
@niemyjski
var cb:interface = (interface) =>
Frank Ebersoll
@frankebersoll
like SubmissionCallback.ts?
Blake Niemyjski
@niemyjski
yeah
do you think it would be cleaner
I guess if we are only doing it in one or two spots it doesn’t make sense
Frank Ebersoll
@frankebersoll
i would do it if it turns out it's used often and has many arguments.
I'm okay with (a:int, b:int)=>int
Blake Niemyjski
@niemyjski
yeah
okay I think the only thing missing from the commit unless I missed it
is probably should update the express or node sample to throw the exception on startup
or do you think we should leave that out cause it would crash the app
hmm
yeah that would crash the app and then it wouldn’t work
so guess we don’t need it
commit looks great man!
I say commit it and we’ll do a round of testing and I’ll get my but in grear and fix a bug that I’m seeing and we’ll push it!!
Frank Ebersoll
@frankebersoll
okay! with "commit it", do you mean merge it? from then, I will work in a feature branch?
Blake Niemyjski
@niemyjski
merge it :)
Frank Ebersoll
@frankebersoll
alright. thanks for your review!
Blake Niemyjski
@niemyjski
what did you think of the code. feels so great having someone else doing major feature work on the code base
Frank Ebersoll
@frankebersoll
I'll do some final testing myself and then merge it later the day.
Blake Niemyjski
@niemyjski
if you ever see anything stupid, let me know.. I’ll never get offended just upset at myself for doing something stupid
sounds good :)
Frank Ebersoll
@frankebersoll
I haven't seen something stupid yet - have to say that I'm no JavaScript expert either.
Blake Niemyjski
@niemyjski
after it’s merged I’ll also do a round and then we’ll update it and I’ll update npm
Frank Ebersoll
@frankebersoll
great
Blake Niemyjski
@niemyjski
once I get this signalr stuff done
I’ll update the server to check ref ids
Frank Ebersoll
@frankebersoll
then, I will update the client to submit as often as needed, using ref ids
Blake Niemyjski
@niemyjski
I’m wondering if that should still be opt in on the client
but it probably would be good to have
is there a good way to broadcast a message in javascript
would be kind of cool to say hey an error occurred with a reference id so users could update their page with a banner or something
but i guess they could do a plugin for that
KISS
@frankebersoll feeling any better today
Frank Ebersoll
@frankebersoll
broadcast from where to where? you mean, a local message bus?
Blake Niemyjski
@niemyjski
yeah in the browser or node app
but would be pretty easy to do something specific in a plugin if the user wanted
Sander Rijken
@srijken
I like that idea a lot :)
Magnus Lindhe
@mgnslndh
Hi! Is there a way to see what's new in one of Exceptionless' nuget packages? Release notes or changes or something like that.
Blake Niemyjski
@niemyjski
@mgnslndh currently the only way is to look at our releases section on the repo or individual commit messages
we try to include detailed release notes
https://github.com/exceptionless/Exceptionless.Net/releases
Magnus Lindhe
@mgnslndh
Nice, I see now that GitHub has a link for each release showing the commits made after the release. That's what I'm looking for. Thanks!
Will each commit result in a new NuGet package or are they released manually?
Blake Niemyjski
@niemyjski
it will deploy a new release to our myget feed
but we manually push from there to nuget
Blake Niemyjski
@niemyjski
@mgnslndh do you need this pushed asap?
Magnus Lindhe
@mgnslndh
I have made a local build of the assemblies and I can use them until you need to release next version.