Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Blake Niemyjski
@niemyjski
I say commit it and we’ll do a round of testing and I’ll get my but in grear and fix a bug that I’m seeing and we’ll push it!!
Frank Ebersoll
@frankebersoll
okay! with "commit it", do you mean merge it? from then, I will work in a feature branch?
Blake Niemyjski
@niemyjski
merge it :)
Frank Ebersoll
@frankebersoll
alright. thanks for your review!
Blake Niemyjski
@niemyjski
what did you think of the code. feels so great having someone else doing major feature work on the code base
Frank Ebersoll
@frankebersoll
I'll do some final testing myself and then merge it later the day.
Blake Niemyjski
@niemyjski
if you ever see anything stupid, let me know.. I’ll never get offended just upset at myself for doing something stupid
sounds good :)
Frank Ebersoll
@frankebersoll
I haven't seen something stupid yet - have to say that I'm no JavaScript expert either.
Blake Niemyjski
@niemyjski
after it’s merged I’ll also do a round and then we’ll update it and I’ll update npm
Frank Ebersoll
@frankebersoll
great
Blake Niemyjski
@niemyjski
once I get this signalr stuff done
I’ll update the server to check ref ids
Frank Ebersoll
@frankebersoll
then, I will update the client to submit as often as needed, using ref ids
Blake Niemyjski
@niemyjski
I’m wondering if that should still be opt in on the client
but it probably would be good to have
is there a good way to broadcast a message in javascript
would be kind of cool to say hey an error occurred with a reference id so users could update their page with a banner or something
but i guess they could do a plugin for that
KISS
@frankebersoll feeling any better today
Frank Ebersoll
@frankebersoll
broadcast from where to where? you mean, a local message bus?
Blake Niemyjski
@niemyjski
yeah in the browser or node app
but would be pretty easy to do something specific in a plugin if the user wanted
Sander Rijken
@srijken
I like that idea a lot :)
Magnus Lindhe
@mgnslndh
Hi! Is there a way to see what's new in one of Exceptionless' nuget packages? Release notes or changes or something like that.
Blake Niemyjski
@niemyjski
@mgnslndh currently the only way is to look at our releases section on the repo or individual commit messages
we try to include detailed release notes
Magnus Lindhe
@mgnslndh
Nice, I see now that GitHub has a link for each release showing the commits made after the release. That's what I'm looking for. Thanks!
Will each commit result in a new NuGet package or are they released manually?
Blake Niemyjski
@niemyjski
it will deploy a new release to our myget feed
but we manually push from there to nuget
Blake Niemyjski
@niemyjski
@mgnslndh do you need this pushed asap?
Magnus Lindhe
@mgnslndh
I have made a local build of the assemblies and I can use them until you need to release next version.
Blake Niemyjski
@niemyjski
ok
I’ll review it and see if anything else needs to go into it and push it
Thanks again!
everything else working out pretty good?
Magnus Lindhe
@mgnslndh
yes, Exceptionless is looking good so far. Nothing in production. About to ship first alpha so I wanted to incorporate crash reporting. Nice work on the .NET libs.
This is among my first contributions to other projects so I slowly get the hang of it. Hope to be of more use in the future!
Blake Niemyjski
@niemyjski
:)
Eric J. Smith
@ejsmith
@niemyjski dang. Can’t believe I’ve been getting trolled for 8 years. :-)
@mgnslndh awesome!!
Magnus Lindhe
@mgnslndh
How about adding an event to ExceptionlessClient that will fire when any unhandled exception is caught by any of its event handlers (UnobservedTask, AppDomain, Dispatcher, Application). Before the exception is submitted as an error event. I could then have a chance to log it locally. Or perhaps there already is some functionality like this?
Magnus Lindhe
@mgnslndh
Actually I think that event should fire for errors before/after the crash dialog.
If I listen to the event that fires after the crash dialog I can log and perhaps decide to terminate the application.
Blake Niemyjski
@niemyjski
@mgnslndh We have a submiting event that fires before the error is queued for submission. It also has a flag that you can check to see if it’s Unhandled and you can also cancel it so it’s not submitted
Magnus Lindhe
@mgnslndh
But the event is never fired if the user press "Cancel" on the dialog.
Blake Niemyjski
@niemyjski
Could because they cancled it before submitting was called.