Nice, I see now that GitHub has a link for each release showing the commits made after the release. That's what I'm looking for. Thanks!
Will each commit result in a new NuGet package or are they released manually?
Blake Niemyjski
@niemyjski
it will deploy a new release to our myget feed
but we manually push from there to nuget
Blake Niemyjski
@niemyjski
@mgnslndh do you need this pushed asap?
Magnus Lindhe
@mgnslndh
I have made a local build of the assemblies and I can use them until you need to release next version.
Blake Niemyjski
@niemyjski
ok
I’ll review it and see if anything else needs to go into it and push it
Thanks again!
everything else working out pretty good?
Magnus Lindhe
@mgnslndh
yes, Exceptionless is looking good so far. Nothing in production. About to ship first alpha so I wanted to incorporate crash reporting. Nice work on the .NET libs.
This is among my first contributions to other projects so I slowly get the hang of it. Hope to be of more use in the future!
Blake Niemyjski
@niemyjski
:)
Eric J. Smith
@ejsmith
@niemyjski dang. Can’t believe I’ve been getting trolled for 8 years. :-)
@mgnslndh awesome!!
Magnus Lindhe
@mgnslndh
How about adding an event to ExceptionlessClient that will fire when any unhandled exception is caught by any of its event handlers (UnobservedTask, AppDomain, Dispatcher, Application). Before the exception is submitted as an error event. I could then have a chance to log it locally. Or perhaps there already is some functionality like this?
Magnus Lindhe
@mgnslndh
Actually I think that event should fire for errors before/after the crash dialog.
If I listen to the event that fires after the crash dialog I can log and perhaps decide to terminate the application.
Blake Niemyjski
@niemyjski
@mgnslndh We have a submiting event that fires before the error is queued for submission. It also has a flag that you can check to see if it’s Unhandled and you can also cancel it so it’s not submitted
Magnus Lindhe
@mgnslndh
But the event is never fired if the user press "Cancel" on the dialog.
Blake Niemyjski
@niemyjski
Could because they cancled it before submitting was called.
let me look
Magnus Lindhe
@mgnslndh
The flow I am looking for is to do some cleaning and then shutdown the application when I have an unhandled exception. I could subscribe to all the necessary events and do it that way but I thought it would be nice if Exceptionless could provide a single event when it knows there is an unhandled exception that has been submitted or not (cancel on dialog).
The dialog ask if the user wants to submit a crash report or not. Either way I want to shutdown the application. Since I am using Exceptionless it would be nice to hook into its flow instead of hooking up several other event handlers that must run after Exceptionless. I mean it can be done without Exceptionless but it would be easier to have a little less plumbing to think about.
Blake Niemyjski
@niemyjski
The reason you are seeing that behavior is because they are wiring up to OnSubmitting before you
so if you wired up to that event handler first (before you call Startup) it would be hit