Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 02:53
    wmowm commented #459
  • Oct 12 15:59
    niemyjski commented #459
  • Oct 12 15:57
    niemyjski edited #459
  • Oct 12 12:54
    niemyjski synchronize #452
  • Oct 12 12:54

    niemyjski on elastic7

    Fixed serializer null reference… Fixed all Swagger issues. (compare)

  • Oct 12 12:26
    niemyjski synchronize #452
  • Oct 12 12:26

    niemyjski on elastic7

    Updated to latest foundatio rep… (compare)

  • Oct 12 12:24
    niemyjski synchronize #452
  • Oct 12 12:24

    niemyjski on elastic7

    Fixed elasticsearch serializer … (compare)

  • Oct 12 11:01
    wmowm opened #459
  • Oct 11 11:21
    niemyjski commented #458
  • Oct 10 21:18
    kiquenet opened #458
  • Oct 10 13:30
    niemyjski updated the wiki
  • Oct 10 09:20
  • Oct 10 03:36
  • Oct 09 15:54
    john-roland closed #456
  • Oct 09 15:54
    john-roland commented #456
  • Oct 09 14:12
    niemyjski labeled #457
  • Oct 09 14:12
    niemyjski labeled #457
  • Oct 09 14:12
    niemyjski commented #457
Blake Niemyjski
@niemyjski
we try to include detailed release notes
Magnus Lindhe
@mgnslndh
Nice, I see now that GitHub has a link for each release showing the commits made after the release. That's what I'm looking for. Thanks!
Will each commit result in a new NuGet package or are they released manually?
Blake Niemyjski
@niemyjski
it will deploy a new release to our myget feed
but we manually push from there to nuget
Blake Niemyjski
@niemyjski
@mgnslndh do you need this pushed asap?
Magnus Lindhe
@mgnslndh
I have made a local build of the assemblies and I can use them until you need to release next version.
Blake Niemyjski
@niemyjski
ok
I’ll review it and see if anything else needs to go into it and push it
Thanks again!
everything else working out pretty good?
Magnus Lindhe
@mgnslndh
yes, Exceptionless is looking good so far. Nothing in production. About to ship first alpha so I wanted to incorporate crash reporting. Nice work on the .NET libs.
This is among my first contributions to other projects so I slowly get the hang of it. Hope to be of more use in the future!
Blake Niemyjski
@niemyjski
:)
Eric J. Smith
@ejsmith
@niemyjski dang. Can’t believe I’ve been getting trolled for 8 years. :-)
@mgnslndh awesome!!
Magnus Lindhe
@mgnslndh
How about adding an event to ExceptionlessClient that will fire when any unhandled exception is caught by any of its event handlers (UnobservedTask, AppDomain, Dispatcher, Application). Before the exception is submitted as an error event. I could then have a chance to log it locally. Or perhaps there already is some functionality like this?
Magnus Lindhe
@mgnslndh
Actually I think that event should fire for errors before/after the crash dialog.
If I listen to the event that fires after the crash dialog I can log and perhaps decide to terminate the application.
Blake Niemyjski
@niemyjski
@mgnslndh We have a submiting event that fires before the error is queued for submission. It also has a flag that you can check to see if it’s Unhandled and you can also cancel it so it’s not submitted
Magnus Lindhe
@mgnslndh
But the event is never fired if the user press "Cancel" on the dialog.
Blake Niemyjski
@niemyjski
Could because they cancled it before submitting was called.
let me look
Magnus Lindhe
@mgnslndh
The flow I am looking for is to do some cleaning and then shutdown the application when I have an unhandled exception. I could subscribe to all the necessary events and do it that way but I thought it would be nice if Exceptionless could provide a single event when it knows there is an unhandled exception that has been submitted or not (cancel on dialog).
The dialog ask if the user wants to submit a crash report or not. Either way I want to shutdown the application. Since I am using Exceptionless it would be nice to hook into its flow instead of hooking up several other event handlers that must run after Exceptionless. I mean it can be done without Exceptionless but it would be easier to have a little less plumbing to think about.
Blake Niemyjski
@niemyjski
The reason you are seeing that behavior is because they are wiring up to OnSubmitting before you
so if you wired up to that event handler first (before you call Startup) it would be hit
We really only have that one event handler that gets called
and if you wire up to it first you will be good to go
Are you going to sbumit the errors before shutting down or just call shut down?
submission should happen when you call exit
Can you try this and let me know
Magnus Lindhe
@mgnslndh
I want the user to choose by showing the dialog. After the dialog I would like to shutdown. I would also like to have access to the Exception object that caused the crash.
Ok. Submission always occur on exit? I use Environment.FailFast() but I guess that could be a problem then.
Blake Niemyjski
@niemyjski
I’d recommend testing it but yes it should
We never tested fail fast with submission
You have access to all of that in the OnSubmission handler
we might need to abstract the showing of the dialog because you want to handle that yourself and exit.
Magnus Lindhe
@mgnslndh
But I still dont see how I could shutdown after the dialog has been shown if the error is not submitted.
Blake Niemyjski
@niemyjski
If you look at that ExceptionlessClient, the wpf extensions you can see the flow of what happens
currently, you’d have to show the dialog yourself
You’d have to register a handler on OnSubmitting (and show the dialog) and then to pass false to the Register(false) method which will prevent the wpf client from showing that dialog
that would give you complete control over this.
Magnus Lindhe
@mgnslndh
Yes. I'll have a look at it and maybe do a pull request. Would you consider a new event if I show a solution for it or would you rather prefer I solve it some other way?
Blake Niemyjski
@niemyjski
If we abstracted the showing of the dialog behavior, it would make this a bit easier
I beleive there is a recently opened github issue round this
I think it would be better to use the existing event, and be better to abstract the showing of the dialog in a generic way
Magnus Lindhe
@mgnslndh
Ah, so if I hook up my own handler and show the dialog and deal with the dialog result I can then shutdown for both "Submit" and "Cancel".
Blake Niemyjski
@niemyjski
yes :)