Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Blake Niemyjski
@niemyjski
I’d recommend testing it but yes it should
We never tested fail fast with submission
You have access to all of that in the OnSubmission handler
we might need to abstract the showing of the dialog because you want to handle that yourself and exit.
Magnus Lindhe
@mgnslndh
But I still dont see how I could shutdown after the dialog has been shown if the error is not submitted.
Blake Niemyjski
@niemyjski
If you look at that ExceptionlessClient, the wpf extensions you can see the flow of what happens
currently, you’d have to show the dialog yourself
You’d have to register a handler on OnSubmitting (and show the dialog) and then to pass false to the Register(false) method which will prevent the wpf client from showing that dialog
that would give you complete control over this.
Magnus Lindhe
@mgnslndh
Yes. I'll have a look at it and maybe do a pull request. Would you consider a new event if I show a solution for it or would you rather prefer I solve it some other way?
Blake Niemyjski
@niemyjski
If we abstracted the showing of the dialog behavior, it would make this a bit easier
I beleive there is a recently opened github issue round this
I think it would be better to use the existing event, and be better to abstract the showing of the dialog in a generic way
Magnus Lindhe
@mgnslndh
Ah, so if I hook up my own handler and show the dialog and deal with the dialog result I can then shutdown for both "Submit" and "Cancel".
Blake Niemyjski
@niemyjski
yes :)
Magnus Lindhe
@mgnslndh
Ok, just a quick question then. Is it possible to get hold of the original Exception object somehow?
Blake Niemyjski
@niemyjski
it should be straight foward just make sure you pass Register(false) so we don’t show that dialog.. and then you’d have to show it..
yes
Magnus Lindhe
@mgnslndh
GetError() returns a model of the error and I have not found a property or method for accessing the original Exception.
Blake Niemyjski
@niemyjski
    private static void OnSubmittingEvent(object sender, EventSubmittingEventArgs e) {
        //error.ExceptionlessClientInfo.Platform = ".NET WPF";
        if (!e.IsUnhandledError)
            return;

        var exception = e.PluginContextData.GetException();

        if (Application.Current != null && !Application.Current.Dispatcher.CheckAccess())
            e.Cancel = !(bool)Application.Current.Dispatcher.Invoke(new Func<EventSubmittingEventArgs, bool>(ShowDialog), DispatcherPriority.Send, e);
        else
            e.Cancel = !ShowDialog(e);
    }
You’d have to get it from the plugin context which if you inspect it contains everything that the plugins have access to (same contexT)
Magnus Lindhe
@mgnslndh
Ah, the context. Great! Now, I can solve both my issues.
Blake Niemyjski
@niemyjski
we have some helper methods on it too
Magnus Lindhe
@mgnslndh
Thanks a bunch! :)
Blake Niemyjski
@niemyjski
no problem. If you have any questions or think something could be easier let us knwo
I think we could make the showing of the dialog easier by abstracting it/injecting it into the di system
Frank Ebersoll
@frankebersoll
happy bday @niemyjski
Eric J. Smith
@ejsmith
@frankebersoll @niemyjski went on a road trip to nasville this weekend.
last I talked to him he was drinking a bit too much, :-)
Sander Rijken
@srijken
good times :)
Blake Niemyjski
@niemyjski
Thanks :)
Just woke up from a nap. 2 hours of sleep and we started driving back home
What did you all do this weekend?
Blake Niemyjski
@niemyjski
Hey guys we deployed 3.1 a bit ago
If you see any issues let me know I'm going to bed. We think we solved the threading issues as its been running for a while now. I'm going to be doing optimization to the client side including that caching pr.
Sander Rijken
@srijken
one thing I noticed was that a hidden stack didn't appear hidden. But it's the huge stack I told you about, so maybe that's the cause of it
speed is more than nice :D
Blake Niemyjski
@niemyjski
Hmm link? We kick off a background task for all operations on stacks and events
And the Ui hasn't been updated yet to use task progresses
Blake Niemyjski
@niemyjski
Screen Shot 2015-10-19 at 10.48.35 AM.png
I’d say our changes are positive so far :)
Going to keep making more changes and then release a new version for self hosters.
Frank Ebersoll
@frankebersoll
hey, I'm back :)
Blake Niemyjski
@niemyjski
awesome!
me too
was a nice vacation
:)
My liver is glad I’m back too lol
Frank Ebersoll
@frankebersoll
quite difficult architectural problems at work. Leader election in dynamic, distributed systems with asynchronous unreliable networking
sucks big time.