Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 07:04
  • 07:01
  • 06:15
    BrisWhite edited #461
  • 06:15
    BrisWhite edited #461
  • 06:12
    BrisWhite edited #461
  • 06:11
    BrisWhite opened #461
  • Oct 21 16:58

    ejsmith on elastic7

    (compare)

  • Oct 21 16:57
    ejsmith synchronize #452
  • Oct 21 16:57

    ejsmith on elastic7

    Started conversion to ES7 Fix a bunch of errors More Few more fixes and 43 more (compare)

  • Oct 21 02:24
  • Oct 20 05:23
  • Oct 19 13:53
  • Oct 18 13:28
    niemyjski synchronize #452
  • Oct 18 13:28

    niemyjski on elastic7

    Added improved request logging … (compare)

  • Oct 18 12:59
    niemyjski synchronize #452
  • Oct 18 12:59

    niemyjski on elastic7

    Improved logging of retention l… REVIEW - only discard event ind… (compare)

  • Oct 18 12:36
    niemyjski commented #459
  • Oct 18 12:25
    niemyjski synchronize #452
  • Oct 18 12:25

    niemyjski on elastic7

    Removed serializer test Updated deps and added authoriz… (compare)

  • Oct 18 11:52
    niemyjski closed #460
Blake Niemyjski
@niemyjski
ok
once your signed up remotely lets sign into it on this machine
benmaina
@benmaina
its cool now from other machines
Blake Niemyjski
@niemyjski
ok
if you wish to setup logging of exceptionless itself I can help you do that if you’d like
benmaina
@benmaina
I think from here i am now cool.Thanks alot for the support
Blake Niemyjski
@niemyjski
no problem! please let us know if you have any feedback
Also, I’d recommend changing your team viewer password as it’s in general chat :)
benmaina
@benmaina
@niemyjski already uninstalled..
haha
Blake Niemyjski
@niemyjski
:)
what are you looking to log in your projects?
exceptions/logs/feature usages/xyz?
Frank Ebersoll
@frankebersoll
@niemyjski I can happily add inheritance handling to our stringify method
do we need to use that all the time? or only for additional exception data?
Blake Niemyjski
@niemyjski
that would be great
I think all the time
to be consistent we don’t know where we are calling stringify from
I don’t know if we have any stringify tests that check that or other simple data types.
probably need them if we are going to flatten cause we can’t error when flatting a string
I’m working on data exclusions in the .net client to be on pairity with the js client :)
Frank Ebersoll
@frankebersoll
okay
should i fix it in main?
Blake Niemyjski
@niemyjski
yeah
Blake Niemyjski
@niemyjski
exceptionless/Exceptionless.Net@896432e
:)
Frank Ebersoll
@frankebersoll
nice one!
should we flatten deeply?
or only first level?
Blake Niemyjski
@niemyjski
how slow is this going to make it is my question
Frank Ebersoll
@frankebersoll
deep would be harder to do because of possible cycles
we do it first-level :-) k?
Blake Niemyjski
@niemyjski
yeah
I just remembered I never implemented the depth support to the stringify method.
Frank Ebersoll
@frankebersoll
you mean max-depth?
that's right, i saw exceptions with very deep additional data pushing the layout out of its bounds on the right edge
it did not look pretty.
it was tables in tables. tables in tables in tables.
like a matryoshka doll
Blake Niemyjski
@niemyjski
yeah
in the dot net client we do max depth
                json = serializer.Serialize(info.Data, exclusions, info.MaxDepthToSerialize.HasValue ? info.MaxDepthToSerialize.Value : 5, info.IgnoreSerializationErrors);
guess our default depth is 5
think it should be even smaller than that in js?
like 2
or 3
three might be good if we are doing a really small depth probably wouldn’t hurt to flatten it all but guess we should just flatten the first and it would be easy to flatten them all later if needed
Frank Ebersoll
@frankebersoll
in the meantime... i created a PR for my little refactoring. no actual build process improvements, yet. we need to discuss those a little more
Blake Niemyjski
@niemyjski
ok
just let me know when you want to discus it