Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Nov 15 15:45
    niemyjski synchronize #452
  • Nov 15 15:45

    niemyjski on elastic7

    Fixed reindex mapping issues on… (compare)

  • Nov 15 03:05
    foresightyj closed #467
  • Nov 15 03:05
    foresightyj commented #467
  • Nov 15 03:03
    foresightyj edited #467
  • Nov 15 03:02
    foresightyj opened #467
  • Nov 14 14:41
    niemyjski synchronize #452
  • Nov 14 14:41

    niemyjski on elastic7

    reordered index migrations (compare)

  • Nov 14 13:20
    niemyjski synchronize #452
  • Nov 14 13:20

    niemyjski on elastic7

    Added reindex cutoff date option (compare)

  • Nov 14 12:12
    niemyjski commented #465
  • Nov 14 11:39
    niemyjski synchronize #452
  • Nov 14 11:39

    niemyjski on elastic7

    Started conversion to ES7 Fix a bunch of errors More Few more fixes and 56 more (compare)

  • Nov 14 11:28
    niemyjski commented #465
  • Nov 14 11:27
    niemyjski closed #465
  • Nov 14 11:27

    niemyjski on master

    Fix #465 - Temporary remove myg… (compare)

  • Nov 14 09:27
    BrisWhite commented #461
  • Nov 13 15:14
    niemyjski commented #465
  • Nov 13 07:06
    squarezx commented #465
  • Nov 12 14:58
    niemyjski commented #461
Blake Niemyjski
@niemyjski
I think all the time
to be consistent we don’t know where we are calling stringify from
I don’t know if we have any stringify tests that check that or other simple data types.
probably need them if we are going to flatten cause we can’t error when flatting a string
I’m working on data exclusions in the .net client to be on pairity with the js client :)
Frank Ebersoll
@frankebersoll
okay
should i fix it in main?
Blake Niemyjski
@niemyjski
yeah
Blake Niemyjski
@niemyjski
exceptionless/Exceptionless.Net@896432e
:)
Frank Ebersoll
@frankebersoll
nice one!
should we flatten deeply?
or only first level?
Blake Niemyjski
@niemyjski
how slow is this going to make it is my question
Frank Ebersoll
@frankebersoll
deep would be harder to do because of possible cycles
we do it first-level :-) k?
Blake Niemyjski
@niemyjski
yeah
I just remembered I never implemented the depth support to the stringify method.
Frank Ebersoll
@frankebersoll
you mean max-depth?
that's right, i saw exceptions with very deep additional data pushing the layout out of its bounds on the right edge
it did not look pretty.
it was tables in tables. tables in tables in tables.
like a matryoshka doll
Blake Niemyjski
@niemyjski
yeah
in the dot net client we do max depth
                json = serializer.Serialize(info.Data, exclusions, info.MaxDepthToSerialize.HasValue ? info.MaxDepthToSerialize.Value : 5, info.IgnoreSerializationErrors);
guess our default depth is 5
think it should be even smaller than that in js?
like 2
or 3
three might be good if we are doing a really small depth probably wouldn’t hurt to flatten it all but guess we should just flatten the first and it would be easy to flatten them all later if needed
Frank Ebersoll
@frankebersoll
in the meantime... i created a PR for my little refactoring. no actual build process improvements, yet. we need to discuss those a little more
Blake Niemyjski
@niemyjski
ok
just let me know when you want to discus it
Frank Ebersoll
@frankebersoll
okay, there are multiple things :-)
first: test.
i tried it out and removed everything. karma, chrome, jasmine.
Blake Niemyjski
@niemyjski
did it make it easier to test?
Frank Ebersoll
@frankebersoll
i added: mocha, chai.
syntax is marginally different, now it's expect(something).to.be.null instead of .to.be(null)
Blake Niemyjski
@niemyjski
ok
that’s fine if it makes testing easier :)
Frank Ebersoll
@frankebersoll
test time is down to 1 second for all tests.
Blake Niemyjski
@niemyjski
dang
Frank Ebersoll
@frankebersoll
you don't even wait, it's immediate.
Blake Niemyjski
@niemyjski
that will be nice
could even have it run tests on watch now
hehe
Frank Ebersoll
@frankebersoll
better: you can set breakpoints and debug into tests. in the IDE.
yes, that's what i have my BDD watcher task for.