by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 04:22

    niemyjski on discard-join

    WIP - Event Join Tests (compare)

  • 03:37

    ejsmith on master

    Update build. Remove outdated m… (compare)

  • 03:35

    ejsmith on master

    Update build. Remove outdated m… (compare)

  • May 27 02:48

    ejsmith on master

    Update to ES7.7 (compare)

  • May 27 02:43

    niemyjski on discard-join

    WIP Added event controller test… (compare)

  • May 27 02:33

    niemyjski on discard-join

    Reworked creating search data. (compare)

  • May 27 01:25
    fang625492430 starred exceptionless/Exceptionless
  • May 26 21:40

    ejsmith on master

    Make html5 mode work (compare)

  • May 26 21:36

    ejsmith on master

    Don't store artifacts (compare)

  • May 26 20:54

    ejsmith on discard-join

    Update to new repos. (compare)

  • May 26 15:15
    ejsmith commented #629
  • May 26 13:23
    niemyjski commented #629
  • May 26 09:21
    a14907 commented #629
  • May 26 05:44
    fangxin810425 starred exceptionless/Exceptionless
  • May 26 02:52
  • May 25 20:42
  • May 25 05:50
  • May 25 02:58

    niemyjski on discard-join

    WIP Stack mode for events (compare)

  • May 24 17:16
    niemyjski commented #530
  • May 24 17:16
    niemyjski commented #530
Blake Niemyjski
@niemyjski
exceptionless/Exceptionless.Net@896432e
:)
Frank Ebersoll
@frankebersoll
nice one!
should we flatten deeply?
or only first level?
Blake Niemyjski
@niemyjski
how slow is this going to make it is my question
Frank Ebersoll
@frankebersoll
deep would be harder to do because of possible cycles
we do it first-level :-) k?
Blake Niemyjski
@niemyjski
yeah
I just remembered I never implemented the depth support to the stringify method.
Frank Ebersoll
@frankebersoll
you mean max-depth?
that's right, i saw exceptions with very deep additional data pushing the layout out of its bounds on the right edge
it did not look pretty.
it was tables in tables. tables in tables in tables.
like a matryoshka doll
Blake Niemyjski
@niemyjski
yeah
in the dot net client we do max depth
                json = serializer.Serialize(info.Data, exclusions, info.MaxDepthToSerialize.HasValue ? info.MaxDepthToSerialize.Value : 5, info.IgnoreSerializationErrors);
guess our default depth is 5
think it should be even smaller than that in js?
like 2
or 3
three might be good if we are doing a really small depth probably wouldn’t hurt to flatten it all but guess we should just flatten the first and it would be easy to flatten them all later if needed
Frank Ebersoll
@frankebersoll
in the meantime... i created a PR for my little refactoring. no actual build process improvements, yet. we need to discuss those a little more
Blake Niemyjski
@niemyjski
ok
just let me know when you want to discus it
Frank Ebersoll
@frankebersoll
okay, there are multiple things :-)
first: test.
i tried it out and removed everything. karma, chrome, jasmine.
Blake Niemyjski
@niemyjski
did it make it easier to test?
Frank Ebersoll
@frankebersoll
i added: mocha, chai.
syntax is marginally different, now it's expect(something).to.be.null instead of .to.be(null)
Blake Niemyjski
@niemyjski
ok
that’s fine if it makes testing easier :)
Frank Ebersoll
@frankebersoll
test time is down to 1 second for all tests.
Blake Niemyjski
@niemyjski
dang
Frank Ebersoll
@frankebersoll
you don't even wait, it's immediate.
Blake Niemyjski
@niemyjski
that will be nice
could even have it run tests on watch now
hehe
Frank Ebersoll
@frankebersoll
better: you can set breakpoints and debug into tests. in the IDE.
yes, that's what i have my BDD watcher task for.
Blake Niemyjski
@niemyjski
awe sweet
Frank Ebersoll
@frankebersoll
there's one problem: it will be much more fun if the build itself is faster.
Blake Niemyjski
@niemyjski
merge immediately :)
Frank Ebersoll
@frankebersoll
and we have no incremental builds yet - i don't know if tsproject supports them.
Blake Niemyjski
@niemyjski
the thing with 36, we’ve made some commits since then, we gotta make sure it merges properly.
Frank Ebersoll
@frankebersoll
i mean, it has to spit out the whole thing every time.
Blake Niemyjski
@niemyjski
tsproject does I think
if it doesn’t we could create an issue