Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Blake Niemyjski
@niemyjski
in the dot net client we do max depth
                json = serializer.Serialize(info.Data, exclusions, info.MaxDepthToSerialize.HasValue ? info.MaxDepthToSerialize.Value : 5, info.IgnoreSerializationErrors);
guess our default depth is 5
think it should be even smaller than that in js?
like 2
or 3
three might be good if we are doing a really small depth probably wouldn’t hurt to flatten it all but guess we should just flatten the first and it would be easy to flatten them all later if needed
Frank Ebersoll
@frankebersoll
in the meantime... i created a PR for my little refactoring. no actual build process improvements, yet. we need to discuss those a little more
Blake Niemyjski
@niemyjski
ok
just let me know when you want to discus it
Frank Ebersoll
@frankebersoll
okay, there are multiple things :-)
first: test.
i tried it out and removed everything. karma, chrome, jasmine.
Blake Niemyjski
@niemyjski
did it make it easier to test?
Frank Ebersoll
@frankebersoll
i added: mocha, chai.
syntax is marginally different, now it's expect(something).to.be.null instead of .to.be(null)
Blake Niemyjski
@niemyjski
ok
that’s fine if it makes testing easier :)
Frank Ebersoll
@frankebersoll
test time is down to 1 second for all tests.
Blake Niemyjski
@niemyjski
dang
Frank Ebersoll
@frankebersoll
you don't even wait, it's immediate.
Blake Niemyjski
@niemyjski
that will be nice
could even have it run tests on watch now
hehe
Frank Ebersoll
@frankebersoll
better: you can set breakpoints and debug into tests. in the IDE.
yes, that's what i have my BDD watcher task for.
Blake Niemyjski
@niemyjski
awe sweet
Frank Ebersoll
@frankebersoll
there's one problem: it will be much more fun if the build itself is faster.
Blake Niemyjski
@niemyjski
merge immediately :)
Frank Ebersoll
@frankebersoll
and we have no incremental builds yet - i don't know if tsproject supports them.
Blake Niemyjski
@niemyjski
the thing with 36, we’ve made some commits since then, we gotta make sure it merges properly.
Frank Ebersoll
@frankebersoll
i mean, it has to spit out the whole thing every time.
Blake Niemyjski
@niemyjski
tsproject does I think
if it doesn’t we could create an issue
that guy is really good about it
Frank Ebersoll
@frankebersoll
my question is, do we really need it during development time?
build, watch and watch-test should do as little work as possible.
Blake Niemyjski
@niemyjski
no, I think we are fine
although, do we have to transpile for tests?
I think that’s a yes
Frank Ebersoll
@frankebersoll
we need an additional publish task that does packaging, final tests and then pushes it
at least, that's what i imagine right now
yes, we need to transpile, and with source maps so.
because it will make debugging much easier. i've enabled source maps in karma, so we get stack traces with actual typescript references
no more searching in js files
it also enables stepping into typescript. i didn't get that with our current solution, sadly
Blake Niemyjski
@niemyjski
yeah that will be really nice
well we have the build step
which publish relies on
so we should be fine. unless all of that changed