Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 09:40
    zhangyiqiu starred exceptionless/Exceptionless
  • 07:45
  • 05:47
    ejsmith edited #471
  • 05:46
    ejsmith opened #471
  • 05:46

    ejsmith on strip-large-data

    Strip large data values out of … (compare)

  • Dec 11 19:54
    niemyjski synchronize #452
  • Dec 11 19:54

    niemyjski on elastic7

    Decrease batch size (compare)

  • Dec 11 14:51
    niemyjski synchronize #452
  • Dec 11 14:51

    niemyjski on elastic7

    Reset the alias cache before ru… (compare)

  • Dec 11 04:03

    ejsmith on mappings-refactor

    (compare)

  • Dec 11 04:02
    ejsmith synchronize #452
  • Dec 11 04:02

    ejsmith on elastic7

    Change a bunch of index field s… Updated dependencies. Revert to 2201-pre and 6 more (compare)

  • Dec 11 04:02
    ejsmith closed #470
  • Dec 11 04:02
    ejsmith edited #470
  • Dec 11 03:59
    ejsmith opened #470
  • Dec 11 03:14

    niemyjski on mappings-refactor

    Updated to latest foundatio (compare)

  • Dec 11 02:59

    niemyjski on mappings-refactor

    Tweaked the event index mapping… (compare)

  • Dec 11 01:53

    ejsmith on mappings-refactor

    Update cache client list method… (compare)

  • Dec 11 01:19

    ejsmith on mappings-refactor

    More index work (compare)

  • Dec 10 13:26
    niemyjski commented #468
Blake Niemyjski
@niemyjski
did it make it easier to test?
Frank Ebersoll
@frankebersoll
i added: mocha, chai.
syntax is marginally different, now it's expect(something).to.be.null instead of .to.be(null)
Blake Niemyjski
@niemyjski
ok
that’s fine if it makes testing easier :)
Frank Ebersoll
@frankebersoll
test time is down to 1 second for all tests.
Blake Niemyjski
@niemyjski
dang
Frank Ebersoll
@frankebersoll
you don't even wait, it's immediate.
Blake Niemyjski
@niemyjski
that will be nice
could even have it run tests on watch now
hehe
Frank Ebersoll
@frankebersoll
better: you can set breakpoints and debug into tests. in the IDE.
yes, that's what i have my BDD watcher task for.
Blake Niemyjski
@niemyjski
awe sweet
Frank Ebersoll
@frankebersoll
there's one problem: it will be much more fun if the build itself is faster.
Blake Niemyjski
@niemyjski
merge immediately :)
Frank Ebersoll
@frankebersoll
and we have no incremental builds yet - i don't know if tsproject supports them.
Blake Niemyjski
@niemyjski
the thing with 36, we’ve made some commits since then, we gotta make sure it merges properly.
Frank Ebersoll
@frankebersoll
i mean, it has to spit out the whole thing every time.
Blake Niemyjski
@niemyjski
tsproject does I think
if it doesn’t we could create an issue
that guy is really good about it
Frank Ebersoll
@frankebersoll
my question is, do we really need it during development time?
build, watch and watch-test should do as little work as possible.
Blake Niemyjski
@niemyjski
no, I think we are fine
although, do we have to transpile for tests?
I think that’s a yes
Frank Ebersoll
@frankebersoll
we need an additional publish task that does packaging, final tests and then pushes it
at least, that's what i imagine right now
yes, we need to transpile, and with source maps so.
because it will make debugging much easier. i've enabled source maps in karma, so we get stack traces with actual typescript references
no more searching in js files
it also enables stepping into typescript. i didn't get that with our current solution, sadly
Blake Niemyjski
@niemyjski
yeah that will be really nice
well we have the build step
which publish relies on
so we should be fine. unless all of that changed
Frank Ebersoll
@frankebersoll
build takes about 20 seconds on my machine now
with gulp-tsb and incremental builds i got it down to 0.5 seconds when a file changes.
Blake Niemyjski
@niemyjski
well we don’t have to run the linter
that should make it faster no?
Frank Ebersoll
@frankebersoll
so, build could be only what is needed to run and debug stuff. and publish would do minifying, packaging and whatnot
yes, but even that could be included in watch
and even before building, because, i don't want to build if my source code has errors
i'll try to get incremental builds working with tsproject
but first, i fix stringify
#36 has been rebased onto all commits that have happened in the meantime
should be ready for merge
Blake Niemyjski
@niemyjski
ok
did you sync?