Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 02:53
    wmowm commented #459
  • Oct 12 15:59
    niemyjski commented #459
  • Oct 12 15:57
    niemyjski edited #459
  • Oct 12 12:54
    niemyjski synchronize #452
  • Oct 12 12:54

    niemyjski on elastic7

    Fixed serializer null reference… Fixed all Swagger issues. (compare)

  • Oct 12 12:26
    niemyjski synchronize #452
  • Oct 12 12:26

    niemyjski on elastic7

    Updated to latest foundatio rep… (compare)

  • Oct 12 12:24
    niemyjski synchronize #452
  • Oct 12 12:24

    niemyjski on elastic7

    Fixed elasticsearch serializer … (compare)

  • Oct 12 11:01
    wmowm opened #459
  • Oct 11 11:21
    niemyjski commented #458
  • Oct 10 21:18
    kiquenet opened #458
  • Oct 10 13:30
    niemyjski updated the wiki
  • Oct 10 09:20
  • Oct 10 03:36
  • Oct 09 15:54
    john-roland closed #456
  • Oct 09 15:54
    john-roland commented #456
  • Oct 09 14:12
    niemyjski labeled #457
  • Oct 09 14:12
    niemyjski labeled #457
  • Oct 09 14:12
    niemyjski commented #457
Blake Niemyjski
@niemyjski
awe sweet
Frank Ebersoll
@frankebersoll
there's one problem: it will be much more fun if the build itself is faster.
Blake Niemyjski
@niemyjski
merge immediately :)
Frank Ebersoll
@frankebersoll
and we have no incremental builds yet - i don't know if tsproject supports them.
Blake Niemyjski
@niemyjski
the thing with 36, we’ve made some commits since then, we gotta make sure it merges properly.
Frank Ebersoll
@frankebersoll
i mean, it has to spit out the whole thing every time.
Blake Niemyjski
@niemyjski
tsproject does I think
if it doesn’t we could create an issue
that guy is really good about it
Frank Ebersoll
@frankebersoll
my question is, do we really need it during development time?
build, watch and watch-test should do as little work as possible.
Blake Niemyjski
@niemyjski
no, I think we are fine
although, do we have to transpile for tests?
I think that’s a yes
Frank Ebersoll
@frankebersoll
we need an additional publish task that does packaging, final tests and then pushes it
at least, that's what i imagine right now
yes, we need to transpile, and with source maps so.
because it will make debugging much easier. i've enabled source maps in karma, so we get stack traces with actual typescript references
no more searching in js files
it also enables stepping into typescript. i didn't get that with our current solution, sadly
Blake Niemyjski
@niemyjski
yeah that will be really nice
well we have the build step
which publish relies on
so we should be fine. unless all of that changed
Frank Ebersoll
@frankebersoll
build takes about 20 seconds on my machine now
with gulp-tsb and incremental builds i got it down to 0.5 seconds when a file changes.
Blake Niemyjski
@niemyjski
well we don’t have to run the linter
that should make it faster no?
Frank Ebersoll
@frankebersoll
so, build could be only what is needed to run and debug stuff. and publish would do minifying, packaging and whatnot
yes, but even that could be included in watch
and even before building, because, i don't want to build if my source code has errors
i'll try to get incremental builds working with tsproject
but first, i fix stringify
#36 has been rebased onto all commits that have happened in the meantime
should be ready for merge
Blake Niemyjski
@niemyjski
ok
did you sync?
Frank Ebersoll
@frankebersoll
?
Blake Niemyjski
@niemyjski
push your changes I dont’ see the rebase or I guess it doesn’t show up in github?
Frank Ebersoll
@frankebersoll
i have rewritten the changes so they include your commits
Blake Niemyjski
@niemyjski
ok, do you think we should merge it now or after our release?
it’s your call
if it’s going to make our lives easier lets do it now
Frank Ebersoll
@frankebersoll
this should be non-breaking, as a recompile lead to no changes in dist
Blake Niemyjski
@niemyjski
ok
Frank Ebersoll
@frankebersoll
only things to change in dist have been maps, which makes sense
Blake Niemyjski
@niemyjski
ok
merged
give me a few minutes