Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 13:48
    ahmedsza commented #523
  • Feb 27 22:56
    Edreih commented #529
  • Feb 27 22:43
    claassistantio commented #531
  • Feb 27 22:43
    dependabot-preview[bot] labeled #531
  • Feb 27 22:43

    dependabot-preview[bot] on nuget

    Bump Foundatio.Repositories.Ela… (compare)

  • Feb 27 22:43
    dependabot-preview[bot] opened #531
  • Feb 27 21:39
    niemyjski commented #529
  • Feb 27 19:35
    Edreih commented #529
  • Feb 26 22:24
    Edreih edited #529
  • Feb 26 20:15
    ejsmith edited #530
  • Feb 26 20:07
    ejsmith edited #530
  • Feb 26 18:26
  • Feb 26 18:13
  • Feb 26 17:00
    ejsmith commented #530
  • Feb 26 17:00
    ejsmith commented #530
  • Feb 26 16:54
    ejsmith opened #530
  • Feb 25 23:00
    Edreih opened #529
  • Feb 25 15:04
    dependabot-preview[bot] commented #501
Frank Ebersoll
@frankebersoll
yes, we need to transpile, and with source maps so.
because it will make debugging much easier. i've enabled source maps in karma, so we get stack traces with actual typescript references
no more searching in js files
it also enables stepping into typescript. i didn't get that with our current solution, sadly
Blake Niemyjski
@niemyjski
yeah that will be really nice
well we have the build step
which publish relies on
so we should be fine. unless all of that changed
Frank Ebersoll
@frankebersoll
build takes about 20 seconds on my machine now
with gulp-tsb and incremental builds i got it down to 0.5 seconds when a file changes.
Blake Niemyjski
@niemyjski
well we don’t have to run the linter
that should make it faster no?
Frank Ebersoll
@frankebersoll
so, build could be only what is needed to run and debug stuff. and publish would do minifying, packaging and whatnot
yes, but even that could be included in watch
and even before building, because, i don't want to build if my source code has errors
i'll try to get incremental builds working with tsproject
but first, i fix stringify
#36 has been rebased onto all commits that have happened in the meantime
should be ready for merge
Blake Niemyjski
@niemyjski
ok
did you sync?
Frank Ebersoll
@frankebersoll
?
Blake Niemyjski
@niemyjski
push your changes I dont’ see the rebase or I guess it doesn’t show up in github?
Frank Ebersoll
@frankebersoll
i have rewritten the changes so they include your commits
Blake Niemyjski
@niemyjski
ok, do you think we should merge it now or after our release?
it’s your call
if it’s going to make our lives easier lets do it now
Frank Ebersoll
@frankebersoll
this should be non-breaking, as a recompile lead to no changes in dist
Blake Niemyjski
@niemyjski
ok
Frank Ebersoll
@frankebersoll
only things to change in dist have been maps, which makes sense
Blake Niemyjski
@niemyjski
ok
merged
give me a few minutes
once I push these nuget packages I can focus just on the js client
@all thanks for your help getting https://github.com/exceptionless/Exceptionless.Net/releases/tag/v3.2.0 out the door!
Frank Ebersoll
@frankebersoll
okay, i'm on stringify then.
Blake Niemyjski
@niemyjski
I’m on it, looking at your changes :)
pulling latest hehe
Frank Ebersoll
@frankebersoll
i put my messing with the build into... ehm... features/betterBuild
would be interesting to know if that works for you. i constantly get 0.8 seconds for 72 test cases
Blake Niemyjski
@niemyjski
ok
want me to pull that down first?
I’m on that branch now
let me check
3.2.1424
830ms
dangggg
we had that one test that did a timeout or something
did you update it?