Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Frank Ebersoll
@frankebersoll
should be ready for merge
Blake Niemyjski
@niemyjski
ok
did you sync?
Frank Ebersoll
@frankebersoll
?
Blake Niemyjski
@niemyjski
push your changes I dont’ see the rebase or I guess it doesn’t show up in github?
Frank Ebersoll
@frankebersoll
i have rewritten the changes so they include your commits
Blake Niemyjski
@niemyjski
ok, do you think we should merge it now or after our release?
it’s your call
if it’s going to make our lives easier lets do it now
Frank Ebersoll
@frankebersoll
this should be non-breaking, as a recompile lead to no changes in dist
Blake Niemyjski
@niemyjski
ok
Frank Ebersoll
@frankebersoll
only things to change in dist have been maps, which makes sense
Blake Niemyjski
@niemyjski
ok
merged
give me a few minutes
once I push these nuget packages I can focus just on the js client
@all thanks for your help getting https://github.com/exceptionless/Exceptionless.Net/releases/tag/v3.2.0 out the door!
Frank Ebersoll
@frankebersoll
okay, i'm on stringify then.
Blake Niemyjski
@niemyjski
I’m on it, looking at your changes :)
pulling latest hehe
Frank Ebersoll
@frankebersoll
i put my messing with the build into... ehm... features/betterBuild
would be interesting to know if that works for you. i constantly get 0.8 seconds for 72 test cases
Blake Niemyjski
@niemyjski
ok
want me to pull that down first?
I’m on that branch now
let me check
3.2.1424
830ms
dangggg
we had that one test that did a timeout or something
did you update it?
I think that was taking the 10 seconds to be honest not sure
awe that is awesome, it highlights the slow tests
[TsProject] Compiling Project Files...
[TsProject] src/typings/jasmine/jasmine.d.ts(9,18): error TS2300: Duplicate identifier 'describe'.
[TsProject] src/typings/jasmine/jasmine.d.ts(11,18): error TS2300: Duplicate identifier 'xdescribe'.
[TsProject] src/typings/jasmine/jasmine.d.ts(13,18): error TS2300: Duplicate identifier 'it'.
[TsProject] src/typings/jasmine/jasmine.d.ts(14,18): error TS2300: Duplicate identifier 'it'.
[TsProject] src/typings/jasmine/jasmine.d.ts(17,18): error TS2300: Duplicate identifier 'xit'.
[TsProject] src/typings/jasmine/jasmine.d.ts(18,18): error TS2300: Duplicate identifier 'xit'.
[TsProject] src/typings/mocha/mocha.d.ts(37,13): error TS2300: Duplicate identifier 'describe'.
[TsProject] src/typings/mocha/mocha.d.ts(38,13): error TS2300: Duplicate identifier 'xdescribe'.
[TsProject] src/typings/mocha/mocha.d.ts(43,13): error TS2300: Duplicate identifier 'it'.
[TsProject] src/typings/mocha/mocha.d.ts(44,13): error TS2300: Duplicate identifier 'xit'.
Blake Niemyjski
@niemyjski
do you get that as well?
Frank Ebersoll
@frankebersoll
just throw away your jasmine typings
tsd doesn't remove them on its own.
i don't know about timeouts - didn't get any. i don't know how to specify the timeout for single tests either, but we should focus on having fast tests anyway.
Blake Niemyjski
@niemyjski
yeah, I fixed it.
Frank Ebersoll
@frankebersoll
what do you think about it generally?
Blake Niemyjski
@niemyjski
like it
I think it was eventplugin manager timeout test or it was a timeout checking test
but if it’s all green fine by me
Frank Ebersoll
@frankebersoll
source maps not working yet, but we will get there.
Blake Niemyjski
@niemyjski
seems much faster and higher weight
only thing I really want and it’s not going to happen anytime soon is for webstorm to detect file paths and make them clickable
would be sweet to click to go to test failure, I think vs code has it
Frank Ebersoll
@frankebersoll
yes, has it since the latest update.
Blake Niemyjski
@niemyjski
light weight*