Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • May 13 21:40
    ejsmith synchronize #95
  • May 13 21:40

    ejsmith on workspaces

    Add typing for event data known… (compare)

  • May 08 22:13
    CLAassistant commented #100
  • May 08 22:13
    dependabot[bot] labeled #100
  • May 08 22:13
    dependabot[bot] opened #100
  • May 08 22:13

    dependabot[bot] on npm_and_yarn

    Bump hosted-git-info from 2.5.0… (compare)

  • May 07 13:51
    CLAassistant commented #95
  • May 07 13:50
    polluterofminds synchronize #95
  • May 07 13:50

    polluterofminds on workspaces

    can't import vue package yet (compare)

  • May 07 13:48
    polluterofminds synchronize #95
  • May 07 13:48

    polluterofminds on workspaces

    vue error boundary work --- in … (compare)

  • May 07 13:40
    CLAassistant commented #210
  • May 07 13:40
    dependabot[bot] labeled #210
  • May 07 13:40
    dependabot[bot] opened #210
  • May 07 13:40

    dependabot[bot] on npm_and_yarn

    Bump grunt from 1.0.4 to 1.3.0 … (compare)

  • May 07 12:25
    niemyjski synchronize #95
  • May 07 12:25

    niemyjski on workspaces

    Fixed issues with node-stack-tr… (compare)

  • May 06 14:10
    CLAassistant commented #95
  • May 06 14:10
    polluterofminds synchronize #95
  • May 06 14:10

    polluterofminds on workspaces

    vue example and angular start: (compare)

Eric J. Smith
@ejsmith
where the timer only fires exactly when it needs to.
Blake Niemyjski
@niemyjski
eh
once every 60 seconds
not really worried about that...
Sander Rijken
@srijken
and the only thing it does is try to dequeue an event
Blake Niemyjski
@niemyjski
ooh crap just thought of something
Sander Rijken
@srijken
it’s not doing a ton of work
Blake Niemyjski
@niemyjski
if we are waiting 60 seconds
then shutting down randomly
become a bigger issue
as you just lost a minute of data
Sander Rijken
@srijken
other thing.. I think .Send() needs to be wrapped in a try{} catch{}?
Eric J. Smith
@ejsmith
it should send before dispose
which will put them in the queue
if they have persistent queues… they will be saved.
Sander Rijken
@srijken
you don’t want exceptions to break out of the timer event.. it’ll crash the app hard
Eric J. Smith
@ejsmith
yeah
we have to be super careful to not crash people’s apps. :-)
Blake Niemyjski
@niemyjski
no
they are in memory queues inside of the plugin
and will sit there for up to 1 minute
Eric J. Smith
@ejsmith
yes, I know… but dispose gets called.
Sander Rijken
@srijken
yeah but if you send it from the dispose, you can send it earlier
Blake Niemyjski
@niemyjski
hmm
Eric J. Smith
@ejsmith
it needs to submit any pending in the dispose
Blake Niemyjski
@niemyjski
yeah
Sander Rijken
@srijken
except when dispose doesn’t get called..
Blake Niemyjski
@niemyjski
good call
Sander Rijken
@srijken
but then it just sucks anyway
Eric J. Smith
@ejsmith
in that case we are screwed anyway
Blake Niemyjski
@niemyjski
but will dispose actually get called on shutdown
might be wayyyyy too late
Eric J. Smith
@ejsmith
I think it will be ok… but try it.
and it would be nice if we did a quick benchmark on calling gethashcode on complex events.
Sander Rijken
@srijken
we also need to add that to the testcase to make sure it even works :D
Eric J. Smith
@ejsmith
because there are discussions about making architectural decisions based on this being expensive and I don’t believe in making architectural decisions based on milliseconds. :-)
Sander Rijken
@srijken
and without measuring in the first place
Blake Niemyjski
@niemyjski
yeah
Eric J. Smith
@ejsmith
exactly
Blake Niemyjski
@niemyjski
I’ll add a test to the master branch
and then pull it into this one
I’ll make that a toodo
Sander Rijken
@srijken
ex collegue used to do that.. optimize for optimal reuse (and then it doesn’t get reused), and for optimal speed, when speed isn’t the issue there
Blake Niemyjski
@niemyjski
yeah
I know
I’ll write a test and add some good test cases
Sander Rijken
@srijken
especially the first thing leads to code more complex than necessary
livecodign has delay :) I see the message come in, and then I see you typing it
Eric J. Smith
@ejsmith
drives me insane when people make architectural design decisions based on microbenchmarks.
build for simplicity and maintenance… profile the entire thing and fix the real hotspots.