by

Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 03:01
    houlintao starred exceptionless/Exceptionless
  • 02:23

    ejsmith on master

    Change Slack to Discord (compare)

  • 02:22

    ejsmith on discard-join

    Change Slack to Discord (compare)

  • May 29 06:06
  • May 29 06:06
  • May 28 17:44
    CLAassistant commented #633
  • May 28 17:44

    dependabot-preview[bot] on nuget

    (compare)

  • May 28 17:44
    dependabot-preview[bot] closed #630
  • May 28 17:43
    dependabot-preview[bot] commented #630
  • May 28 17:43
    dependabot-preview[bot] labeled #633
  • May 28 17:43
    dependabot-preview[bot] opened #633
  • May 28 17:43

    dependabot-preview[bot] on nuget

    Bump Stripe.net from 35.9.0 to … (compare)

  • May 28 10:47
    CLAassistant commented #632
  • May 28 10:46

    dependabot-preview[bot] on nuget

    (compare)

  • May 28 10:46
    dependabot-preview[bot] closed #587
  • May 28 10:46
    dependabot-preview[bot] commented #587
  • May 28 10:46
    dependabot-preview[bot] labeled #632
  • May 28 10:46
    dependabot-preview[bot] opened #632
  • May 28 10:46

    dependabot-preview[bot] on nuget

    Bump YamlDotNet from 8.1.0 to 8… (compare)

  • May 28 04:22

    niemyjski on discard-join

    WIP - Event Join Tests (compare)

Sander Rijken
@srijken
except when dispose doesn’t get called..
Blake Niemyjski
@niemyjski
good call
Sander Rijken
@srijken
but then it just sucks anyway
Eric J. Smith
@ejsmith
in that case we are screwed anyway
Blake Niemyjski
@niemyjski
but will dispose actually get called on shutdown
might be wayyyyy too late
Eric J. Smith
@ejsmith
I think it will be ok… but try it.
and it would be nice if we did a quick benchmark on calling gethashcode on complex events.
Sander Rijken
@srijken
we also need to add that to the testcase to make sure it even works :D
Eric J. Smith
@ejsmith
because there are discussions about making architectural decisions based on this being expensive and I don’t believe in making architectural decisions based on milliseconds. :-)
Sander Rijken
@srijken
and without measuring in the first place
Blake Niemyjski
@niemyjski
yeah
Eric J. Smith
@ejsmith
exactly
Blake Niemyjski
@niemyjski
I’ll add a test to the master branch
and then pull it into this one
I’ll make that a toodo
Sander Rijken
@srijken
ex collegue used to do that.. optimize for optimal reuse (and then it doesn’t get reused), and for optimal speed, when speed isn’t the issue there
Blake Niemyjski
@niemyjski
yeah
I know
I’ll write a test and add some good test cases
Sander Rijken
@srijken
especially the first thing leads to code more complex than necessary
livecodign has delay :) I see the message come in, and then I see you typing it
Eric J. Smith
@ejsmith
drives me insane when people make architectural design decisions based on microbenchmarks.
build for simplicity and maintenance… profile the entire thing and fix the real hotspots.
Blake Niemyjski
@niemyjski
you really think I need to do smart timers
lots of extra code for just this that runs every 60 seconds
Eric J. Smith
@ejsmith
probably not
Blake Niemyjski
@niemyjski
kk
sounds good
Eric J. Smith
@ejsmith
its kind of nice to only fire when you need to, but probably not worth it.
Blake Niemyjski
@niemyjski
I’ll commit these changes and we’ll have to test this
yeah
I don’t think it’s worth it
Eric J. Smith
@ejsmith
sounds good.
Blake Niemyjski
@niemyjski
we gotta make sure we don’t use any c# 6 features in this client or it breaks the build
Sander Rijken
@srijken
ah
oh right that thing
Blake Niemyjski
@niemyjski
Any chance you could update all occurrences of ?.
Sander Rijken
@srijken
that sucks.. wish I knew about this
Blake Niemyjski
@niemyjski
yeah :(
Sander Rijken
@srijken
I didn’t see the build turn red either when I committed stuff
brb
Blake Niemyjski
@niemyjski
k
Sander Rijken
@srijken
@niemyjski there’s this R# key you can put in to have that warn about C#6. I’m gonna use that to find all the problems, but maybe you want to have that in there as well?
Blake Niemyjski
@niemyjski
yeah
where can I put that in
should be in the resharper settings for that project
Sander Rijken
@srijken
would be nice if that worked
tried, it came up with them, and then they were gone