Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Apr 06 17:47
  • Apr 06 13:54
    niemyjski commented #559
  • Apr 05 04:55
    gebiWangshushu commented #559
  • Apr 04 22:48
  • Apr 04 22:07
    niemyjski synchronize #561
  • Apr 04 22:07

    niemyjski on discard

    Added Stack Status job (compare)

  • Apr 04 05:58
  • Apr 04 02:05
    CLAassistant commented #570
  • Apr 04 02:05
    dependabot-preview[bot] labeled #570
  • Apr 04 02:05
    dependabot-preview[bot] opened #570
  • Apr 04 02:05

    dependabot-preview[bot] on nuget

    Bump MailKit from 2.5.2 to 2.6.… (compare)

  • Apr 03 20:44
    CLAassistant commented #569
  • Apr 03 20:44

    dependabot-preview[bot] on nuget

    (compare)

  • Apr 03 20:44
    dependabot-preview[bot] closed #565
  • Apr 03 20:44
    dependabot-preview[bot] commented #565
  • Apr 03 20:44
    dependabot-preview[bot] labeled #569
  • Apr 03 20:44
    dependabot-preview[bot] opened #569
  • Apr 03 20:44

    dependabot-preview[bot] on nuget

    Bump Stripe.net from 35.9.0 to … (compare)

  • Apr 03 14:04
    niemyjski commented #188
  • Apr 03 13:16
    niemyjski assigned #188
Eric J. Smith
@ejsmith
build for simplicity and maintenance… profile the entire thing and fix the real hotspots.
Blake Niemyjski
@niemyjski
you really think I need to do smart timers
lots of extra code for just this that runs every 60 seconds
Eric J. Smith
@ejsmith
probably not
Blake Niemyjski
@niemyjski
kk
sounds good
Eric J. Smith
@ejsmith
its kind of nice to only fire when you need to, but probably not worth it.
Blake Niemyjski
@niemyjski
I’ll commit these changes and we’ll have to test this
yeah
I don’t think it’s worth it
Eric J. Smith
@ejsmith
sounds good.
Blake Niemyjski
@niemyjski
we gotta make sure we don’t use any c# 6 features in this client or it breaks the build
Sander Rijken
@srijken
ah
oh right that thing
Blake Niemyjski
@niemyjski
Any chance you could update all occurrences of ?.
Sander Rijken
@srijken
that sucks.. wish I knew about this
Blake Niemyjski
@niemyjski
yeah :(
Sander Rijken
@srijken
I didn’t see the build turn red either when I committed stuff
brb
Blake Niemyjski
@niemyjski
k
Sander Rijken
@srijken
@niemyjski there’s this R# key you can put in to have that warn about C#6. I’m gonna use that to find all the problems, but maybe you want to have that in there as well?
Blake Niemyjski
@niemyjski
yeah
where can I put that in
should be in the resharper settings for that project
Sander Rijken
@srijken
would be nice if that worked
tried, it came up with them, and then they were gone
gotit
properties window of the .Portable project
UGH
the first fix it suggests is “turn on C#6 support"
and there’s no other fix
Frank Ebersoll
@frankebersoll
Had a discussion at work today about performance of string comparisons. Colleagues wanted to do GetHashCode to compare two long strings, but it turned out to be a bad idea: GetHashCode would need to be
...called every time and it takes about 4 times longer than comparing the strings themselves
Sander Rijken
@srijken
makes sense
Frank Ebersoll
@frankebersoll
that's because string comparison and GetHashCode both need to look at every single character, but GetHashCode needs to multiply and xor things.
So, actually it is more costly and doesnt add any performance when used on few instances.
So, maybe we need more than one hashcode? Could we have a fail-fast-hash that only uses few properties?
Sander Rijken
@srijken
no
oh wait like that
hmm
but that makes things more complicated
let’s first measure things
Frank Ebersoll
@frankebersoll
Yes, i dont want to prematurely optimize either.
Just saying, because GetHashCode itself is already trying to be an optimization
Eric J. Smith
@ejsmith
problem is that you need a hash that covers the entire object in order to find matches later
Sander Rijken
@srijken
you could in theory use a quick hash to determine that it’s different for sure
like if the event message is different.. there’s no need to do a full hashcode
Eric J. Smith
@ejsmith
So like have 2 levels of hashes?
Frank Ebersoll
@frankebersoll
Yes, but those could be calculated on demand if the fail-fast-hash matched