Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Blake Niemyjski
@niemyjski
was a few inconsistencies
omfg
they FINALLY fixed the stupid azure portal graphs
where the date ranges would overlay
Blake Niemyjski
@niemyjski
@ejsmith we have a few azure message bus tests failing
Eric J. Smith
@ejsmith
ok
Blake Niemyjski
@niemyjski
can you see if they are failing for you
I’m on a crappy internet right now
and don’t know if it’s latency
Eric J. Smith
@ejsmith
not right now
Blake Niemyjski
@niemyjski
ok
Eric J. Smith
@ejsmith
can take a look with you soon
Blake Niemyjski
@niemyjski
kk
Frank Ebersoll
@frankebersoll
@niemyjski I am doing the refactoring right now
Blake Niemyjski
@niemyjski
cool
thanks
guess it’s time to update haha
Eric J. Smith
@ejsmith
just update to aurelia and call it a day
Blake Niemyjski
@niemyjski
@srijken I’m sorry for taking so long to get to this
but todays your day
exceptionless/Exceptionless.Net#15
how do you feel about a plugin that sits with a really low priority and when it sees an aggregate exception it does two things..
cancels it, and calls flatten on it and submits x new events per exception
Eric J. Smith
@ejsmith
I think that would work.
Blake Niemyjski
@niemyjski
ok
I’m going to work on that.. for simple errors (just the pcl client) there isn’t anything we can do
because it doesn’t have the aggregateexception type
unless we used reflection..
would be so nice to bump our minimum versions to 4.5.2
since thats the only thing that’s supported by microosft.
btw
probably has agg exception in the latest profiles
Blake Niemyjski
@niemyjski
exceptionless/Exceptionless.JavaScript@d678bc2
ok
another issue down
@frankebersoll we need to test that and local storage and push a minor release :)
let me know when ever you get the refactor done and I’ll test it
in the mean time I’m going to go work on the aggregate exception issue
@ejsmith @srijken can you both look at this and let me know if there is anything else we need to do for it other than test exceptionless/Exceptionless.Net#71
wait now I remember I wrote down a task to write some perf tests in master
and merge them in so I could see before and after as well as add some good test data
sigh
Blake Niemyjski
@niemyjski
[Priority(15)]
public class HandleAggregateExceptionsPlugin : IEventPlugin {
    public void Run(EventPluginContext context) {
        var aggregateException = context.ContextData.GetException() as AggregateException;
        if (aggregateException == null)
            return;

        var exception = aggregateException.Flatten();
        if (exception.InnerExceptions.Count == 1) {
            context.ContextData.SetException(exception.InnerException);
            return;
        }

        foreach (var ex in exception.InnerExceptions) {
            // copy entire context;
            // submit event again..
        }

        context.Cancel = true;
    }
}
Blake Niemyjski
@niemyjski
we have nothing for cloning an event
guess I could serialize it and then deserialize it
public void Run(EventPluginContext context) {
var aggregateException = context.ContextData.GetException() as AggregateException;
if (aggregateException == null)
return;
        var exception = aggregateException.Flatten();
        if (exception.InnerExceptions.Count == 1) {
            context.ContextData.SetException(exception.InnerException);
            return;
        }

        foreach (var ex in exception.InnerExceptions) {
            var ctx = new ContextData(context.ContextData);
            ctx.SetException(ex);

            var serializer = context.Resolver.GetJsonSerializer();
            context.Client.SubmitEvent(serializer.Deserialize(serializer.Serialize(context.Event), typeof(Event)) as Event, ctx);
        }

        context.Cancel = true;
    }
That stinks but I don’t want to have a reference to anything as the message could be changed per event type
Frank Ebersoll
@frankebersoll
@niemyjski Refactoring done, merged your code.
Blake Niemyjski
@niemyjski
exceptionless/Exceptionless.Net@9dee17a