Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 14:07
    niemyjski commented #472
  • 07:50
    alvin-su opened #472
  • 01:35
    niemyjski synchronize #452
  • 01:35

    niemyjski on elastic7

    Only put consumes attribute on … (compare)

  • Dec 14 16:39
    ejsmith synchronize #452
  • Dec 14 16:39

    ejsmith on elastic7

    Log the correct task id and cat… (compare)

  • Dec 14 06:25
    ejsmith synchronize #452
  • Dec 14 06:25

    ejsmith on elastic7

    Minor (compare)

  • Dec 14 06:00
    ejsmith synchronize #452
  • Dec 14 06:00

    ejsmith on elastic7

    Add missing task id (compare)

  • Dec 13 22:43
    ejsmith synchronize #452
  • Dec 13 22:43

    ejsmith on elastic7

    More reindex job changes (compare)

  • Dec 13 15:46
    ejsmith synchronize #452
  • Dec 13 15:46

    ejsmith on elastic7

    Just retry 3 times (compare)

  • Dec 13 15:44
    ejsmith synchronize #452
  • Dec 13 15:44

    ejsmith on elastic7

    More log message changes (compare)

  • Dec 13 14:25
    niemyjski synchronize #452
  • Dec 13 14:25

    niemyjski on elastic7

    Added retry reindex for disconn… (compare)

  • Dec 13 14:09
    niemyjski synchronize #452
  • Dec 13 14:09

    niemyjski on elastic7

    Updated migration to retry sock… (compare)

Blake Niemyjski
@niemyjski
@frankebersoll we need to test that and local storage and push a minor release :)
let me know when ever you get the refactor done and I’ll test it
in the mean time I’m going to go work on the aggregate exception issue
@ejsmith @srijken can you both look at this and let me know if there is anything else we need to do for it other than test exceptionless/Exceptionless.Net#71
wait now I remember I wrote down a task to write some perf tests in master
and merge them in so I could see before and after as well as add some good test data
sigh
Blake Niemyjski
@niemyjski
[Priority(15)]
public class HandleAggregateExceptionsPlugin : IEventPlugin {
    public void Run(EventPluginContext context) {
        var aggregateException = context.ContextData.GetException() as AggregateException;
        if (aggregateException == null)
            return;

        var exception = aggregateException.Flatten();
        if (exception.InnerExceptions.Count == 1) {
            context.ContextData.SetException(exception.InnerException);
            return;
        }

        foreach (var ex in exception.InnerExceptions) {
            // copy entire context;
            // submit event again..
        }

        context.Cancel = true;
    }
}
Blake Niemyjski
@niemyjski
we have nothing for cloning an event
guess I could serialize it and then deserialize it
public void Run(EventPluginContext context) {
var aggregateException = context.ContextData.GetException() as AggregateException;
if (aggregateException == null)
return;
        var exception = aggregateException.Flatten();
        if (exception.InnerExceptions.Count == 1) {
            context.ContextData.SetException(exception.InnerException);
            return;
        }

        foreach (var ex in exception.InnerExceptions) {
            var ctx = new ContextData(context.ContextData);
            ctx.SetException(ex);

            var serializer = context.Resolver.GetJsonSerializer();
            context.Client.SubmitEvent(serializer.Deserialize(serializer.Serialize(context.Event), typeof(Event)) as Event, ctx);
        }

        context.Cancel = true;
    }
That stinks but I don’t want to have a reference to anything as the message could be changed per event type
Frank Ebersoll
@frankebersoll
@niemyjski Refactoring done, merged your code.
Blake Niemyjski
@niemyjski
exceptionless/Exceptionless.Net@9dee17a
awesome :D
@frankebersoll I’ll test it out
Frank Ebersoll
@frankebersoll
Todd is doing awesome work right now.
ToddThomson/tsproject#71
ToddThomson/tsproject#74
Blake Niemyjski
@niemyjski
Sawweet
Frank Ebersoll
@frankebersoll
trying to push the source map thing a little. I have source map issues in another project that uses coffee script, so I will delve into that topic now.
first thing will be understanding how the debugging protocol of node works and how it can be sniffed
maybe this will help in pinpointing problems where breakpoints do not work because the source maps are not right
i really hate not being able to break into code.
Eric J. Smith
@ejsmith
Yeah, seems like source maps don't quite work right.
I have yet to see a transpiler that makes them work perfectly.
Frank Ebersoll
@frankebersoll
typescript itself does.
Eric J. Smith
@ejsmith
Not sure if that is a limitation of the transpilers or of source maps themselves.
So if you just go directly through typescript they work good?
Frank Ebersoll
@frankebersoll
usually it’s a problem of having the paths mapped incorrectly
Eric J. Smith
@ejsmith
In my other app we are going through typescript and then Babel due to issues with typescript.
Frank Ebersoll
@frankebersoll
each sourcemap points back to its original source file, while itself is kept nearby the output file
Eric J. Smith
@ejsmith
Hoping that typescript will resolve those issues soon and we can skip the Babel step.
Frank Ebersoll
@frankebersoll
but this pointer must be an absolute path or a relative path that works
Eric J. Smith
@ejsmith
Yeah
Frank Ebersoll
@frankebersoll
and usually, gulp-sourcemap isn’t configured to put the right paths there
so the debugger won’t find the sources.
Sander Rijken
@srijken
I also had problems where source maps do work, but especially chrome caches them. Anyone seen that before? It feels strange to revert to IE because (part of) debugging is better :)
Blake Niemyjski
@niemyjski
I usually turn on the disable cache checkbox in chrome
Blake Niemyjski
@niemyjski
Eric J. Smith
@ejsmith
Probably should just map it to a simple error?
Since it's more similar to that. Then eventually we can implement the simple error parser.
Blake Niemyjski
@niemyjski
yeah
not a bad idea
because they have different languages going to it
Eric J. Smith
@ejsmith
Yeah
Blake Niemyjski
@niemyjski
@skoub, for simple errors just look at the SimpleError known data key and then the stack trace is just a string :)
Jamie Clarke
@jamie94bc
@niemyjski any chance the settings base class in Exceptionless could become part of Foundatio? Seems like something most projects end up with!
Eric J. Smith
@ejsmith
@jamie94bc yeah, we were talking about that the other day. The problem is that in .net core the configuration stuff they have is better. I kind of don't want to include things that will be covered by the framework. What are your thoughts?