well.. noise..
if you like it merge it :)
We can review my stats stuff
and other pull request stuff :)
Maybe I should look into finishing the one time job stuff
Get key needs the context
cachelockprovider
and you pass that to GetKey()
cache lives as long as required?
it should live for a really long time, but it’s not guaranteed.
public override Task<ILock> GetWorkItemLockAsync(object workItem, CancellationToken cancellationToken = new CancellationToken()) {
var cacheKey = $"{nameof(RemoveOrganizationWorkItemHandler)}:{((RemoveOrganizationWorkItem)workItem).OrganizationId}";
return _lockProvider.AcquireAsync(cacheKey, TimeSpan.FromMinutes(15), new CancellationToken(true));
}
guess it could just be a shortcut that just calls GetKey for you in the GetWorkItemLock
could make these a lot more easier to use if we put a generic on workitemhandler<WorkItemHandlerBase>
but that might make other things harder todo..
huh?
I think the idea should be that 1 time means 1 time… meaning we set a key that doesn’t expire for like 24 hours or something.
so just do a throttling lock provider for 1 hit every 24 hours
should keep it from happening again.
kind of feel like we should make people implement that themselves.
because 1 time sounds like its gauranteeing more than just thottling it for 24 hours.
and it’s really not saving much.
heading to gym
to me
one time means the job is ran one time
once it’s ran it can run again
and putting a lock for 24 hours
and they aren’t saving much work over doing the lock themselves.