Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Jan 18 19:42
    claassistantio commented #484
  • Jan 18 19:42
    dependabot-preview[bot] labeled #484
  • Jan 18 19:42
    dependabot-preview[bot] opened #484
  • Jan 18 19:42

    dependabot-preview[bot] on nuget

    Bump YamlDotNet from 8.0.0 to 8… (compare)

  • Jan 18 01:05
  • Jan 17 23:05
    claassistantio commented #483
  • Jan 17 23:04
    dependabot-preview[bot] labeled #483
  • Jan 17 23:04
    dependabot-preview[bot] opened #483
  • Jan 17 23:04

    dependabot-preview[bot] on nuget

    Bump Stripe.net from 34.15.0 to… (compare)

  • Jan 17 14:45
    ChiefLegend commented #477
  • Jan 17 14:17
    niemyjski commented #477
  • Jan 17 03:18

    niemyjski on master

    Updates to latest stable founda… (compare)

  • Jan 17 03:06

    dependabot-preview[bot] on nuget

    (compare)

  • Jan 17 03:06

    niemyjski on master

    Bump Microsoft.Extensions.Loggi… Merge pull request #481 from ex… (compare)

  • Jan 17 03:06
    niemyjski closed #481
  • Jan 17 03:06
    dependabot-preview[bot] synchronize #481
  • Jan 17 03:06

    dependabot-preview[bot] on nuget

    Bump Microsoft.Extensions.Loggi… (compare)

  • Jan 17 03:06
    dependabot-preview[bot] edited #481
  • Jan 17 03:05
    claassistantio commented #479
  • Jan 17 03:05
    dependabot-preview[bot] edited #481
Blake Niemyjski
@niemyjski
cache lives as long as required?
Eric J. Smith
@ejsmith
probably
it should live for a really long time, but it’s not guaranteed.
Blake Niemyjski
@niemyjski
    public override Task<ILock> GetWorkItemLockAsync(object workItem, CancellationToken cancellationToken = new CancellationToken()) {
        var cacheKey = $"{nameof(RemoveOrganizationWorkItemHandler)}:{((RemoveOrganizationWorkItem)workItem).OrganizationId}";
        return _lockProvider.AcquireAsync(cacheKey, TimeSpan.FromMinutes(15), new CancellationToken(true));
    }
Eric J. Smith
@ejsmith
I’m not sure how the 1 time work item handler would be different than just adding the getworkitemlock
guess it could just be a shortcut that just calls GetKey for you in the GetWorkItemLock
Blake Niemyjski
@niemyjski
yeah
could make these a lot more easier to use if we put a generic on workitemhandler<WorkItemHandlerBase>
but that might make other things harder todo..
Eric J. Smith
@ejsmith
how long would we hold the lock for?
huh?
Blake Niemyjski
@niemyjski
15 minutes or until we release it or renew it
Eric J. Smith
@ejsmith
that isn’t really 1 time.
I think the idea should be that 1 time means 1 time… meaning we set a key that doesn’t expire for like 24 hours or something.
so just do a throttling lock provider for 1 hit every 24 hours
should keep it from happening again.
kind of feel like we should make people implement that themselves.
because 1 time sounds like its gauranteeing more than just thottling it for 24 hours.
and it’s really not saving much.
Blake Niemyjski
@niemyjski
changes pushed
heading to gym
to me
one time means the job is ran one time
once it’s ran it can run again
Eric J. Smith
@ejsmith
right
and putting a lock for 24 hours
Blake Niemyjski
@niemyjski
like throttleing events on an ip is a one time job that might happen repeatidly
Eric J. Smith
@ejsmith
doesn’t guarantee shit
and they aren’t saving much work over doing the lock themselves.
Blake Niemyjski
@niemyjski
guess there is confusion on what one time job means
Eric J. Smith
@ejsmith
so I say we let them do the lock themseleves.
Blake Niemyjski
@niemyjski
yeah
lets remove it
Eric J. Smith
@ejsmith
ok
do it
Blake Niemyjski
@niemyjski
I agree
simple enough for me to just do this
Eric J. Smith
@ejsmith
yeah
we might add another lock provider that persists the fact that something has run permanantly.
could be useful for running migrations
that should happen 1 time EVER
Blake Niemyjski
@niemyjski
pushed
Eric J. Smith
@ejsmith
ok
Blake Niemyjski
@niemyjski
yeah
:)
ok pr is updated
heading to the gym for an hour
then dinner and I’ll be on
Eric J. Smith
@ejsmith
no tennis, so I might work some tonight.
worked all damn weekend though.