Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Blake Niemyjski
@niemyjski
15 minutes or until we release it or renew it
Eric J. Smith
@ejsmith
that isn’t really 1 time.
I think the idea should be that 1 time means 1 time… meaning we set a key that doesn’t expire for like 24 hours or something.
so just do a throttling lock provider for 1 hit every 24 hours
should keep it from happening again.
kind of feel like we should make people implement that themselves.
because 1 time sounds like its gauranteeing more than just thottling it for 24 hours.
and it’s really not saving much.
Blake Niemyjski
@niemyjski
changes pushed
heading to gym
to me
one time means the job is ran one time
once it’s ran it can run again
Eric J. Smith
@ejsmith
right
and putting a lock for 24 hours
Blake Niemyjski
@niemyjski
like throttleing events on an ip is a one time job that might happen repeatidly
Eric J. Smith
@ejsmith
doesn’t guarantee shit
and they aren’t saving much work over doing the lock themselves.
Blake Niemyjski
@niemyjski
guess there is confusion on what one time job means
Eric J. Smith
@ejsmith
so I say we let them do the lock themseleves.
Blake Niemyjski
@niemyjski
yeah
lets remove it
Eric J. Smith
@ejsmith
ok
do it
Blake Niemyjski
@niemyjski
I agree
simple enough for me to just do this
Eric J. Smith
@ejsmith
yeah
we might add another lock provider that persists the fact that something has run permanantly.
could be useful for running migrations
that should happen 1 time EVER
Blake Niemyjski
@niemyjski
pushed
Eric J. Smith
@ejsmith
ok
Blake Niemyjski
@niemyjski
yeah
:)
ok pr is updated
heading to the gym for an hour
then dinner and I’ll be on
Eric J. Smith
@ejsmith
no tennis, so I might work some tonight.
worked all damn weekend though.
so it’s a maybe.
Blake Niemyjski
@niemyjski
at least review my two pull requests
lets met up for 20 minutes so I can go over the stats stuff
all working :)
Eric J. Smith
@ejsmith
I already commented on 1 of them
updating the logging will be a bitch, but we should get it done.
Blake Niemyjski
@niemyjski
yeah
benmaina
@benmaina
@niemyjski when you are free we can look at the exception not being logged on the dashboard.
Blake Niemyjski
@niemyjski
@benmaina I’m free now
benmaina
@benmaina
can we team view?
Blake Niemyjski
@niemyjski
yeah