Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Blake Niemyjski
@niemyjski
https://github.com/aspnet/Logging/issues/370#issuecomment-190767852
I could drop kick someone over there today…
Eric J. Smith
@ejsmith
I give up.
I don’t think you are helping when you post things on there. I’m sure they know that we work together.
Blake Niemyjski
@niemyjski
and?
I completely agree with you
and that’s how I feel
Eric J. Smith
@ejsmith
of course it is, we work together, we have the same view of things.
Blake Niemyjski
@niemyjski
there are two many developers out there at microsoft who’ve never left there office or ventured into support land
I’m tired of being forced to use something just because one of those guys made that decision
like wake the heck up. over two issues many external people have said they wanted the change
Eric J. Smith
@ejsmith
they think we are being rediculous because we don’t like their method names.
Blake Niemyjski
@niemyjski
we weren’t the only ones
like, when you file a patent you do existing research work.. when you are doing logging for an entire framework you do existing research
Eric J. Smith
@ejsmith
but there are like 100 extension methods that sit on top of ILogger and there is zero reason to include those in the logging contract.
Blake Niemyjski
@niemyjski
existing research would point that no one is doing what you are doing..
or what everyone else is using
too me that is a huge red flag
Eric J. Smith
@ejsmith
I don’t freakin’ care about the Log in the method names.
Blake Niemyjski
@niemyjski
like a few small changes would make it a heck of a lot easier for people to port to it
those shouldn’t be ther
well even that
only the contract
Eric J. Smith
@ejsmith
I want a shared contract that is tiny that has a chance of being broadly accepted.
Blake Niemyjski
@niemyjski
yeah
Eric J. Smith
@ejsmith
ILogger is 1 method
Blake Niemyjski
@niemyjski
if you want those extensions there then put them in a different namespace
or different assembly
Eric J. Smith
@ejsmith
and is proven to be performant
those extension methods have a bunch of dependencies.
now I gotta force those dependencies on my users
when all I freakin’ wanted was to write some simple log messages.
don’t understand why it’s so hard to understand
Blake Niemyjski
@niemyjski
you mean you didn’t want to do install-package logging.kitchensink
Eric J. Smith
@ejsmith
I want to install Foundatio and not have it bring the kitchen sink down with it or force me into using shit I don’t want to use.
Blake Niemyjski
@niemyjski
you know what this reminds me of
Azure/azure-storage-net#97
Eric J. Smith
@ejsmith
so as a lib developer my only choice is to source import the logging code so I don’t force people to use stuff they don’t want to use.
Blake Niemyjski
@niemyjski
omg another microsoft library
lol
Jamie Clarke
@jamie94bc
you guys happy with the PR?
only concern is the overhead of creating another dictionary
Eric J. Smith
@ejsmith
sorry, need to stop venting over here and check it. :-)
Blake Niemyjski
@niemyjski
yeah it looks good
well
actually
that won’t work I don’t think
Eric J. Smith
@ejsmith
the getunscoped could be simpler I think.
Blake Niemyjski
@niemyjski
protected string GetUnscopedCacheKey(string scopedKey) {
int i = scopedKey.IndexOf(':');
        if (-1 < i && i < (scopedKey.Length - 1)) {
            return scopedKey.Substring(i + 1);
        }

        return scopedKey;
    }
yeah