Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 03:08
    lxz-lxz commented #755
  • Oct 25 13:31

    niemyjski on master

    Github Actions Support (compare)

  • Oct 25 13:24

    niemyjski on master

    Update build.yml (compare)

  • Oct 25 13:19

    niemyjski on master

    fixed gulp install (compare)

  • Oct 25 13:18

    niemyjski on master

    Update readme to include action… Merge branch 'master' of ssh://… (compare)

  • Oct 25 13:17

    niemyjski on master

    Enable GitHub Actions (compare)

  • Oct 24 20:57
    GrimblyGorn starred exceptionless/Exceptionless
  • Oct 23 21:53

    niemyjski on v7.0.5

    Fixed unit tests relating to #7… (compare)

  • Oct 23 21:52

    niemyjski on master

    Fixed unit tests relating to #7… (compare)

  • Oct 23 21:40

    niemyjski on v7.0.5

    (compare)

  • Oct 23 21:38

    niemyjski on master

    Fixed Stripe issue with resolvi… (compare)

  • Oct 23 17:59

    ejsmith on master

    More devcontainer updates (compare)

  • Oct 23 16:48

    ejsmith on master

    Update devcontainer (compare)

  • Oct 23 16:17

    ejsmith on master

    Update devcontainer (compare)

  • Oct 23 14:53
    zhangjianxi2008 starred exceptionless/Exceptionless
  • Oct 23 14:37

    ejsmith on master

    Update Dockerfile (compare)

  • Oct 23 14:36

    ejsmith on master

    Update docker-compose.yml (compare)

  • Oct 23 14:35

    ejsmith on master

    Update hosting-samples.sh (compare)

  • Oct 23 13:57
    niemyjski labeled #752
  • Oct 23 13:57
    niemyjski commented #752
Blake Niemyjski
@niemyjski
well even that
only the contract
Eric J. Smith
@ejsmith
I want a shared contract that is tiny that has a chance of being broadly accepted.
Blake Niemyjski
@niemyjski
yeah
Eric J. Smith
@ejsmith
ILogger is 1 method
Blake Niemyjski
@niemyjski
if you want those extensions there then put them in a different namespace
or different assembly
Eric J. Smith
@ejsmith
and is proven to be performant
those extension methods have a bunch of dependencies.
now I gotta force those dependencies on my users
when all I freakin’ wanted was to write some simple log messages.
don’t understand why it’s so hard to understand
Blake Niemyjski
@niemyjski
you mean you didn’t want to do install-package logging.kitchensink
Eric J. Smith
@ejsmith
I want to install Foundatio and not have it bring the kitchen sink down with it or force me into using shit I don’t want to use.
Blake Niemyjski
@niemyjski
you know what this reminds me of
Azure/azure-storage-net#97
Eric J. Smith
@ejsmith
so as a lib developer my only choice is to source import the logging code so I don’t force people to use stuff they don’t want to use.
Blake Niemyjski
@niemyjski
omg another microsoft library
lol
Jamie Clarke
@jamie94bc
you guys happy with the PR?
only concern is the overhead of creating another dictionary
Eric J. Smith
@ejsmith
sorry, need to stop venting over here and check it. :-)
Blake Niemyjski
@niemyjski
yeah it looks good
well
actually
that won’t work I don’t think
Eric J. Smith
@ejsmith
the getunscoped could be simpler I think.
Blake Niemyjski
@niemyjski
protected string GetUnscopedCacheKey(string scopedKey) {
int i = scopedKey.IndexOf(':');
        if (-1 < i && i < (scopedKey.Length - 1)) {
            return scopedKey.Substring(i + 1);
        }

        return scopedKey;
    }
yeah
it should look at the Scope property which has the scope
Eric J. Smith
@ejsmith
just do Substring(Scope.Length + 1)
Blake Niemyjski
@niemyjski
because the passed in scope could have :a:b:c:
yeah
Jamie Clarke
@jamie94bc
yeah that's why i was looking for the first index
Blake Niemyjski
@niemyjski
so
Eric J. Smith
@ejsmith
but your scanning the keys when you know what the scope is.
Blake Niemyjski
@niemyjski
we should also add a null check to the constuctor and do
Jamie Clarke
@jamie94bc
but that's easier! :)
Blake Niemyjski
@niemyjski
Scope = scope?.Trim() ?? String.Empty
might be null currently
Eric J. Smith
@ejsmith
not sure if we should even allow it to be created without a scope.
Blake Niemyjski
@niemyjski
guess we probably should throw an argument exception if you try using a scoped cache client with no scope
yeah
Eric J. Smith
@ejsmith
I guess you might have some conditional code that may or may not want to use a scope.
Blake Niemyjski
@niemyjski
other than that it looks good :)
guess we found multiple bugs with the scoped cache client today hehee
Blake Niemyjski
@niemyjski
LOL
Eric J. Smith
@ejsmith
I think we should create a private var that has the scope prefix in it including the “:"
Blake Niemyjski
@niemyjski
yeah