Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Sep 20 13:20

    niemyjski on elastic7

    Fixed more unit tests (compare)

  • Sep 20 12:11
    niemyjski commented #447
  • Sep 20 07:42
    ZhiqiangTao commented #447
  • Sep 19 22:56

    niemyjski on elastic7

    bumped major and deps (fixed te… (compare)

  • Sep 19 14:20

    niemyjski on elastic7

    Fixed all issues with the event… (compare)

  • Sep 19 07:04
  • Sep 19 04:49
  • Sep 19 03:32
  • Sep 18 12:46
    LydellM commented #448
  • Sep 18 12:38
    niemyjski labeled #448
  • Sep 18 12:37
    niemyjski closed #448
  • Sep 18 12:37
    niemyjski commented #448
  • Sep 18 12:37
    niemyjski commented #448
  • Sep 18 12:35
    niemyjski commented #447
  • Sep 18 07:09
    ZhiqiangTao closed #447
  • Sep 18 05:31
    leehomlee starred exceptionless/Exceptionless
  • Sep 18 03:17
  • Sep 18 02:13

    niemyjski on elastic7

    More ES7 Changes (compare)

  • Sep 17 20:34
    LydellM opened #448
  • Sep 17 14:43
Eric J. Smith
@ejsmith
now I gotta force those dependencies on my users
when all I freakin’ wanted was to write some simple log messages.
don’t understand why it’s so hard to understand
Blake Niemyjski
@niemyjski
you mean you didn’t want to do install-package logging.kitchensink
Eric J. Smith
@ejsmith
I want to install Foundatio and not have it bring the kitchen sink down with it or force me into using shit I don’t want to use.
Blake Niemyjski
@niemyjski
you know what this reminds me of
Azure/azure-storage-net#97
Eric J. Smith
@ejsmith
so as a lib developer my only choice is to source import the logging code so I don’t force people to use stuff they don’t want to use.
Blake Niemyjski
@niemyjski
omg another microsoft library
lol
Jamie Clarke
@jamie94bc
you guys happy with the PR?
only concern is the overhead of creating another dictionary
Eric J. Smith
@ejsmith
sorry, need to stop venting over here and check it. :-)
Blake Niemyjski
@niemyjski
yeah it looks good
well
actually
that won’t work I don’t think
Eric J. Smith
@ejsmith
the getunscoped could be simpler I think.
Blake Niemyjski
@niemyjski
protected string GetUnscopedCacheKey(string scopedKey) {
int i = scopedKey.IndexOf(':');
        if (-1 < i && i < (scopedKey.Length - 1)) {
            return scopedKey.Substring(i + 1);
        }

        return scopedKey;
    }
yeah
it should look at the Scope property which has the scope
Eric J. Smith
@ejsmith
just do Substring(Scope.Length + 1)
Blake Niemyjski
@niemyjski
because the passed in scope could have :a:b:c:
yeah
Jamie Clarke
@jamie94bc
yeah that's why i was looking for the first index
Blake Niemyjski
@niemyjski
so
Eric J. Smith
@ejsmith
but your scanning the keys when you know what the scope is.
Blake Niemyjski
@niemyjski
we should also add a null check to the constuctor and do
Jamie Clarke
@jamie94bc
but that's easier! :)
Blake Niemyjski
@niemyjski
Scope = scope?.Trim() ?? String.Empty
might be null currently
Eric J. Smith
@ejsmith
not sure if we should even allow it to be created without a scope.
Blake Niemyjski
@niemyjski
guess we probably should throw an argument exception if you try using a scoped cache client with no scope
yeah
Eric J. Smith
@ejsmith
I guess you might have some conditional code that may or may not want to use a scope.
Blake Niemyjski
@niemyjski
other than that it looks good :)
guess we found multiple bugs with the scoped cache client today hehee
Blake Niemyjski
@niemyjski
LOL
Eric J. Smith
@ejsmith
I think we should create a private var that has the scope prefix in it including the “:"
Blake Niemyjski
@niemyjski
yeah
would cut down on allocations
Eric J. Smith
@ejsmith
and if they pass in null or empty string then we just set it to string.emptu
yeah and less concats
Blake Niemyjski
@niemyjski
question… are there ever any invalid strings that cause issues on redis for keys?
know we probably don’t want to add any overhead but curious
Jamie Clarke
@jamie94bc
done :)
Jamie Clarke
@jamie94bc
ah Foundatio.Tests.Caching.HybridCacheClientTests.WillExpireRemoteItems failed
doesn't look related though
:confused: