Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 14:57
  • Sep 30 17:16
    daleholborow starred exceptionless/Exceptionless
  • Sep 30 13:31
    dreammaster38 starred exceptionless/Exceptionless
  • Sep 30 07:52
    glaidler commented #90
  • Sep 29 15:07

    niemyjski on master

    Update README.md (compare)

  • Sep 29 15:07

    niemyjski on master

    Update README.md (compare)

  • Sep 29 15:06

    niemyjski on master

    Update README.md (compare)

  • Sep 29 15:05

    niemyjski on master

    Update README.md (compare)

  • Sep 29 13:57
    ejsmith edited #734
  • Sep 29 13:56
    ejsmith opened #734
  • Sep 29 13:36
    niemyjski commented #90
  • Sep 29 13:36
    niemyjski labeled #90
  • Sep 29 13:36
    niemyjski commented #90
  • Sep 29 13:34
    niemyjski labeled #90
  • Sep 29 13:34
    niemyjski labeled #90
  • Sep 29 13:34
    niemyjski transferred #732
  • Sep 29 13:34
    glaidler opened #90
  • Sep 29 13:34
    niemyjski closed #723
  • Sep 29 13:34
    niemyjski commented #723
  • Sep 29 13:32
    niemyjski commented on f4ba244
Blake Niemyjski
@niemyjski
actually
that won’t work I don’t think
Eric J. Smith
@ejsmith
the getunscoped could be simpler I think.
Blake Niemyjski
@niemyjski
protected string GetUnscopedCacheKey(string scopedKey) {
int i = scopedKey.IndexOf(':');
        if (-1 < i && i < (scopedKey.Length - 1)) {
            return scopedKey.Substring(i + 1);
        }

        return scopedKey;
    }
yeah
it should look at the Scope property which has the scope
Eric J. Smith
@ejsmith
just do Substring(Scope.Length + 1)
Blake Niemyjski
@niemyjski
because the passed in scope could have :a:b:c:
yeah
Jamie Clarke
@jamie94bc
yeah that's why i was looking for the first index
Blake Niemyjski
@niemyjski
so
Eric J. Smith
@ejsmith
but your scanning the keys when you know what the scope is.
Blake Niemyjski
@niemyjski
we should also add a null check to the constuctor and do
Jamie Clarke
@jamie94bc
but that's easier! :)
Blake Niemyjski
@niemyjski
Scope = scope?.Trim() ?? String.Empty
might be null currently
Eric J. Smith
@ejsmith
not sure if we should even allow it to be created without a scope.
Blake Niemyjski
@niemyjski
guess we probably should throw an argument exception if you try using a scoped cache client with no scope
yeah
Eric J. Smith
@ejsmith
I guess you might have some conditional code that may or may not want to use a scope.
Blake Niemyjski
@niemyjski
other than that it looks good :)
guess we found multiple bugs with the scoped cache client today hehee
Blake Niemyjski
@niemyjski
LOL
Eric J. Smith
@ejsmith
I think we should create a private var that has the scope prefix in it including the “:"
Blake Niemyjski
@niemyjski
yeah
would cut down on allocations
Eric J. Smith
@ejsmith
and if they pass in null or empty string then we just set it to string.emptu
yeah and less concats
Blake Niemyjski
@niemyjski
question… are there ever any invalid strings that cause issues on redis for keys?
know we probably don’t want to add any overhead but curious
Jamie Clarke
@jamie94bc
done :)
Jamie Clarke
@jamie94bc
ah Foundatio.Tests.Caching.HybridCacheClientTests.WillExpireRemoteItems failed
doesn't look related though
:confused:
Blake Niemyjski
@niemyjski
:(
Jamie Clarke
@jamie94bc
appveyor built it twice
passed on "master", failed on the branch it's actually on
so just a dodgy test
Blake Niemyjski
@niemyjski
L(
wish we could get rock solid tests
Jamie Clarke
@jamie94bc
would be nice!
Blake Niemyjski
@niemyjski
looks good
just added a quick comment
just came across that for pandora :)
now I only need to run chrome for debugging js
and it’s oss
Blake Niemyjski
@niemyjski
I just added a comment that I think we should trim the scope and check for isnullorwhitespace
then ship it