Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Eric J. Smith
@ejsmith
I think we should create a private var that has the scope prefix in it including the “:"
Blake Niemyjski
@niemyjski
yeah
would cut down on allocations
Eric J. Smith
@ejsmith
and if they pass in null or empty string then we just set it to string.emptu
yeah and less concats
Blake Niemyjski
@niemyjski
question… are there ever any invalid strings that cause issues on redis for keys?
know we probably don’t want to add any overhead but curious
Jamie Clarke
@jamie94bc
done :)
Jamie Clarke
@jamie94bc
ah Foundatio.Tests.Caching.HybridCacheClientTests.WillExpireRemoteItems failed
doesn't look related though
:confused:
Blake Niemyjski
@niemyjski
:(
Jamie Clarke
@jamie94bc
appveyor built it twice
passed on "master", failed on the branch it's actually on
so just a dodgy test
Blake Niemyjski
@niemyjski
L(
wish we could get rock solid tests
Jamie Clarke
@jamie94bc
would be nice!
Blake Niemyjski
@niemyjski
looks good
just added a quick comment
just came across that for pandora :)
now I only need to run chrome for debugging js
and it’s oss
Blake Niemyjski
@niemyjski
I just added a comment that I think we should trim the scope and check for isnullorwhitespace
then ship it
if we apply it to the Check to Scope then we could use that for the key prefix and they’d be in sync
Scope = !String.IsNullOrWhitespace(scope) ? scope.Trim() : String.Empty;
_keyPrefix = String.Concat(Scope, ":");
crap, still doesn’t fix it where your keyprefix could just be :
are we fine with it just being :
I’d personally not have a : if it’s empty or null
Jamie Clarke
@jamie94bc
Scope = !String.IsNullOrWhiteSpace(scope) ? scope.Trim() : null;

            _keyPrefix = scope != null ? String.Concat(scope, ":") : String.Empty;
Blake Niemyjski
@niemyjski
yeah on the bottom one use Scope
because it’s already been trimmed
or null
Jamie Clarke
@jamie94bc
oh yeah haha :)
Blake Niemyjski
@niemyjski
then ship it :)
Jamie Clarke
@jamie94bc
damn casing - this is why i tend to use this.
but i tried not to since to match your coding style
Blake Niemyjski
@niemyjski
hehe yeah
I don’t think we ever use this.
nice find on that :)
Jamie Clarke
@jamie94bc
yeah - was getting some logs that didn't make sense!
Blake Niemyjski
@niemyjski
:)
Blake Niemyjski
@niemyjski
@frankebersoll have you ever saw this with bower
bower exceptionless#1.3.2 install exceptionless#1.3.2
bower skipped exceptionless was not installed because there is already a non-bower directory with that name in the components directory (bower_components/exceptionless). You can force installation with --force.
I’ve always installed it via bower
so not sure why I get that
Eric J. Smith
@ejsmith
so another flakey test?
Jamie Clarke
@jamie94bc
yeah!