Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 14:55
    ejsmith synchronize #452
  • 14:55

    ejsmith on elastic7

    Update appveyor.yml (compare)

  • 14:42
    niemyjski synchronize #452
  • 14:42

    niemyjski on elastic7

    Updated to elasticsearch 7.4.1 (compare)

  • 12:21
    niemyjski synchronize #452
  • 12:21

    niemyjski on elastic7

    WIP - Added migration job to mi… (compare)

  • 11:34
    niemyjski labeled #462
  • 11:34
    niemyjski commented #462
  • 11:34
    niemyjski commented #461
  • 02:09
    kfj1688 opened #462
  • 01:42
    BrisWhite commented #461
  • Oct 22 13:52
    niemyjski labeled #461
  • Oct 22 13:52
    niemyjski commented #461
  • Oct 22 13:35
    niemyjski synchronize #452
  • Oct 22 13:35

    niemyjski on elastic7

    Moved migration job (compare)

  • Oct 22 12:32
    niemyjski synchronize #452
  • Oct 22 12:32

    niemyjski on elastic7

    Added migration job (compare)

  • Oct 22 12:09
    niemyjski synchronize #452
  • Oct 22 12:09

    niemyjski on elastic7

    Fixed tests (compare)

  • Oct 22 09:50
Blake Niemyjski
@niemyjski
I just added a comment that I think we should trim the scope and check for isnullorwhitespace
then ship it
if we apply it to the Check to Scope then we could use that for the key prefix and they’d be in sync
Scope = !String.IsNullOrWhitespace(scope) ? scope.Trim() : String.Empty;
_keyPrefix = String.Concat(Scope, ":");
crap, still doesn’t fix it where your keyprefix could just be :
are we fine with it just being :
I’d personally not have a : if it’s empty or null
Jamie Clarke
@jamie94bc
Scope = !String.IsNullOrWhiteSpace(scope) ? scope.Trim() : null;

            _keyPrefix = scope != null ? String.Concat(scope, ":") : String.Empty;
Blake Niemyjski
@niemyjski
yeah on the bottom one use Scope
because it’s already been trimmed
or null
Jamie Clarke
@jamie94bc
oh yeah haha :)
Blake Niemyjski
@niemyjski
then ship it :)
Jamie Clarke
@jamie94bc
damn casing - this is why i tend to use this.
but i tried not to since to match your coding style
Blake Niemyjski
@niemyjski
hehe yeah
I don’t think we ever use this.
nice find on that :)
Jamie Clarke
@jamie94bc
yeah - was getting some logs that didn't make sense!
Blake Niemyjski
@niemyjski
:)
Blake Niemyjski
@niemyjski
@frankebersoll have you ever saw this with bower
bower exceptionless#1.3.2 install exceptionless#1.3.2
bower skipped exceptionless was not installed because there is already a non-bower directory with that name in the components directory (bower_components/exceptionless). You can force installation with --force.
I’ve always installed it via bower
so not sure why I get that
Eric J. Smith
@ejsmith
so another flakey test?
Jamie Clarke
@jamie94bc
yeah!
Eric J. Smith
@ejsmith
yay
at least the logging helps a lot for tracking those down.
Blake Niemyjski
@niemyjski
just thought of something
var valueMap = new Dictionary<string, CacheValue<T>>();
we could put the old dictionary length in the constructor so if it’s a huge existing dictionary we won’t be changing the size internally every 2^nth
Eric J. Smith
@ejsmith
where is that for?
Blake Niemyjski
@niemyjski
in the scoped cache client
I’m going to make that change real quick
Eric J. Smith
@ejsmith
that only works for in memory implementations, no?
Blake Niemyjski
@niemyjski
no
all of them
hmm
ToDictionary overload doesn’t look at the count
when creating it
Eric J. Smith
@ejsmith
how would you know how many items are in reds?
redis
Blake Niemyjski
@niemyjski
it does a getall
and then iterates over that..
Eric J. Smith
@ejsmith
huh???
Blake Niemyjski
@niemyjski
    public async Task<IDictionary<string, CacheValue<T>>> GetAllAsync<T>(IEnumerable<string> keys) {
        var scopedDictionary = await UnscopedCache.GetAllAsync<T>(GetScopedCacheKeys(keys)).AnyContext();
        return scopedDictionary.ToDictionary(kvp => UnscopeCacheKey(kvp.Key), kvp => kvp.Value);
    }
Eric J. Smith
@ejsmith
ohhh
the getall method
Blake Niemyjski
@niemyjski
hmm
Eric J. Smith
@ejsmith
you really think someone is calling that with that many items?