Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Blake Niemyjski
@niemyjski
feel so much better now that the ui build deployment issue is fixed (where the build was failing on pr’s)
Eric J. Smith
@ejsmith
cool
you fix that today?
Eric J. Smith
@ejsmith
@niemyjski I think the user count for the project isn’t taking the date filter into account. I think it’s using the total count of users for the project. Trying to think what makes sense. I think if you are looking at the last 7 days, then you want to see what percentage of users that visited in that timeframe got an error.
right now it’s showing you the percent of total users for the project over all time.
Blake Niemyjski
@niemyjski
Yes it's what we decided
All time users within your retention
We want to cache user accounts
Eric J. Smith
@ejsmith
Yeah, but looking at it. I don't think it's intuitive. And don't think it's what you want to see.
Blake Niemyjski
@niemyjski
Well
Eric J. Smith
@ejsmith
I am probably going to keep my filter at 7 days or something.
Blake Niemyjski
@niemyjski
Yeah
Eric J. Smith
@ejsmith
I want to see what percent of users were affected by an issue in that timeframe
Blake Niemyjski
@niemyjski
Yeah
Eric J. Smith
@ejsmith
I know it's more expensive, but I think it's what people want.
I'm trying to think if you would even want to see the total user count.
I don't think you would.
Bill Henning
@BillHenning
Go with filtered date range.
Especially now that the date range, etc. is all front and center on the header.
Eric J. Smith
@ejsmith
Think about some free trial app. Getting tons of throw away users.
Bill can you think of any reason to want to see the percent of total users ever?
If I want percent of total users then I should select all time.
Bill Henning
@BillHenning
Can't I just flip to All Time to see that?
Eric J. Smith
@ejsmith
Yeah
Bill Henning
@BillHenning
There's your answer. :)
Eric J. Smith
@ejsmith
Sessions is interesting though.
Bill Henning
@BillHenning
You mean how my people have like 80% sessions?
Eric J. Smith
@ejsmith
Seeing 100% on that all the time is useless. But seeing what percent of the total users logged in in this time range is interesting.
Bill Henning
@BillHenning
Yeah it feels wrong... should really be 100%.
Eric J. Smith
@ejsmith
But we can't special case it
Blake Niemyjski
@niemyjski
I guess we can ever cash that and we have to query that everything
❤️ Siri
Eric J. Smith
@ejsmith
We can cache it by the time filter I think we would get hits on that because they are going to switch vuews
It would only be for a short time
Blake Niemyjski
@niemyjski
ok
but not sure how that would work
because the time filter: last 7 days
gets translated into a time range that changes all the time
Sander Rijken
@srijken

Think we can use exceptionless to collect these?
https://www.veracode.com/blog/2014/03/guidelines-for-setting-security-headers

https://bugs.webkit.org/show_bug.cgi?id=100892
The report is JSON and is generated using the same facility as for the X-WebKit-CSP-Report-Only header. A sample might be:

    { "xss-report": {
        "request-url": "http://example.com/vulnerable-page?q=<script>alert(/xss/)</script>",
        "request-body": ""
    }}
could be useful for other report endpoints that are specified in headers
Eric J. Smith
@ejsmith
@niemyjski yeah, gotta figure out a way to keep the cache key steady, eh?
@srijken you want to add them to the events?
Blake Niemyjski
@niemyjski
@ejsmith yeah, and I don’t think it’s possible
Matt Oswald
@moswald
I'm going to update my PR this morning - should I just remove the old constructor that I marked as Obsolete?
Eric J. Smith
@ejsmith
@moswald we have been bad about making breaking changes.
My justification is that I am waiting for the library to be more popular before I worry about them too much.
Matt Oswald
@moswald
:+1:
works for me
Eric J. Smith
@ejsmith
might be a dumb justification. :-)