Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Eric J. Smith
@ejsmith
with the TFMs
Blake Niemyjski
@niemyjski
yeah
TFM?
Matt Oswald
@moswald
hey guys, I've been out of town for the past three days and didn't really get to read much on the PR I submitted
Blake Niemyjski
@niemyjski
It’s all good :)
Matt Oswald
@moswald
based on the feedback, I wonder if I should abandon it and let you guys discuss further, it seems like maybe you have larger plans
Blake Niemyjski
@niemyjski
no pressure over here, we know you guys work on this in your free time and it’s greatly appreciated
Blake Niemyjski
@niemyjski
Yeah, I think it was good to take a stab at it. I think there just needs to be some discussion around it.
We know we need to do it, just what’s the best way long term.
Eric J. Smith
@ejsmith
@moswald yeah, we are just trying to figure out what the best approach is and you got the discussion started and I think that is awesome. I think we just need to iterate from there.
we just want to make sure that we come up with a solution that we all agree with.
Matt Oswald
@moswald
roger that - I'm just here to help ;)
Blake Niemyjski
@niemyjski
That’s greatly appreciated
I’m testing the .net client for release and then I’ll take a look at the pr and add some feedback
I saw that there was activity on it this weekend I just was busy with family
@srijken seems to be working really good :D
@ejsmith when I get this user stuff done
I’m adding the ability to view the raw event json
I need it like every day
Blake Niemyjski
@niemyjski
Screen Shot 2016-04-11 at 11.04.35 AM.png
@srijken I’m taking a look into this
seems like when I click between two different errors multiple times I get a series of them
Eric J. Smith
@ejsmith
yeah, I think that is definitely useful
and should be quick
Blake Niemyjski
@niemyjski
yeah
Blake Niemyjski
@niemyjski
@ejsmith @srijken
it appears we are doing
            hashCode = (hashCode * 397) ^ TotalPhysicalMemory.GetHashCode();
            hashCode = (hashCode * 397) ^ AvailablePhysicalMemory.GetHashCode();
            hashCode = (hashCode * 397) ^ ProcessMemorySize.GetHashCode();
            hashCode = (hashCode * 397) ^ (ThreadName == null ? 0 : ThreadName.GetHashCode());
            hashCode = (hashCode * 397) ^ (ThreadId == null ? 0 : ThreadId.GetHashCode());
which the memory one for process memory is changing by .1mb and causing it to not be deduplicated
wondering if thread id is changing it as well
Blake Niemyjski
@niemyjski
hmm
total memory is fine
but I don’t think the memory and thread ones should be there
I’m seeing reference id interferring as it’s stored in a cookie
so it’s changing that on request info
should we remove cookies from the gethashcode logic too
?
Eric J. Smith
@ejsmith
no
why would we do that?
if the cookies are different, don’t we want to see them?
Blake Niemyjski
@niemyjski
because were updating the lastreferenceid cookie value and then it’s not deduped
yeah I guess but if everything else matches then it’s kind of a dup no?
Eric J. Smith
@ejsmith
yeah, that sucks
if we can skip that one
that would be good.
Blake Niemyjski
@niemyjski
only
yeah I’ll add logic to skip that key on gethashcode
you think we should remove the threadid,thread name, available memory and process memory size from gethashcode
to me those are things that could change alot
but having those may help track down multithreaded issues