Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Dec 13 22:43
    ejsmith synchronize #452
  • Dec 13 22:43

    ejsmith on elastic7

    More reindex job changes (compare)

  • Dec 13 15:46
    ejsmith synchronize #452
  • Dec 13 15:46

    ejsmith on elastic7

    Just retry 3 times (compare)

  • Dec 13 15:44
    ejsmith synchronize #452
  • Dec 13 15:44

    ejsmith on elastic7

    More log message changes (compare)

  • Dec 13 14:25
    niemyjski synchronize #452
  • Dec 13 14:25

    niemyjski on elastic7

    Added retry reindex for disconn… (compare)

  • Dec 13 14:09
    niemyjski synchronize #452
  • Dec 13 14:09

    niemyjski on elastic7

    Updated migration to retry sock… (compare)

  • Dec 13 04:51
  • Dec 13 03:28
    ejsmith synchronize #452
  • Dec 13 03:28

    ejsmith on elastic7

    Oops progress (compare)

  • Dec 13 03:04
    ejsmith synchronize #452
  • Dec 13 03:04

    ejsmith on elastic7

    More log formatting (compare)

  • Dec 13 02:02
    ejsmith synchronize #452
  • Dec 13 02:02

    ejsmith on elastic7

    Fix tests? (compare)

  • Dec 13 01:18
    ejsmith synchronize #452
  • Dec 13 01:18

    ejsmith on elastic7

    Change duration format (compare)

  • Dec 13 00:39
    ejsmith synchronize #452
Blake Niemyjski
@niemyjski
look at the above log message
Blake Niemyjski
@niemyjski
updated the unit test and it’s failing
Blake Niemyjski
@niemyjski
            c.UseLogger(new XunitExceptionlessLog(_writer));
:D
got awesome logging now in our client unit tests
Blake Niemyjski
@niemyjski
Checking event: with hash: 738490750
Checking event: with hash: -717263284
Enqueueing event with hash:-717263284 to cache.
Checking event: with hash: -717263284
Enqueueing event with hash:-717263284 to cache.
Checking event: with hash: -717263284
Enqueueing event with hash:-717263284 to cache.
Enqueueing event with hash:738490750 to cache.
Checking event: with hash: -717263284
Checking event: with hash: -717263284
def having a threading issue
with the plugin
changed the forloop to a parallel 4 and everything broke loose
Blake Niemyjski
@niemyjski
@srijken would you be willing to help me look into why the concurrent ones are failing? I added unit tests with improved logging
I think we might need to add some locking code in there
which is both scary and sucks
Blake Niemyjski
@niemyjski
I Added a lock around all of it
and it increased the run time quite a bit
I’m also seeing a weird issue where 1 out of 4 runs fails with invalid hashcode
Enqueueing event with hash:-1799816918 to cache.
Adding event with hash:-1799816918 to cache.
Enqueueing event with hash:825815748 to cache.
Ignoring duplicate event with hash:-1799816918
Ignoring duplicate event with hash:-1799816918
Ignoring duplicate event with hash:-1799816918
Ignoring duplicate event with hash:-1799816918
Ignoring duplicate event with hash:-1799816918
Ignoring duplicate event with hash:-1799816918
Ignoring duplicate event with hash:-1799816918
same code paths and event being generated
Blake Niemyjski
@niemyjski

DeduplicationBenchmarks_IdenticalExceptions, 116 runs

DeduplicationBenchmarks_IdenticalExceptions - 0.01ms

DeduplicationBenchmarks_LargeEventsFromFiles, 103 runs

DeduplicationBenchmarks_LargeEventsFromFiles - 0.30ms

DeduplicationBenchmarks_RandomExceptions, 110 runs

DeduplicationBenchmarks_RandomExceptions - 0.01ms

that’s what it was before my change
lets see what it is on the build server now
@ejsmith @srijken feedback on this is greatly appreciated: exceptionless/Exceptionless.Net@9a34941

DeduplicationBenchmarks_IdenticalExceptions, 114 runs

DeduplicationBenchmarks_IdenticalExceptions - 0.01ms

DeduplicationBenchmarks_LargeEventsFromFiles, 214 runs

DeduplicationBenchmarks_LargeEventsFromFiles - 0.31ms

DeduplicationBenchmarks_RandomExceptions, 112 runs

DeduplicationBenchmarks_RandomExceptions - 0.01ms

didn’t seem to slow it down any
Blake Niemyjski
@niemyjski
@frankebersoll https://github.com/sergeyt/karma-typescript-preprocessor/issues/30#issuecomment-99655328 looks like the tooling is starting to support typescript a bit better :)
Sander Rijken
@srijken
Hi, reading
agree on removing those properties from gethashcode
locking thing.. it’s weird that it’s necessary?
concurrent queue should fix concurrency issues
Sander Rijken
@srijken

DuplicateCheckerPlugin: Checking event: with hash: -1999577676
DuplicateCheckerPlugin: Checking event: with hash: -25846723
DuplicateCheckerPlugin: Checking event: with hash: -25846723
DuplicateCheckerPlugin: Checking event: with hash: -688792890
DuplicateCheckerPlugin: Checking event: with hash: -25846723
DuplicateCheckerPlugin: Checking event: with hash: -1999577676
DuplicateCheckerPlugin: Enqueueing event with hash:-1999577676 to cache.
DuplicateCheckerPlugin: Enqueueing event with hash:-25846723 to cache.
DuplicateCheckerPlugin: Enqueueing event with hash:-1999577676 to cache.
DuplicateCheckerPlugin: Enqueueing event with hash:-25846723 to cache.
DuplicateCheckerPlugin: Enqueueing event with hash:-688792890 to cache.
DuplicateCheckerPlugin: Enqueueing event with hash:-25846723 to cache.

^^ What’s wrong with that?

except for the hash calculations
Blake Niemyjski
@niemyjski
yeah
well those are all called concurrently
and they are all enqueued
when some of those should be ignored
Sander Rijken
@srijken
that’s because the hashes don’t match up
Blake Niemyjski
@niemyjski
yeah
look
Sander Rijken
@srijken
so we must make sure they do match?
Blake Niemyjski
@niemyjski
-2584673 all of those were enqueued and were the same number
same for the -1999577676
yeah there is something goofy going on
Sander Rijken
@srijken
oh wait
it’s enqueueing them too often
Blake Niemyjski
@niemyjski
yeah
idealy no lock would be good but if you look at it without one it’s chaos
Sander Rijken
@srijken
can you add timestamps to the log output?
I’m pretty convinced it should work without the lock
the lock doesn’t fix the issue either right?
Blake Niemyjski
@niemyjski
yeah we could do that by updating the xunit base class
xunitexceptionlesslog