Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 01:59
    BrisWhite commented #461
  • Oct 23 14:55
    ejsmith synchronize #452
  • Oct 23 14:55

    ejsmith on elastic7

    Update appveyor.yml (compare)

  • Oct 23 14:42
    niemyjski synchronize #452
  • Oct 23 14:42

    niemyjski on elastic7

    Updated to elasticsearch 7.4.1 (compare)

  • Oct 23 12:21
    niemyjski synchronize #452
  • Oct 23 12:21

    niemyjski on elastic7

    WIP - Added migration job to mi… (compare)

  • Oct 23 11:34
    niemyjski labeled #462
  • Oct 23 11:34
    niemyjski commented #462
  • Oct 23 11:34
    niemyjski commented #461
  • Oct 23 02:09
    kfj1688 opened #462
  • Oct 23 01:42
    BrisWhite commented #461
  • Oct 22 13:52
    niemyjski labeled #461
  • Oct 22 13:52
    niemyjski commented #461
  • Oct 22 13:35
    niemyjski synchronize #452
  • Oct 22 13:35

    niemyjski on elastic7

    Moved migration job (compare)

  • Oct 22 12:32
    niemyjski synchronize #452
  • Oct 22 12:32

    niemyjski on elastic7

    Added migration job (compare)

  • Oct 22 12:09
    niemyjski synchronize #452
  • Oct 22 12:09

    niemyjski on elastic7

    Fixed tests (compare)

Blake Niemyjski
@niemyjski
lets see what it is on the build server now
@ejsmith @srijken feedback on this is greatly appreciated: exceptionless/Exceptionless.Net@9a34941

DeduplicationBenchmarks_IdenticalExceptions, 114 runs

DeduplicationBenchmarks_IdenticalExceptions - 0.01ms

DeduplicationBenchmarks_LargeEventsFromFiles, 214 runs

DeduplicationBenchmarks_LargeEventsFromFiles - 0.31ms

DeduplicationBenchmarks_RandomExceptions, 112 runs

DeduplicationBenchmarks_RandomExceptions - 0.01ms

didn’t seem to slow it down any
Blake Niemyjski
@niemyjski
@frankebersoll https://github.com/sergeyt/karma-typescript-preprocessor/issues/30#issuecomment-99655328 looks like the tooling is starting to support typescript a bit better :)
Sander Rijken
@srijken
Hi, reading
agree on removing those properties from gethashcode
locking thing.. it’s weird that it’s necessary?
concurrent queue should fix concurrency issues
Sander Rijken
@srijken

DuplicateCheckerPlugin: Checking event: with hash: -1999577676
DuplicateCheckerPlugin: Checking event: with hash: -25846723
DuplicateCheckerPlugin: Checking event: with hash: -25846723
DuplicateCheckerPlugin: Checking event: with hash: -688792890
DuplicateCheckerPlugin: Checking event: with hash: -25846723
DuplicateCheckerPlugin: Checking event: with hash: -1999577676
DuplicateCheckerPlugin: Enqueueing event with hash:-1999577676 to cache.
DuplicateCheckerPlugin: Enqueueing event with hash:-25846723 to cache.
DuplicateCheckerPlugin: Enqueueing event with hash:-1999577676 to cache.
DuplicateCheckerPlugin: Enqueueing event with hash:-25846723 to cache.
DuplicateCheckerPlugin: Enqueueing event with hash:-688792890 to cache.
DuplicateCheckerPlugin: Enqueueing event with hash:-25846723 to cache.

^^ What’s wrong with that?

except for the hash calculations
Blake Niemyjski
@niemyjski
yeah
well those are all called concurrently
and they are all enqueued
when some of those should be ignored
Sander Rijken
@srijken
that’s because the hashes don’t match up
Blake Niemyjski
@niemyjski
yeah
look
Sander Rijken
@srijken
so we must make sure they do match?
Blake Niemyjski
@niemyjski
-2584673 all of those were enqueued and were the same number
same for the -1999577676
yeah there is something goofy going on
Sander Rijken
@srijken
oh wait
it’s enqueueing them too often
Blake Niemyjski
@niemyjski
yeah
idealy no lock would be good but if you look at it without one it’s chaos
Sander Rijken
@srijken
can you add timestamps to the log output?
I’m pretty convinced it should work without the lock
the lock doesn’t fix the issue either right?
Blake Niemyjski
@niemyjski
yeah we could do that by updating the xunit base class
xunitexceptionlesslog
it does part of the time
still fails randomly
Sander Rijken
@srijken
yeah so there’s something else to it
Blake Niemyjski
@niemyjski
yeah
nothing stood out to me
tried breaking it down
Sander Rijken
@srijken
computer is slow
Eric J. Smith
@ejsmith
more random test failures? :-(
Sander Rijken
@srijken
@niemyjski what’s the exact testcase you’re running?
I think I foudn it :P
hm it works for me
Blake Niemyjski
@niemyjski
run it multiple times and it will fail
@ejsmith just with dedup on multithreaded
@srijken I can reproduce it everytime by triggering new mvc errors
just click it the same error multiple times (api post and api get links)
Sander Rijken
@srijken
the hash mismatch is caused in .Data
I noticed that .Data implements its own GetHashCode(), should use the extensions one
GetCollectionHashCode()
Blake Niemyjski
@niemyjski
hmm