Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
Blake Niemyjski
@niemyjski
when some of those should be ignored
Sander Rijken
@srijken
that’s because the hashes don’t match up
Blake Niemyjski
@niemyjski
yeah
look
Sander Rijken
@srijken
so we must make sure they do match?
Blake Niemyjski
@niemyjski
-2584673 all of those were enqueued and were the same number
same for the -1999577676
yeah there is something goofy going on
Sander Rijken
@srijken
oh wait
it’s enqueueing them too often
Blake Niemyjski
@niemyjski
yeah
idealy no lock would be good but if you look at it without one it’s chaos
Sander Rijken
@srijken
can you add timestamps to the log output?
I’m pretty convinced it should work without the lock
the lock doesn’t fix the issue either right?
Blake Niemyjski
@niemyjski
yeah we could do that by updating the xunit base class
xunitexceptionlesslog
it does part of the time
still fails randomly
Sander Rijken
@srijken
yeah so there’s something else to it
Blake Niemyjski
@niemyjski
yeah
nothing stood out to me
tried breaking it down
Sander Rijken
@srijken
computer is slow
Eric J. Smith
@ejsmith
more random test failures? :-(
Sander Rijken
@srijken
@niemyjski what’s the exact testcase you’re running?
I think I foudn it :P
hm it works for me
Blake Niemyjski
@niemyjski
run it multiple times and it will fail
@ejsmith just with dedup on multithreaded
@srijken I can reproduce it everytime by triggering new mvc errors
just click it the same error multiple times (api post and api get links)
Sander Rijken
@srijken
the hash mismatch is caused in .Data
I noticed that .Data implements its own GetHashCode(), should use the extensions one
GetCollectionHashCode()
Blake Niemyjski
@niemyjski
hmm
ok
weird
data should be exactly the same on all of those
nice catch
Sander Rijken
@srijken
that one will order the keys before calculating the hashcode
it’s not what’s causing the problem though
Blake Niemyjski
@niemyjski
hmm ok
Sander Rijken
@srijken
but you can delete a bunch of code, which is always nice
Blake Niemyjski
@niemyjski
ok
Blake Niemyjski
@niemyjski
@srijken have you figured out a good way to see how gethashcode is being miscalculated
also, does each line need to be (dashcode ^ 397) or just the whole thing on the return?
Sander Rijken
@srijken
it’s what R# generates. I read up on why it did that, and it sounded like a good idea
397 is a fairly large prime number
Blake Niemyjski
@niemyjski
yeah