Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 01:59
    BrisWhite commented #461
  • Oct 23 14:55
    ejsmith synchronize #452
  • Oct 23 14:55

    ejsmith on elastic7

    Update appveyor.yml (compare)

  • Oct 23 14:42
    niemyjski synchronize #452
  • Oct 23 14:42

    niemyjski on elastic7

    Updated to elasticsearch 7.4.1 (compare)

  • Oct 23 12:21
    niemyjski synchronize #452
  • Oct 23 12:21

    niemyjski on elastic7

    WIP - Added migration job to mi… (compare)

  • Oct 23 11:34
    niemyjski labeled #462
  • Oct 23 11:34
    niemyjski commented #462
  • Oct 23 11:34
    niemyjski commented #461
  • Oct 23 02:09
    kfj1688 opened #462
  • Oct 23 01:42
    BrisWhite commented #461
  • Oct 22 13:52
    niemyjski labeled #461
  • Oct 22 13:52
    niemyjski commented #461
  • Oct 22 13:35
    niemyjski synchronize #452
  • Oct 22 13:35

    niemyjski on elastic7

    Moved migration job (compare)

  • Oct 22 12:32
    niemyjski synchronize #452
  • Oct 22 12:32

    niemyjski on elastic7

    Added migration job (compare)

  • Oct 22 12:09
    niemyjski synchronize #452
  • Oct 22 12:09

    niemyjski on elastic7

    Fixed tests (compare)

Blake Niemyjski
@niemyjski
yeah
nothing stood out to me
tried breaking it down
Sander Rijken
@srijken
computer is slow
Eric J. Smith
@ejsmith
more random test failures? :-(
Sander Rijken
@srijken
@niemyjski what’s the exact testcase you’re running?
I think I foudn it :P
hm it works for me
Blake Niemyjski
@niemyjski
run it multiple times and it will fail
@ejsmith just with dedup on multithreaded
@srijken I can reproduce it everytime by triggering new mvc errors
just click it the same error multiple times (api post and api get links)
Sander Rijken
@srijken
the hash mismatch is caused in .Data
I noticed that .Data implements its own GetHashCode(), should use the extensions one
GetCollectionHashCode()
Blake Niemyjski
@niemyjski
hmm
ok
weird
data should be exactly the same on all of those
nice catch
Sander Rijken
@srijken
that one will order the keys before calculating the hashcode
it’s not what’s causing the problem though
Blake Niemyjski
@niemyjski
hmm ok
Sander Rijken
@srijken
but you can delete a bunch of code, which is always nice
Blake Niemyjski
@niemyjski
ok
Blake Niemyjski
@niemyjski
@srijken have you figured out a good way to see how gethashcode is being miscalculated
also, does each line need to be (dashcode ^ 397) or just the whole thing on the return?
Sander Rijken
@srijken
it’s what R# generates. I read up on why it did that, and it sounded like a good idea
397 is a fairly large prime number
Blake Niemyjski
@niemyjski
yeah
Sander Rijken
@srijken
determining what causes it is a painful job
Blake Niemyjski
@niemyjski
yeah :(
weird thing is it seems to happen on that unit test ever few executions
Sander Rijken
@srijken
it’s coming from the Modules collection inside Error
Blake Niemyjski
@niemyjski
hmm
wonder if it has to do with the module id calculation
cause that changes
maybe modules need to be sorted?
if so that’s a pita
do we even care about module info
@ejsmith
too me just because a module is added or removed an error occurs doesn’t mean anything even on module load errors
Sander Rijken
@srijken
it’s not the order
Blake Niemyjski
@niemyjski
we reassign the module id on every ToExceptionless()
are they different?
I compared them with beyond compare and they were all the same on my machine (checked 6 dupes that came through) only thing that was different was the reference id
Sander Rijken
@srijken
checking
not the ID either
Blake Niemyjski
@niemyjski
id, date and reference id stuff was different when I checked on the raw json serverside
Sander Rijken
@srijken
what ID? event ID or ModuleID?