Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Sep 20 13:20

    niemyjski on elastic7

    Fixed more unit tests (compare)

  • Sep 20 12:11
    niemyjski commented #447
  • Sep 20 07:42
    ZhiqiangTao commented #447
  • Sep 19 22:56

    niemyjski on elastic7

    bumped major and deps (fixed te… (compare)

  • Sep 19 14:20

    niemyjski on elastic7

    Fixed all issues with the event… (compare)

  • Sep 19 07:04
  • Sep 19 04:49
  • Sep 19 03:32
  • Sep 18 12:46
    LydellM commented #448
  • Sep 18 12:38
    niemyjski labeled #448
  • Sep 18 12:37
    niemyjski closed #448
  • Sep 18 12:37
    niemyjski commented #448
  • Sep 18 12:37
    niemyjski commented #448
  • Sep 18 12:35
    niemyjski commented #447
  • Sep 18 07:09
    ZhiqiangTao closed #447
  • Sep 18 05:31
    leehomlee starred exceptionless/Exceptionless
  • Sep 18 03:17
  • Sep 18 02:13

    niemyjski on elastic7

    More ES7 Changes (compare)

  • Sep 17 20:34
    LydellM opened #448
  • Sep 17 14:43
Sander Rijken
@srijken
hm it works for me
Blake Niemyjski
@niemyjski
run it multiple times and it will fail
@ejsmith just with dedup on multithreaded
@srijken I can reproduce it everytime by triggering new mvc errors
just click it the same error multiple times (api post and api get links)
Sander Rijken
@srijken
the hash mismatch is caused in .Data
I noticed that .Data implements its own GetHashCode(), should use the extensions one
GetCollectionHashCode()
Blake Niemyjski
@niemyjski
hmm
ok
weird
data should be exactly the same on all of those
nice catch
Sander Rijken
@srijken
that one will order the keys before calculating the hashcode
it’s not what’s causing the problem though
Blake Niemyjski
@niemyjski
hmm ok
Sander Rijken
@srijken
but you can delete a bunch of code, which is always nice
Blake Niemyjski
@niemyjski
ok
Blake Niemyjski
@niemyjski
@srijken have you figured out a good way to see how gethashcode is being miscalculated
also, does each line need to be (dashcode ^ 397) or just the whole thing on the return?
Sander Rijken
@srijken
it’s what R# generates. I read up on why it did that, and it sounded like a good idea
397 is a fairly large prime number
Blake Niemyjski
@niemyjski
yeah
Sander Rijken
@srijken
determining what causes it is a painful job
Blake Niemyjski
@niemyjski
yeah :(
weird thing is it seems to happen on that unit test ever few executions
Sander Rijken
@srijken
it’s coming from the Modules collection inside Error
Blake Niemyjski
@niemyjski
hmm
wonder if it has to do with the module id calculation
cause that changes
maybe modules need to be sorted?
if so that’s a pita
do we even care about module info
@ejsmith
too me just because a module is added or removed an error occurs doesn’t mean anything even on module load errors
Sander Rijken
@srijken
it’s not the order
Blake Niemyjski
@niemyjski
we reassign the module id on every ToExceptionless()
are they different?
I compared them with beyond compare and they were all the same on my machine (checked 6 dupes that came through) only thing that was different was the reference id
Sander Rijken
@srijken
checking
not the ID either
Blake Niemyjski
@niemyjski
id, date and reference id stuff was different when I checked on the raw json serverside
Sander Rijken
@srijken
what ID? event ID or ModuleID?
Blake Niemyjski
@niemyjski
event id
Sander Rijken
@srijken
the testcase itself isn’t stable either.. Right now I have the same consistent hashcode, and it fails because it gets 8 where it expects 9
that bit is a timing problem
when it gets 2 where it expects 1, it’s a hashcode problem
Eric J. Smith
@ejsmith
I see my name was mentioned and there are like 100 messages?
Blake Niemyjski
@niemyjski
yeah
so there are two different issues