Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 14:55
    ejsmith synchronize #452
  • 14:55

    ejsmith on elastic7

    Update appveyor.yml (compare)

  • 14:42
    niemyjski synchronize #452
  • 14:42

    niemyjski on elastic7

    Updated to elasticsearch 7.4.1 (compare)

  • 12:21
    niemyjski synchronize #452
  • 12:21

    niemyjski on elastic7

    WIP - Added migration job to mi… (compare)

  • 11:34
    niemyjski labeled #462
  • 11:34
    niemyjski commented #462
  • 11:34
    niemyjski commented #461
  • 02:09
    kfj1688 opened #462
  • 01:42
    BrisWhite commented #461
  • Oct 22 13:52
    niemyjski labeled #461
  • Oct 22 13:52
    niemyjski commented #461
  • Oct 22 13:35
    niemyjski synchronize #452
  • Oct 22 13:35

    niemyjski on elastic7

    Moved migration job (compare)

  • Oct 22 12:32
    niemyjski synchronize #452
  • Oct 22 12:32

    niemyjski on elastic7

    Added migration job (compare)

  • Oct 22 12:09
    niemyjski synchronize #452
  • Oct 22 12:09

    niemyjski on elastic7

    Fixed tests (compare)

  • Oct 22 09:50
Blake Niemyjski
@niemyjski
yeah :(
weird thing is it seems to happen on that unit test ever few executions
Sander Rijken
@srijken
it’s coming from the Modules collection inside Error
Blake Niemyjski
@niemyjski
hmm
wonder if it has to do with the module id calculation
cause that changes
maybe modules need to be sorted?
if so that’s a pita
do we even care about module info
@ejsmith
too me just because a module is added or removed an error occurs doesn’t mean anything even on module load errors
Sander Rijken
@srijken
it’s not the order
Blake Niemyjski
@niemyjski
we reassign the module id on every ToExceptionless()
are they different?
I compared them with beyond compare and they were all the same on my machine (checked 6 dupes that came through) only thing that was different was the reference id
Sander Rijken
@srijken
checking
not the ID either
Blake Niemyjski
@niemyjski
id, date and reference id stuff was different when I checked on the raw json serverside
Sander Rijken
@srijken
what ID? event ID or ModuleID?
Blake Niemyjski
@niemyjski
event id
Sander Rijken
@srijken
the testcase itself isn’t stable either.. Right now I have the same consistent hashcode, and it fails because it gets 8 where it expects 9
that bit is a timing problem
when it gets 2 where it expects 1, it’s a hashcode problem
Eric J. Smith
@ejsmith
I see my name was mentioned and there are like 100 messages?
Blake Niemyjski
@niemyjski
yeah
so there are two different issues
@ejsmith yeah there were questions for you me and sander and working through them now
@ejsmith do you want me to merge in the EventStats into Foundatio Elasticsearch repository read only base?
Eric J. Smith
@ejsmith
yeah, that would be nice.
Blake Niemyjski
@niemyjski
or a seperate class?
Eric J. Smith
@ejsmith
I think it would be good to have it as methods on the repo
Blake Niemyjski
@niemyjski
ok
O
I’ll merge it in with models cause I need the terms stuff on our repo
Sander Rijken
@srijken
ok, my search in .Modules was a stupid move. Conclusion now is that somehow the stacktrace is different
Blake Niemyjski
@niemyjski
how
it’s the same stack trace :\
that’s what I don’t get
I get that it could be different in mvc due to maybe a race condition in handlers but crazy
@ejsmith there’s really no good way to do this in the base class:
.WithDateRange(utcStart, utcEnd, EventIndex.Fields.PersistentEvent.Date)
.WithIndices(utcStart, utcEnd, $"'{_eventIndex.VersionedName}-'yyyyMM");
Sander Rijken
@srijken
hmf
getting quantum physics feelings right now
I’m inspecting where it’s probably failing
and it no longer fails
got it
Checking event:  with hash: 754157865 1407249123 GetException: 766225261 - ILOffset 8 - NativeOffset87
Checking event:  with hash: 752981631 1924808933 GetException: 217121131 - ILOffset 0 - NativeOffset87
Checking event:  with hash: 754157865 1407249123 GetException: 766225261 - ILOffset 8 - NativeOffset87
Checking event:  with hash: 754157865 1407249123 GetException: 766225261 - ILOffset 8 - NativeOffset87
Checking event:  with hash: 754157865 1407249123 GetException: 766225261 - ILOffset 8 - NativeOffset87
var error = context.Event.Data["@error"] as Exceptionless.Models.Data.Error;
            context.Log.FormattedInfo(typeof(DuplicateCheckerPlugin), String.Concat("Checking event: ", context.Event.Message, " with hash: ", hashCode + " " + error.StackTrace.GetCollectionHashCode() +
                 " " + string.Join(", ", error.StackTrace.Select(x => x.Name + ": " + x.GetHashCode() + " - ILOffset " + x.Data["ILOffset"] + " - NativeOffset" + x.Data["NativeOffset"]))));
so.. now what?
@niemyjski can you try this change, see if it fixes the real-world problem you were seeing?
Blake Niemyjski
@niemyjski
yeah