Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Oct 14 02:53
    wmowm commented #459
  • Oct 12 15:59
    niemyjski commented #459
  • Oct 12 15:57
    niemyjski edited #459
  • Oct 12 12:54
    niemyjski synchronize #452
  • Oct 12 12:54

    niemyjski on elastic7

    Fixed serializer null reference… Fixed all Swagger issues. (compare)

  • Oct 12 12:26
    niemyjski synchronize #452
  • Oct 12 12:26

    niemyjski on elastic7

    Updated to latest foundatio rep… (compare)

  • Oct 12 12:24
    niemyjski synchronize #452
  • Oct 12 12:24

    niemyjski on elastic7

    Fixed elasticsearch serializer … (compare)

  • Oct 12 11:01
    wmowm opened #459
  • Oct 11 11:21
    niemyjski commented #458
  • Oct 10 21:18
    kiquenet opened #458
  • Oct 10 13:30
    niemyjski updated the wiki
  • Oct 10 09:20
  • Oct 10 03:36
  • Oct 09 15:54
    john-roland closed #456
  • Oct 09 15:54
    john-roland commented #456
  • Oct 09 14:12
    niemyjski labeled #457
  • Oct 09 14:12
    niemyjski labeled #457
  • Oct 09 14:12
    niemyjski commented #457
Sander Rijken
@srijken
hashCode = (hashCode * 397) ^ (Data == null ? 0 : Data.GetCollectionHashCode(new[] { "ILOffset" }));
Blake Niemyjski
@niemyjski
wonder if we should get rid of native offset too
Sander Rijken
@srijken
now my mac is slow
that code goes in Method
Blake Niemyjski
@niemyjski
wonder why the iloffset would be different on the same executing code
Sander Rijken
@srijken
maybe it’s some kind of optimization thing
JIT and pre-JIT or something
Blake Niemyjski
@niemyjski
C:\Code\Exceptionless.Net\Source\Shared\Models\Client\Data\EnvironmentInfo.cs(131): hashCode = (hashCode 397) ^ (Data == null ? 0 : Data.GetHashCode());
C:\Code\Exceptionless.Net\Source\Shared\Models\Client\Data\InnerError.cs(64): hashCode = (hashCode
397) ^ (Data == null ? 0 : Data.GetHashCode());
C:\Code\Exceptionless.Net\Source\Shared\Models\Client\Data\Method.cs(42): hashCode = (hashCode 397) ^ (Data == null ? 0 : Data.GetCollectionHashCode(new[] { "ILOffset" }));
C:\Code\Exceptionless.Net\Source\Shared\Models\Client\Data\Module.cs(51): hashCode = (hashCode
397) ^ (Data == null ? 0 : Data.GetHashCode());
C:\Code\Exceptionless.Net\Source\Shared\Models\Client\Data\Parameter.cs(36): hashCode = (hashCode 397) ^ (Data == null ? 0 : Data.GetHashCode());
C:\Code\Exceptionless.Net\Source\Shared\Models\Client\Data\RequestInfo.cs(100): hashCode = (hashCode
397) ^ (Data == null ? 0 : Data.GetHashCode());
C:\Code\Exceptionless.Net\Source\Shared\Models\Client\Data\SimpleError.cs(53): hashCode = (hashCode 397) ^ (Data == null ? 0 : Data.GetHashCode());
C:\Code\Exceptionless.Net\Source\Shared\Models\Client\Data\UserDescription.cs(43): hashCode = (hashCode
397) ^ (Data == null ? 0 : Data.GetHashCode());
C:\Code\Exceptionless.Net\Source\Shared\Models\Client\Data\UserInfo.cs(52): hashCode = (hashCode 397) ^ (Data == null ? 0 : Data.GetHashCode());
C:\Code\Exceptionless.Net\Source\Shared\Models\Client\Event.cs(82): hashCode = (hashCode
397) ^ (Data == null ? 0 : Data.GetHashCode());
should we change all of those to GetCollectionHashCode?
Sander Rijken
@srijken
yep
and dump DataDictionary.GetHashCode()
Blake Niemyjski
@niemyjski
dump?
I changed all those to GetCollectionHashCode
Sander Rijken
@srijken
the code inside DataDictionary, that can be removed
Blake Niemyjski
@niemyjski
ok
Sander Rijken
@srijken
“My understanding is that, when provided, the IL offset is simply mapped from the native offset using a table generated at JIT time (which may be an approximation due to optimizations). For the leaf native-frame, the native offset is where the exception was thrown while non-leaf native frames use the return address from the stack which may make it look like the exception was thrown by the instruction following the one where the exception actually happened."
Blake Niemyjski
@niemyjski
hmm ok
so get rid of the equals and gethashcode overrides in the data
Sander Rijken
@srijken
yeah
Blake Niemyjski
@niemyjski
ok
wonderingi f we should leave it as it’s not hurting anything
Sander Rijken
@srijken
this dedupe thing?
Blake Niemyjski
@niemyjski
the equals and get hashcode on data dictionary
if you look on the data dictionary we are telling it to ignore tracelogs
Sander Rijken
@srijken
hmf
complicated stuff
Blake Niemyjski
@niemyjski
yeah
you changed it :D
lol
Sander Rijken
@srijken
:)
so basically what we want is ignore @trace on Error.Data
Blake Niemyjski
@niemyjski
yeah I guess
can add that to an exclusion I guess
and delete that equals code
seems to all be working great!
Sander Rijken
@srijken
just pass that key to .GetCollectionHashCode()
Blake Niemyjski
@niemyjski
that pull request you submitted couldn’t be merged
yeah
Sander Rijken
@srijken
yeah I noticed, I’ll fix it
first fix this stuff :)
right now I’m checking why we need the locking
Blake Niemyjski
@niemyjski
pushed the changes :)
they fixed all the issues with mvc!!!
glad I tested before deploying heehe
Sander Rijken
@srijken
_processed.Any() is on IEnumerable, so that’s not threadsafe
Blake Niemyjski
@niemyjski
hmm
yeah
Sander Rijken
@srijken
we want queue behavior for cleanup