Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 09:40
    zhangyiqiu starred exceptionless/Exceptionless
  • 07:45
  • 05:47
    ejsmith edited #471
  • 05:46
    ejsmith opened #471
  • 05:46

    ejsmith on strip-large-data

    Strip large data values out of … (compare)

  • Dec 11 19:54
    niemyjski synchronize #452
  • Dec 11 19:54

    niemyjski on elastic7

    Decrease batch size (compare)

  • Dec 11 14:51
    niemyjski synchronize #452
  • Dec 11 14:51

    niemyjski on elastic7

    Reset the alias cache before ru… (compare)

  • Dec 11 04:03

    ejsmith on mappings-refactor

    (compare)

  • Dec 11 04:02
    ejsmith synchronize #452
  • Dec 11 04:02

    ejsmith on elastic7

    Change a bunch of index field s… Updated dependencies. Revert to 2201-pre and 6 more (compare)

  • Dec 11 04:02
    ejsmith closed #470
  • Dec 11 04:02
    ejsmith edited #470
  • Dec 11 03:59
    ejsmith opened #470
  • Dec 11 03:14

    niemyjski on mappings-refactor

    Updated to latest foundatio (compare)

  • Dec 11 02:59

    niemyjski on mappings-refactor

    Tweaked the event index mapping… (compare)

  • Dec 11 01:53

    ejsmith on mappings-refactor

    Update cache client list method… (compare)

  • Dec 11 01:19

    ejsmith on mappings-refactor

    More index work (compare)

  • Dec 10 13:26
    niemyjski commented #468
Blake Niemyjski
@niemyjski
ok
Sander Rijken
@srijken
“My understanding is that, when provided, the IL offset is simply mapped from the native offset using a table generated at JIT time (which may be an approximation due to optimizations). For the leaf native-frame, the native offset is where the exception was thrown while non-leaf native frames use the return address from the stack which may make it look like the exception was thrown by the instruction following the one where the exception actually happened."
Blake Niemyjski
@niemyjski
hmm ok
so get rid of the equals and gethashcode overrides in the data
Sander Rijken
@srijken
yeah
Blake Niemyjski
@niemyjski
ok
wonderingi f we should leave it as it’s not hurting anything
Sander Rijken
@srijken
this dedupe thing?
Blake Niemyjski
@niemyjski
the equals and get hashcode on data dictionary
if you look on the data dictionary we are telling it to ignore tracelogs
Sander Rijken
@srijken
hmf
complicated stuff
Blake Niemyjski
@niemyjski
yeah
you changed it :D
lol
Sander Rijken
@srijken
:)
so basically what we want is ignore @trace on Error.Data
Blake Niemyjski
@niemyjski
yeah I guess
can add that to an exclusion I guess
and delete that equals code
seems to all be working great!
Sander Rijken
@srijken
just pass that key to .GetCollectionHashCode()
Blake Niemyjski
@niemyjski
that pull request you submitted couldn’t be merged
yeah
Sander Rijken
@srijken
yeah I noticed, I’ll fix it
first fix this stuff :)
right now I’m checking why we need the locking
Blake Niemyjski
@niemyjski
pushed the changes :)
they fixed all the issues with mvc!!!
glad I tested before deploying heehe
Sander Rijken
@srijken
_processed.Any() is on IEnumerable, so that’s not threadsafe
Blake Niemyjski
@niemyjski
hmm
yeah
Sander Rijken
@srijken
we want queue behavior for cleanup
for the rest we want ConcurrentDictionary behavior
Blake Niemyjski
@niemyjski
really wish I could step into these extension methods or go to source but all I see is empty definitions
yep
Sander Rijken
@srijken
_mergedEvents.FirstOrDefault() has the same issue
Blake Niemyjski
@niemyjski
yeah
Sander Rijken
@srijken
hmm what to do
Blake Niemyjski
@niemyjski
well I think the issue is that it’s not found in the queue and then other code runs then it enqueues it between checks and the lock prevents that
Sander Rijken
@srijken
the lock makes the whole thing threadsafe yeah
btw, what’s the difference between FormattedInfo and FormattedTrace?
couldn’t get the Trace to show up in the test runner
Blake Niemyjski
@niemyjski
not sure
oh
LogLevel
and there is a min level in the unit tests of Debug