Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 02:53
    wmowm commented #459
  • Oct 12 15:59
    niemyjski commented #459
  • Oct 12 15:57
    niemyjski edited #459
  • Oct 12 12:54
    niemyjski synchronize #452
  • Oct 12 12:54

    niemyjski on elastic7

    Fixed serializer null reference… Fixed all Swagger issues. (compare)

  • Oct 12 12:26
    niemyjski synchronize #452
  • Oct 12 12:26

    niemyjski on elastic7

    Updated to latest foundatio rep… (compare)

  • Oct 12 12:24
    niemyjski synchronize #452
  • Oct 12 12:24

    niemyjski on elastic7

    Fixed elasticsearch serializer … (compare)

  • Oct 12 11:01
    wmowm opened #459
  • Oct 11 11:21
    niemyjski commented #458
  • Oct 10 21:18
    kiquenet opened #458
  • Oct 10 13:30
    niemyjski updated the wiki
  • Oct 10 09:20
  • Oct 10 03:36
  • Oct 09 15:54
    john-roland closed #456
  • Oct 09 15:54
    john-roland commented #456
  • Oct 09 14:12
    niemyjski labeled #457
  • Oct 09 14:12
    niemyjski labeled #457
  • Oct 09 14:12
    niemyjski commented #457
Sander Rijken
@srijken
:)
so basically what we want is ignore @trace on Error.Data
Blake Niemyjski
@niemyjski
yeah I guess
can add that to an exclusion I guess
and delete that equals code
seems to all be working great!
Sander Rijken
@srijken
just pass that key to .GetCollectionHashCode()
Blake Niemyjski
@niemyjski
that pull request you submitted couldn’t be merged
yeah
Sander Rijken
@srijken
yeah I noticed, I’ll fix it
first fix this stuff :)
right now I’m checking why we need the locking
Blake Niemyjski
@niemyjski
pushed the changes :)
they fixed all the issues with mvc!!!
glad I tested before deploying heehe
Sander Rijken
@srijken
_processed.Any() is on IEnumerable, so that’s not threadsafe
Blake Niemyjski
@niemyjski
hmm
yeah
Sander Rijken
@srijken
we want queue behavior for cleanup
for the rest we want ConcurrentDictionary behavior
Blake Niemyjski
@niemyjski
really wish I could step into these extension methods or go to source but all I see is empty definitions
yep
Sander Rijken
@srijken
_mergedEvents.FirstOrDefault() has the same issue
Blake Niemyjski
@niemyjski
yeah
Sander Rijken
@srijken
hmm what to do
Blake Niemyjski
@niemyjski
well I think the issue is that it’s not found in the queue and then other code runs then it enqueues it between checks and the lock prevents that
Sander Rijken
@srijken
the lock makes the whole thing threadsafe yeah
btw, what’s the difference between FormattedInfo and FormattedTrace?
couldn’t get the Trace to show up in the test runner
Blake Niemyjski
@niemyjski
not sure
oh
LogLevel
and there is a min level in the unit tests of Debug
could update that in GetClient
Sander Rijken
@srijken
to get rid of the lock, we would have to keep both a concurrentdictionary (for checking if we have them) and a concurrentqueue (for cleanup of the dictionary)
Blake Niemyjski
@niemyjski
or CreateClient on the plugin tests
well if we are locking do we even need concurrentqueue anymore?
Sander Rijken
@srijken
no
Blake Niemyjski
@niemyjski
and is concurrentdictionary even in the pcl?
Sander Rijken
@srijken
we could also do a reader/writer lock
Blake Niemyjski
@niemyjski
what ever you think is best and easiest to maintain :)
Sander Rijken
@srijken
:)
it’s not that much harder
Blake Niemyjski
@niemyjski
@ejsmith this stuff is pretty specific to exceptionless
hitting some roadblocks
Eric J. Smith
@ejsmith
with the aggregations?
stuff like avg:somefield min:somefield, max:somefield
that shouldn’t be specific
Blake Niemyjski
@niemyjski
i know
but we need access to the elastic index for alias name