Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • Nov 20 15:34

    dependabot[bot] on npm_and_yarn

    (compare)

  • Nov 20 15:34

    niemyjski on master

    Bump js-yaml from 3.11.0 to 3.1… Merge pull request #88 from exc… (compare)

  • Nov 20 15:34
    niemyjski closed #88
  • Nov 20 14:26
    CLAassistant commented #88
  • Nov 20 14:25
    dependabot[bot] labeled #88
  • Nov 20 14:25
    dependabot[bot] opened #88
  • Nov 20 14:25

    dependabot[bot] on npm_and_yarn

    Bump js-yaml from 3.11.0 to 3.1… (compare)

  • Nov 20 14:24

    dependabot[bot] on npm_and_yarn

    (compare)

  • Nov 20 14:24

    niemyjski on master

    Bump mixin-deep from 1.3.1 to 1… Merge pull request #87 from exc… (compare)

  • Nov 20 14:24
    niemyjski closed #87
  • Nov 20 03:01
  • Nov 19 09:24
  • Nov 18 01:47
  • Nov 15 15:45
    niemyjski synchronize #452
  • Nov 15 15:45

    niemyjski on elastic7

    Fixed reindex mapping issues on… (compare)

  • Nov 15 03:05
    foresightyj closed #467
  • Nov 15 03:05
    foresightyj commented #467
  • Nov 15 03:03
    foresightyj edited #467
  • Nov 15 03:02
    foresightyj opened #467
  • Nov 14 14:41
    niemyjski synchronize #452
Blake Niemyjski
@niemyjski
could update that in GetClient
Sander Rijken
@srijken
to get rid of the lock, we would have to keep both a concurrentdictionary (for checking if we have them) and a concurrentqueue (for cleanup of the dictionary)
Blake Niemyjski
@niemyjski
or CreateClient on the plugin tests
well if we are locking do we even need concurrentqueue anymore?
Sander Rijken
@srijken
no
Blake Niemyjski
@niemyjski
and is concurrentdictionary even in the pcl?
Sander Rijken
@srijken
we could also do a reader/writer lock
Blake Niemyjski
@niemyjski
what ever you think is best and easiest to maintain :)
Sander Rijken
@srijken
:)
it’s not that much harder
Blake Niemyjski
@niemyjski
@ejsmith this stuff is pretty specific to exceptionless
hitting some roadblocks
Eric J. Smith
@ejsmith
with the aggregations?
stuff like avg:somefield min:somefield, max:somefield
that shouldn’t be specific
Blake Niemyjski
@niemyjski
i know
but we need access to the elastic index for alias name
Eric J. Smith
@ejsmith
so what is specific?
Blake Niemyjski
@niemyjski
can share my screen quick
Eric J. Smith
@ejsmith
what do you mean alias name
can’t do that.
Blake Niemyjski
@niemyjski
No generic way to inject the index on the context unless we add a constraint to the index with a <T> for the hell of it to auto inject it
then the date stuff is not generic but something we’d have to ahve
that’s only for terms tho
Screen Shot 2016-04-11 at 4.12.07 PM.png
            .WithDateRange(utcStart, utcEnd, EventIndex.Fields.PersistentEvent.Date)
            .WithIndices(utcStart, utcEnd, $"'{_eventIndex.VersionedName}-'yyyyMM”); 
is the biggest thing
you want to do smart date ranges
Sander Rijken
@srijken
@niemyjski no ReaderWriterLock in PCL it seems, so just keep the lock the way it is?
Blake Niemyjski
@niemyjski
yeah I guess
Eric J. Smith
@ejsmith
that is up to the user to pass in a filter and system filter just like any other thing in the repo
aggregations are on top of that.
Blake Niemyjski
@niemyjski
wonder if we can get away with non concurrent queues but is it worth it? what might it introduce
Eric J. Smith
@ejsmith
use the exact same query builder stuff
Blake Niemyjski
@niemyjski
yeah
ok
Sander Rijken
@srijken
and, how much do you think we gain?
Blake Niemyjski
@niemyjski
so object query as first param
yeah good idea :)
@srijken I’m not sure if anything but less chances to dead lock???
between there lock implementations and ours but I don’t see how that would happen with our locks being around everything
see first answer
that kinda suggests that it is in PCL?
oh where’s there’s a bunch of platforms
just leave it
could try a normal queue, and see if the tests + your recent problem are still OK?
Eric J. Smith
@ejsmith
really hope the new TFM stuff will make this simpler.
Sander Rijken
@srijken
TFM?
is that missing an R in front? ;)