Where communities thrive


  • Join over 1.5M+ people
  • Join over 100K+ communities
  • Free without limits
  • Create your own community
People
Activity
  • 16:39
    ejsmith synchronize #452
  • 16:39

    ejsmith on elastic7

    Log the correct task id and cat… (compare)

  • 06:25
    ejsmith synchronize #452
  • 06:25

    ejsmith on elastic7

    Minor (compare)

  • 06:00
    ejsmith synchronize #452
  • 06:00

    ejsmith on elastic7

    Add missing task id (compare)

  • Dec 13 22:43
    ejsmith synchronize #452
  • Dec 13 22:43

    ejsmith on elastic7

    More reindex job changes (compare)

  • Dec 13 15:46
    ejsmith synchronize #452
  • Dec 13 15:46

    ejsmith on elastic7

    Just retry 3 times (compare)

  • Dec 13 15:44
    ejsmith synchronize #452
  • Dec 13 15:44

    ejsmith on elastic7

    More log message changes (compare)

  • Dec 13 14:25
    niemyjski synchronize #452
  • Dec 13 14:25

    niemyjski on elastic7

    Added retry reindex for disconn… (compare)

  • Dec 13 14:09
    niemyjski synchronize #452
  • Dec 13 14:09

    niemyjski on elastic7

    Updated migration to retry sock… (compare)

  • Dec 13 04:51
  • Dec 13 03:28
    ejsmith synchronize #452
  • Dec 13 03:28

    ejsmith on elastic7

    Oops progress (compare)

  • Dec 13 03:04
    ejsmith synchronize #452
Blake Niemyjski
@niemyjski
yeah
I agree
there are some issues there that microsoft introduced
and until we drop .net 4.0 or move to standard lib I think they will be there
Sander Rijken
@srijken
I’m off to bed
Blake Niemyjski
@niemyjski
kk ty
Sander Rijken
@srijken
the build thing, I’d switch back for now, wait what they come up with
and maybe have a branch that doesn’t have that image setting?
Blake Niemyjski
@niemyjski
psuehd
pushed*
Sander Rijken
@srijken
didn’t merge the PR yet, I’ll see tomorrow what happened ;)
Blake Niemyjski
@niemyjski
ok
have a good night
Blake Niemyjski
@niemyjski
        var range = (query as IDateRangeQuery)?.DateRanges?.FirstOrDefault();
        var interval = GetInterval(range?.GetStartDate() ?? DateTime.MinValue, range?.GetEndDate() ?? DateTime.UtcNow.AddHours(1), desiredDataPoints);
makes me wonder if that should just be a parameter
if you want fine grained intervals you call it
or specify a date range
might be really hard for us to figure out the right interval generically
        var range = (query as IDateRangeQuery)?.DateRanges?.FirstOrDefault();
        if (range == null || !range.UseDateRange)
            throw new ArgumentOutOfRangeException(nameof(query), "Query must contain a valid date range.");

        var interval = GetInterval(range.GetStartDate(), range.GetEndDate(), desiredDataPoints);
DateRange has a field property that we can use
but UseDateRange will return false if the start date is not greater than DateTime.MinValue so what if you want a range of all time?
wonder if well have issues with unlimited plans..
let me know if you want to look at this with me later
Blake Niemyjski
@niemyjski

@srijken:

// Please reply above this line

From: Feodor Fitsner (Support staff)

Found a bug. Will deploy an update with the fix later today.

Blake Niemyjski
@niemyjski
I committed a change for regular queues. seems we still get a random failure with hashcodes

Assert.Equal() Failure
Expected: 1
Actual: 2

at Exceptionless.Tests.Plugins.PluginTests.VerifyDeduplicationMultithreaded() in C:\Code\Exceptionless.Net\Source\Tests\Plugins\PluginTests.cs:line 593

Enqueueing event with hash:60276899 to cache.
Adding event with hash:60276899 to cache.
Ignoring duplicate event with hash:60276899
Enqueueing event with hash:519669061 to cache.
Ignoring duplicate event with hash:60276899
Ignoring duplicate event with hash:60276899

I might just merge in your change and take a look
Blake Niemyjski
@niemyjski
I’m going to bed. I thought it could be the NativeOffset that was causing the difference but it’s not.
would be super nice if we had an AO
AOP way of injecting trace messages around GetHashCode so we could see differences.
wonder if there is something in rosyln
Eric J. Smith
@ejsmith
They have talked about adding it
Nothing yet
Blake Niemyjski
@niemyjski
:(
Blake Niemyjski
@niemyjski
@ejsmith
this is interesting
Screen Shot 2016-04-11 at 10.09.03 PM.png
looks like line number and column are changing
same exact code path (these exceptions are generated in a loop)
    private Exception GetException(string message = "Test") {
        try {
            throw new Exception(message);
        } catch (Exception ex) {
            return ex;
        }
    }
so one offset is at the first { after the argument list and the other is right before the throw
well crap.. can’t really dedup that can we
cause line number and column could be different exceptions
but then again if the method is the same and the type and everything else is the same does line number really matter
thinking we should ignore line number, column number, iloffset and native offset
Blake Niemyjski
@niemyjski
@srijken easy way to figure out the diff was to do this right above enqueue:
context.Log.Info(typeof(DuplicateCheckerPlugin), context.Resolver.GetJsonSerializer().Serialize(context.Event));
Sander Rijken
@srijken
@niemyjski and then run a JSONPatch ;)
Blake Niemyjski
@niemyjski
hehe
yeah